From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id DDDC71B789 for ; Fri, 27 Oct 2017 04:30:31 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9B2D330C02E; Thu, 26 Oct 2017 19:30:27 -0700 (PDT) Received: from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.10.118.179]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 19B2881EAE; Thu, 26 Oct 2017 19:30:27 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 26 Oct 2017 21:30:24 -0500 Message-Id: <20171027023024.42707-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) Subject: [dpdk-dev] [PATCH] net/bnxt: donot set hash type unnecessarily X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 02:30:32 -0000 We are wrongly "OR-ing" the vnic->hash_type instead of assigning the new hash type thereby wrongly configuring hash settings. Fixing it. Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 67d9bfe9d..c4da474e9 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -206,7 +206,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp) for (i = 0; i < bp->nr_vnics; i++) { STAILQ_FOREACH(vnic, &bp->ff_pool[i], next) { - vnic->hash_type |= hash_type; + vnic->hash_type = hash_type; /* * Use the supplied key if the key length is -- 2.13.5 (Apple Git-94)