From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0083.outbound.protection.outlook.com [104.47.32.83]) by dpdk.org (Postfix) with ESMTP id 957121B606 for ; Sun, 29 Oct 2017 08:48:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qlFvyvftyWf8faOqY5aJw2j0SlkT70YUttvmweOEGuc=; b=iUEXNWmi/vSMAVnIGa920w8M+7JKWY3nCobcxiBWlExICzdR3LX67LqlhdNlzBVjsYhmYRIU6udvqXoRI0mDbJxkjQSLXr0uyk+aGgU+zorK8pnIkFU5W/HG2/neXJSBvG7ZsD3l3hy3vZb6pbQoTkFw0zd9Rht6SvaVjr/x92E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Guduri.Prathyusha@cavium.com; Received: from prathyusha-Precision-Tower-5810.caveonetworks.com (111.93.218.67) by SN1PR07MB1520.namprd07.prod.outlook.com (10.161.223.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Sun, 29 Oct 2017 07:48:33 +0000 From: Guduri Prathyusha To: tomasz.kantecki@intel.com Cc: jianbo.liu@linaro.org, guduriprathyusha@gmail.com, dev@dpdk.org, Guduri Prathyusha Date: Sun, 29 Oct 2017 13:18:07 +0530 Message-Id: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0071.INDPRD01.PROD.OUTLOOK.COM (10.174.56.11) To SN1PR07MB1520.namprd07.prod.outlook.com (10.161.223.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f71bda7-e968-49b3-0ff9-08d51ea17526 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603238); SRVR:SN1PR07MB1520; X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 3:+8/0TeZ7GJXiyrC75xWZIbjtVaCGCyFa0vxq2SroVJ4SEJLUBFwEsg7//u4fv+SercX5+dlH8epmMt6ND5+5faso5ojr6kgFpHx/Z5xdvIX5Zwqc1cRpv6haOm3saiD9POctKUZ/re/JbLO2vKEkW1Anm19GN0qP/i6UhjZ8B4Dr3KgwUaD1+bqUKEQzZd5vIBnStLgx7ATWoIyTpY9fZxgcv4msSRgClve8DxwuA00/ENzicYsC+hCMZR+vF6Rm; 25:SvzWb1Zu00L5nfnK18OBxuKhiI0gTgQeCHY62ENG5Hw9U3U77eRHR2lV0DPIHq/suFA8JDyn2JVZ5wuNCFTJsTU/OU9M3uCygHZ5NhEWqHoYmXuzgnTcDM6sKDMrX0s+b/8Y1TgJRy/gMUw8G6dUmn4MLOlo43pHHJ/mLrjUecTSlJcFcoL9pUMVvNMsTbuGtq5x2hCnCcGBxrWxWk3TwkBPbKrqd8QAROvK9urcxOAEa3NH3qeXcsyZvBBbGUbEmtEBA7EP4RWm7dHfOObFTaoIYw7B7sAJQ6q5L9EyTce/AlCK7FvFr6Iop0X/uudDDuJx9aDgUhPtEvHERd5fZg==; 31:8rdX3DyII0yZrkETvbvbczR4fJe3+oopFlAySvlHFzS5fhPk3le3SJbfejYDsRIosVfmViuajq01gmYfCjrharY9ZCSdC65GjyeiUF7TApzlW89DvsaEtMcqF2U4xi+6KmgHUF77dA0gkzFWCemfsXCBpPGMOJdnXARXn7dSZaUcA6sj9L8m1IcNWL5bt3fqcR0bRhcwcHgMyxwBhAXpc3LuKPTsKFDL9w63PJ6vzhQ= X-MS-TrafficTypeDiagnostic: SN1PR07MB1520: X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 20:El59+H7bCw3f5UwdRWPO60LyzNEExnl6K+xryFvGb/KlSyP6JxtJYiBDilEB+/FU1I9W5Zycob0n9auVFzHXw19UNgH0xQVZxqjqpzJuDXgOSp8T18meO3JgnFhpDMuTOMESFetuuFYEXudpnnNje6MLWBJPoQYQAquRTnB8ZKrI8XcYw3ULbkUcKUel7M31eWfNMXaLSxFXV02JJGxIOLVA+8J/lHK4aR/F4tfmyST6rbMRMT7BuNoICPhQ9SR9PFv1lru27O3LfkrP6HiDAUepPm6S2z4CfL0tq00wxOkjdmGa9JkJnBWhdlOZYQlFiGd4eQMq2FuabYkHvItJT87bNiKVI7/k4TYbEDR2r8ftkt+n4qVGmmU7z9vVX/pQmqcU/PoOovQ1jyedKYiR0xm3dI48g+1sUR4yHv2o7HFw2YICb4yTAY3zdxzO6kmgQzDsvPyxw7sNVwfvR9FXFkWtvRXeBt/IRw9UD7NaWg68lzs5FiLBxfVNip2K/0z0o/bH0s8ByJKuUWw8Rx7pkfCIR+WgKrIrHkuMZ9eM9xRSxgghzC3hvJk7AshVAwtdP5VaTTY8QEjwKF1lKuq1w9x30jCnbZ2kF32Rc3GgC20=; 4:tAIXHZAyMurDamqFtXl0OMInHMqHPosbxh/T7V/FSkQH8QUNzGqi6DkR/aTRovVpD+TkPKd3Ne/RaizM8vAw+qi2TE4CNtptNCo7WgE9TUM+fhUy1WzpF4vuBZbDHjBgPeGq+23xokvA9z8mTyxIFthwTK6p93eCaGoWJ8b+yciWNwt3nSB5gSp4IHH1PvKexrmwAwKzlATT+rPfIqs1aewgsxZgPIuT9bCbX8wvUogGzySBedK69kgaxK7xalBE X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(3231020)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR07MB1520; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR07MB1520; X-Forefront-PRVS: 0475418F50 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39830400002)(189002)(199003)(6116002)(3846002)(5003940100001)(1076002)(97736004)(189998001)(6506006)(6486002)(5009440100003)(69596002)(66066001)(50986999)(101416001)(16586007)(316002)(107886003)(36756003)(53936002)(7736002)(50466002)(48376002)(6512007)(47776003)(39060400002)(4326008)(16526018)(6666003)(2351001)(2361001)(33646002)(81156014)(81166006)(8676002)(105586002)(106356001)(5660300001)(6916009)(42882006)(68736007)(478600001)(50226002)(8936002)(2906002)(25786009)(53416004)(72206003)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR07MB1520; H:prathyusha-Precision-Tower-5810.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR07MB1520; 23:mMFwAtJoqeI9AJiFYDeioT0kTiedOcBBsGONQcMks?= =?us-ascii?Q?mjQuTyUHjC3BUk9kiaiTdkq1CjhCspepGQ9CPu/Safq792urY0Q6+O0lEpDM?= =?us-ascii?Q?8uCsGKktp0GzLtfly51GiVv+w6PFEsJkV03WLCNFmXK4/jaW2DUyh3dePijY?= =?us-ascii?Q?Rh9XE0vlIq8eSpxow5ld6tZkGhNZc/HKfKJMJCPtb6crWACcDoL8BI2kyUq5?= =?us-ascii?Q?fXZw71lXYm817taOciKCjxCKr3ewdiM68YZv6m6XEfR45XO8jbc5HKInT9Xe?= =?us-ascii?Q?PSZfnLxrqatWmiakYHELT1QTNaP2wmaekwGxkZ8ygksxPxjbBcFJj5UY9DHA?= =?us-ascii?Q?S6Hb2pyv6LySjAQ58kbBh/rPW7o8lHUC3/AFQeB+oR9mwlJBbwCqK3q2UhxO?= =?us-ascii?Q?4RjomWOrkyNPGBQld8hojGrjrAD9cFE3peE7A/ey6xr6TzggK8hjafB43yvy?= =?us-ascii?Q?tG9d1a3S7sET4uVYE3eQ3MHzNdiXgj6JJ84zqaHCQq3CmY8nGulWLDvpPlOW?= =?us-ascii?Q?p+aVfh1AxDmD7tDqR3o+SIiy46SFZY8EvJ5eQEvZqCvIQz2zVbalC9P7gBu7?= =?us-ascii?Q?B0BlEgU62Kg5LZBNJwwLrg6NEmnnpf8YKZG58SsqSnYTUJgO8ENYV9iyN5hJ?= =?us-ascii?Q?gX+lpZFhAkYecVIoYpJThRdJhD05I+WjwuumMbAn9KUkR6OKzJQtBhVMERX1?= =?us-ascii?Q?W2yvMAAvMjrzoAcy9ohXDSGddOUZqVFtsB44VififC1D7quIBhDtmFSpvfVY?= =?us-ascii?Q?yFjEzm+0fxHqP/XzGtEIC8d5jLVkL5SFM9xwl3weFGmUHYuBZc+KQ53Quq0D?= =?us-ascii?Q?E8eh9VTz7XochB7m2P3kgl4aby7rlWqLZ7vOEW0drbjARXBZ9mXwO/t3ZTEy?= =?us-ascii?Q?Fpzs2FOj2SttAdqToerAI3cAN4gOgbGbmUZAtPAcMCt6S9WYC2l9q6WLzDNW?= =?us-ascii?Q?g2vYRxUydOZNEbLqKhiPbMT/CHLtCPQB7jQhiPonMDjlOTh3ufqdq0wK9NYA?= =?us-ascii?Q?sskJYSOPXfIiTT89bP9OZ0A/NFyWgy1CItCFavITck5D9/zGTp12MgcuOvi1?= =?us-ascii?Q?qCNMw3+5Y48nZz39p3PnHwWlN4MPnmmTO6KtArzToyKHhZ0QXh1DVUHjwx7w?= =?us-ascii?Q?aZfLVuu23cyev0K2smU0u+uJ7hUHr1x+UeTruX1WXqATFOcg0chy42FIfEmr?= =?us-ascii?Q?M/IV76rzeZlp7Qwzug0BVvcgbVZ/7bgX/RpaXUwepUVBmDTwJcM5mBNyDR1x?= =?us-ascii?Q?90zg3OQ3s5H0QL1ncg=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 6:NgZ1eteYhBiuZPERAhKAeY+NlVja2sCx9GwHX5fq3LixGoLA9GXjR8NtCgv1sWM1R6JhK+QQyDWl2Jltgl9sA7fDnHCjChmuGeJsswyK6dfbc01XTDAuXzxhTrYRbRBz1bMrnmnpvJDZ3jbcB76rh3ic6UVqfETXRRSMliHrn0WjW9bgbbuUKxeGOoEH4o7rb1MGn5LhrSaJcb7xkZ7yfEwyGLbTgW2bhG9Yx/YIVlqEyE0WAfM2wB3RR5Kt3HN9wGhTtmoGgimumCsFGgITW+rgrz8++CJQ41WFamJPExxo6Ftvujs+4BBWQedNY1BSLtf7sjwzV+AjzXST8y0LXw==; 5:tAf768DCIJ57QX9nC5bz0g8mN9foMS3gFKMvgX42UnZYpbRY37Frr97f0BjU8X0lDa+0zgYyDamb5OPDABWGZFDJJx4fq6FxZkKk65XTdQXO6/Tu6ENNZGD9wmxqaU+EOrvY7+sus7KZBn2XCwDMZQ==; 24:SrHroypZYwAlrS2NTGkfzO/j/ty/vO5RKVLz213s5EM9eKxLJgU3n0PAPPteOjyL1KY7LHElwnzLfqnkfaPI+G6qAYTvJXlOiQOfNkXMty0=; 7:Mn7jLX7WQ7Yg7EdCt7skHXp65QiCATVODAjln5AIT8tUEl7VW7yyUn/8MGXz4s6oInbzffI+MGyQ+5W/euFec0quGXJpMkjve4sA65XHhf//4SZz8Ck86rjBljxkxw0Rze98jkhET3O3+EeBy/4opVVS7FT1V2Pe3st1A+XFMDW9CwhUpV8lPWrnNYoOJ7rCVszJ4P9OSw9fY3Yvx8n/bOk8NB4XgKWHWV3C6EotON4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2017 07:48:33.0540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f71bda7-e968-49b3-0ff9-08d51ea17526 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB1520 Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix NEON instructions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 07:48:37 -0000 To group consecutive packets with same destination port in bursts of 4 neon intrinsic data types dp1 and dp2 are calculated such that if dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: and dp2 should contain: in the first iteration. dp1 should be and dp2 should be in the next iteration. dp2 in the last iteration should be . Whereas the existing code incorrectly calculates dp1 as from second iteration and thus incorrect calculation of dp2 as in the last iteration. This patch fixes the incorrect ARM NEON instructions on dp1 and dp2. Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") Signed-off-by: Guduri Prathyusha --- examples/l3fwd/l3fwd_neon.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h index 42d50d3c2..1eace4e03 100644 --- a/examples/l3fwd/l3fwd_neon.h +++ b/examples/l3fwd/l3fwd_neon.h @@ -192,13 +192,13 @@ send_packets_multi(struct lcore_conf *qconf, struct rte_mbuf **pkts_burst, * dp1: * */ - dp1 = vextq_u16(dp1, dp1, FWDSTEP - 1); + dp1 = vextq_u16(dp2, vdupq_n_u16(0), FWDSTEP - 1); } /* * dp2: */ - dp2 = vextq_u16(dp1, dp1, 1); + dp2 = vextq_u16(dp1, vdupq_n_u16(0), 1); dp2 = vsetq_lane_u16(vgetq_lane_u16(dp2, 2), dp2, 3); lp = port_groupx4(&pnum[j - FWDSTEP], lp, dp1, dp2); -- 2.14.1