From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0071.outbound.protection.outlook.com [104.47.37.71]) by dpdk.org (Postfix) with ESMTP id A92201B5F4 for ; Sun, 29 Oct 2017 09:24:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6uKJ0VPrJjikXQgksw0g5kCg8xQXT2Z4Jv0aWZ4R6/o=; b=Ub4So8asumPUhhySVhwXIz2HbqF/tobYU5lDFzAzZhAq82YgB/ciOYbW2Nbj2QSxdBNET3bIJaU33XojcNb2Y7s6oP6Q2LdheEYAuahOxMrZudqOk+kBkpK7y9WPHL8xnN+E9zBuE5o6KEzt1YFGJhOnba9dXW/8eearC/Wogkg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Guduri.Prathyusha@cavium.com; Received: from cavium.com (111.93.218.67) by CY1PR07MB1511.namprd07.prod.outlook.com (10.161.168.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Sun, 29 Oct 2017 08:24:45 +0000 Date: Sun, 29 Oct 2017 13:54:17 +0530 From: Guduri Prathyusha To: tomasz.kantecki@intel.com Cc: dev@dpdk.org, jianbo.liu@arm.com Message-ID: <20171029082416.GA31178@cavium.com> References: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0044.INDPRD01.PROD.OUTLOOK.COM (10.174.214.30) To CY1PR07MB1511.namprd07.prod.outlook.com (10.161.168.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 978d2ad1-036d-479c-e1b0-08d51ea6840a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603199); SRVR:CY1PR07MB1511; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1511; 3:P3ir8sCLpO5bzIfL8n+vMsQfy8gS3vKydSPaBcHAU04iNTm7oAfTXaXxD5PWsxflUEzEirkh5rx+rB6iypTMnKEsRahgBgce5MW7E49gCFs3OuS8g0D5SCak2ZFsBZTr+LMIpDHGrxCdNEM/5O5JV/HVLrp6cNP+8BHtCDjIzOvcQ0ZAbKjuPZRdjvj2ihahBSgk1FbJMTAwBNInzVu+QGD5VdGHp/k+hUQlHhbWlOLpUeys6EHemvNHib3YYpsw; 25:XXbur9plBLV7vxfu1zHjVTZ4W4IdSg6WZiLPVIUu5EfDqqp9iuQYAxfEk8b8QDdnbkYwPPTzYyHgfsMVeaUeMuGVxxbfd8gMOfbcQD8QZZfChsZvGveVu9BllyWg05G7sVFx/2NFcMKVMnHY45siHOvmRhUZjkz5BG78qBrsbtzCH4TOwP1DvQojnT5m7OMwUErmEokdzm8S7H0AyJ7c0tY/Kbpumbqz5Il/6qMCDhos5QCwMRGAHNiQZsyqBD+p3KdNx9eG1IjcvSAdm56rD/1+Ka/oPsb5wkD/AUHOsCiRgzkv5E+41j+W77cS1sN0UmzL94i9Iz3EPvQqWWk8iA==; 31:+4SDDWEJaC6O7QAezDUtUP3ORPrLH6eyDnoAOL+BXQpdSTb9Uep2eCXSwxn1TlwDQcjHWfjVms8tyrC4zZC1B80Kn87rNQ7yYvtyyu9XiY3oHBxJGJgtsdop1klbhg+m/KjcgbN1fWQ138bd4CYTaRXAufSWHTR++Kn54X9D/YZY89QHqLSLKZ1/5q1OXdWFK3OjsMLMQsWownuN8l5a12UtWhM5jNKbFobpzE1ggh8= X-MS-TrafficTypeDiagnostic: CY1PR07MB1511: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1511; 20:ZE312dLoxJ/fDRyU22xkyojxsChoeidgDcs9XyM5rREG/ySQKuYt5pPZ2TdaBfHQPUFzRYydjkRnPAzN/YXhINuPGLNlUb/pFXlGHfwFm5UyubzA+noXgFCGB1aNSJULzs1uzcYabV/+zd6s+9atkNnFTJo0o9gWnzL5oAAE2xIx9Agl+CN/VGnTOHmr9nB0HfVsuR4CJKPG9DrMdk8p3ObXBzef4lXE77bmhxn2dUd99MZuL/5BKKgh8s34ysAwhBwF3IFEZstdQ0q8d1SV4wACeE2JphJ6RRxwhwcTSX6xo0yjtUFEOPtKdk5zZ8RBF4v6V+nFDMAh3NTNi34LHpQkMWCRob4QAmGi4sU/fsQvTZvmuQ7muTtEbNnNwDebVzL7d4HZi4Lkfi8bsdjLJ2npPNZy6Ma9HaOkasvVoGaZcDVwDupNe4JAGZ8/jW4V9XJoEh3VXsm7/O6YVihmFnkYdSyrY3YN5C1MUD2nQm7oVEKlNpF5AP5cqf5+qAxGBJDeWNmeOi8daacpe/tKuVqxmdCDmjDbT+fwIqd7BaERAHS9ls0W9DLYdjkT+xT6UIk9pd82EX4h3O9hdjdk5bQDIMJLmjEbPT1oMnHBy3o=; 4:1iLWB4YGRc2YaPGa3NFvvY0fqm9OtqzlUoAOl+JNlF7OsuHhvT2Xxt0VKJxpIQfarOZTsg+P3X5RAkBD/nwz4I+vDM7zOW77qzliY2rM/VErDv5tjXsuhxcoKXXkRg9cPEbPVtjHsPLasQ+rC+DhADQEmQqOaQ7qBhkx/+S2EJemP9GEDuUSjZrSECCaF5GSLePeIVoW7QI8AVO7xf1DTSJYKOaHok9ZqwFNMOW32jmUbnn2zdWrJ6mb7nYk3DRkz8PQHlQ5mGYut8VEOMeE0UhUzR8NcEJrxAMRog66k+RqeGZCZVgp93/69oPJNskI X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231020)(100000703101)(100105400095)(93006095)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB1511; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB1511; X-Forefront-PRVS: 0475418F50 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(24454002)(189002)(199003)(3846002)(6116002)(105586002)(50466002)(8936002)(33656002)(53936002)(6506006)(36756003)(101416001)(81156014)(55016002)(81166006)(16586007)(2361001)(50986999)(69596002)(76176999)(2351001)(23726003)(54356999)(316002)(106356001)(8676002)(9686003)(58126008)(1076002)(2906002)(5660300001)(72206003)(4326008)(478600001)(21086003)(47776003)(7736002)(97736004)(66066001)(83506002)(305945005)(16526018)(6666003)(2950100002)(42882006)(6916009)(229853002)(68736007)(5009440100003)(6246003)(189998001)(25786009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB1511; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB1511; 23:vMDCW6sab25W0Do1NFA4fDwwxKpsR9cSowShCONRT?= =?us-ascii?Q?dX+OyVdrQmYLhjUgPEG72DTCj8bQEgWl1gkNVeSS5XRijd5rAaTxaXoUlVC7?= =?us-ascii?Q?aBuF9gi9LbCetPHOpXxzaPwxrjyN4SMcBkQaOZCXgs95qhCkxBmgVWi8Smbn?= =?us-ascii?Q?ZBsg0tjwdYXUxDO4JiOwFfYmIuCDcRAhH4I5txkjpfNidX8mm37d3iEXhCHF?= =?us-ascii?Q?NdWMMP9mMDPhbjdIy0ioo0Wt3wNtaMhEZCBB2VICu4hYKmG1dAUdur6A6mdc?= =?us-ascii?Q?+CIuVMoLlMBGtHRJEHR2TapqN0go7tte14qXxE44hLm06EuNYSNcOA/R5Yqn?= =?us-ascii?Q?tLnZLuAwBlLivpvZBhr5VYmhd2l5uiKPneOuZVOKn2+5kgR0/vl9tPxRi7MO?= =?us-ascii?Q?xG2c7pMLHNk12NANSKc8r8SM9m3cS7xhxYm4O1vgXrdM2WXaMUYRXEq8mC/j?= =?us-ascii?Q?lAbdqekx0F9aiDIgPsA8zm13/uP9QKCD+PZj62TW+X7Sebk3sWaJ3TSMdV5d?= =?us-ascii?Q?nyMx3QKxC2yUCwJE5kHGTerrWmWI5ApcmMC6cFEdaQjb13vo+e+6SGT0Hop1?= =?us-ascii?Q?dts05xRHPppFuGwp2dyof1lIzaVC+7RA/32zAJbMWmVeJtbpsrMbMqpSiOXo?= =?us-ascii?Q?nhp0gRr5CyU1BNkvBVVcEM23eJ092GUXbuwx2VXybtgcVGEycNn1hbeszK0m?= =?us-ascii?Q?fDWOYfzi1uAb7tQsv3ugdUYEYfAq9td9g7kvcWSDiClzzmuHdfGZSC7oDikG?= =?us-ascii?Q?gO6mlpCw9fiQbmWLwkF7Rsseqgx8XkKjRkCyEiMoQ90xoAw13gNCZUGAhffG?= =?us-ascii?Q?SG+RqOnwZqM9c1K364Pr6BxxHLkYLDmo1QMGaHxjhu0iwJY6WNkGk0UfCV39?= =?us-ascii?Q?VvGi/PR03WWgFrP+qpibJOBIioZ6EDBAsDTJIZIeVHtyIQ4yoT/y74ZFBMVn?= =?us-ascii?Q?pV+0FrC+FebQECZ6tKTdYH0fdc7lVKGyZXwUuxqUxGZ/mDs8dnf37eHIjBS3?= =?us-ascii?Q?uSYlAYHi5Vv4WYB4igl4wTzz4s4zJlpxeuSX9F+52o/HDaZqSlhqHlI/BR1z?= =?us-ascii?Q?5iawqAPJaexqG5M+NkVMzeKPX2XPP/Uz+WFxHkJsoWX+SuIWNeiM2nAkQNFY?= =?us-ascii?Q?y6nPD4ZzPQLd22CCy7+TvvjCIfx9LYFx1OY6a4sjDr751vWsfHsZc0E5NwTg?= =?us-ascii?Q?2vyJ11lbI9O4pZO/u/Ecoe8X6t279gDLgLK9veHMGfm5028ehqAvtJ1+K+QG?= =?us-ascii?Q?y4TkbYI2ZDkzvq8JM1O4RvGv5tmuOIBz10QJqrvZEMIqwjwNeoXd4hxNhGpn?= =?us-ascii?Q?KRoIMrlW7yVTHAO6dpScE4=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1511; 6:/tBPmjYlFxttIKEE2+/ykVWItKFMn3E9FgD3hxfznz+oEi9/4vxH06JmVgSQqJFxgeX82rCi37NbDlFZnxf4k5Hv+9sZsWG/3/fgEbJAhDXbSSoOJpUgjSvW+TGCRa0Xy0tb1FD+CJRDcmg0FTpwx/8lt8rKIaLrgg4/rTWDis4Bu38RvSg0X2J4aW0DD/dYf1UAwYeuSUiYJfViW8sScQiXODO4uDHePCfaiwyELBK3TcVBdDFH+4Rvc0X3qlPp5PT1eytgRYBsvKZlF0/lyurhtxJlXke3h0n95LC7DpdyP0VR2znYo6zB8/I1hdt83v9H49wlBZe3S+7MHgalo4rIB1az4ce/5n7heQb0VWA=; 5:7dM+ufYrMhC8qp2tervzRJn57RdBgZkxv3IEfVAuvLfSJzP5T46fISYII5qqFfRauXMHFamR+8/41uG///3tiRge5I6+9gn6i+vguYb3jt26zIcNywmdSrqElOcdt5a2FA+I7Hl+6jN66XbNgm1kYAeoi7234nMz+PsUSp9HCCQ=; 24:3cM6WQCZ/7wfTQhCAye2AaaJfcx2s4D764kSIzbibtZU11vKtTTj9mC2k1zIKZpLhBpi/kbLc0af8YD12wuW4XGSwQY+v8yKcLhoyDC54po=; 7:J0VHTBaJ3ZKvM/lfDGUmoCtyXOKM8r+nnMpQaoRFUsX+NMUju96Ujhk7CDexTtJB8NfG1X3pgRpDyfInxrG2MxhEPJSlJxTbu5D7slsDLFtqnhMuEmBL/6BNIrUgLYB0ycO1x73+jmXE3Mmijgmvu3VbTt0QlVTWTogWZVdWmADb40yzSuspPQcpjGZ8yBx4wak7zkTnYJ1dyR5B6YqUKJ+xis5FddyHthdrVSlgTHi9y7lIRwuHzyG7flgC6EWO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2017 08:24:45.7284 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 978d2ad1-036d-479c-e1b0-08d51ea6840a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB1511 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix NEON instructions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 08:24:49 -0000 + jianbo.liu@arm.com On Sun, Oct 29, 2017 at 01:18:07PM +0530, Guduri Prathyusha wrote: > To group consecutive packets with same destination port in bursts of 4 > neon intrinsic data types dp1 and dp2 are calculated such that if > dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: and > dp2 should contain: in the first iteration. dp1 should > be and dp2 should be in the next iteration. dp2 in > the last iteration should be . > > Whereas the existing code incorrectly calculates dp1 as from > second iteration and thus incorrect calculation of dp2 as > in the last iteration. > > This patch fixes the incorrect ARM NEON instructions on dp1 and dp2. > > Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") > > Signed-off-by: Guduri Prathyusha > --- > examples/l3fwd/l3fwd_neon.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h > index 42d50d3c2..1eace4e03 100644 > --- a/examples/l3fwd/l3fwd_neon.h > +++ b/examples/l3fwd/l3fwd_neon.h > @@ -192,13 +192,13 @@ send_packets_multi(struct lcore_conf *qconf, struct rte_mbuf **pkts_burst, > * dp1: > * > */ > - dp1 = vextq_u16(dp1, dp1, FWDSTEP - 1); > + dp1 = vextq_u16(dp2, vdupq_n_u16(0), FWDSTEP - 1); > } > > /* > * dp2: > */ > - dp2 = vextq_u16(dp1, dp1, 1); > + dp2 = vextq_u16(dp1, vdupq_n_u16(0), 1); > dp2 = vsetq_lane_u16(vgetq_lane_u16(dp2, 2), dp2, 3); > lp = port_groupx4(&pnum[j - FWDSTEP], lp, dp1, dp2); > > -- > 2.14.1 >