From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0063.outbound.protection.outlook.com [104.47.2.63]) by dpdk.org (Postfix) with ESMTP id 66504137C for ; Mon, 30 Oct 2017 07:00:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Gym9MEr32JzznrPtya/PcjoODvMo4zMgFnAEvGHquQM=; b=Epu8MRc0pY7oJPhiCfojCwjQSXxaN9fEyJc9J7gXq1j26fjPEoSka0HaapccAzthw9+x8VNpR4MqokST0+lO47o19Ome0J95g2+60653LtSiwBgIRQfOiFLTLv+bZQi6bPnjuaCGRN3I/Knjd7LU1RLhilPguBEv8mHoDV8F8wg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jianbo.Liu@arm.com; Received: from arm.com (113.29.88.7) by HE1PR0801MB1354.eurprd08.prod.outlook.com (2603:10a6:3:3a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Mon, 30 Oct 2017 06:00:37 +0000 Date: Mon, 30 Oct 2017 13:59:27 +0800 From: Jianbo Liu To: Guduri Prathyusha Cc: tomasz.kantecki@intel.com, jianbo.liu@linaro.org, guduriprathyusha@gmail.com, dev@dpdk.org Message-ID: <20171030055926.GA26823@arm.com> References: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [113.29.88.7] X-ClientProxiedBy: SG2PR01CA0103.apcprd01.prod.exchangelabs.com (2603:1096:3:15::29) To HE1PR0801MB1354.eurprd08.prod.outlook.com (2603:10a6:3:3a::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e66a26b-f53a-45ea-5a14-08d51f5b8c22 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199); SRVR:HE1PR0801MB1354; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1354; 3:CkWtsppWlhgOyAIPNz70hNTEwLjznc25p5vWnMEUZjPPJWIv6rmPb2f+kg0X8bJGzhplelRciAjCDhgyVFkTDbfHKoZPS9N7XDT7pjGCCGr6ONMES/UMMqkh/ygkNfG7+PJ3kKUvAaie85aQt26aUjkVEJOzoRsaBhv0u5YCfsnBCnSc/BTNMwy5G5j0aTfyknQvS1hQq3blLQsNeCQ9wpkoXO8cjncTFQG5Xs1ilakxxLw+0P7jruJuqj9CJoQf; 25:xTtSwks8j39XsZDrTHo2hxJMhcxsnbPM9TBl6ZrEAx8iWV9+U4qxOW3EPqbqT4BrGZG4Msvv6WtVjh107vXIJnxGWEgiaZZzVrBmsAnTViGdqaj4tyIX2aB3quaKR8QLlVhu6bkhidnZOVlvoFMvxqoeh3YXUC1RBMp4YMUQEMtdNII3Kq83rA43zIHo8SiDXK6q9uggcgaNes8SfvTwCxvXtle7kBhxCPPXaY/WCc91sbSWyoIV7JwjvkmmD53wRpnTLetMFWwZucgGXbxCH9XfHsw6yrEWsFUtfO0h573nl96d+whdFuiT7xyP8Nqe1ajn2uy16vGoQhzSUF5yvg==; 31:2E1tmHy9qTM3Q/rA0qlOmF2A+UJX62LeECMGZ7GNkcBVIJ7m6tw7BTMd/jt9ruJCtadLyo08Z/4rU69Abz+rR9NWOEden9RalHbmcIqpL1o2VQ76y9JDD9ky/PGAZJchKUjRVuw8rXzQDSoN7+Q7WFHegkB2lZrJ05V7h0oaCQvlXFFNONd4O1JqqoZwKZYw2q9H8Fi4NI/Y/mZUX0HjWC7KAAaKERcXe6CeyqxQ9v8= X-MS-TrafficTypeDiagnostic: HE1PR0801MB1354: Content-Transfer-Encoding: quoted-printable X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1354; 20:VFLE12U865L9q30rAZbsm4sBY7fgGjEZ9pEf6nyiFckihD9uCJHbo8R5vGoh6sigGzlRE0QcjXnrhpSRX3DraufZlCpTwbKj3lJ9cKQzL2g4h1Jw68Hx0L6uKA/y7B1BXSGTrh7QykwjOwlzEwJ+xkUSnm70ZtfGELXFgNoAT8Egxn9IhuA0L4QIUXZpnP+WJPY00S19+t6H+eLB3g/1WA871BUb1E3ZVGkpo/Hd/EP9i1oHGyWU0v9zDdOIwYfWtwB371kI+ERGO99K7tqOSH/QFk7QO4leIOx5yZUp2AzMa0QqWNac6OdLXxSYpxumjrjXMZtnbjuckkA8gU79tn3JblhvfEFP4woEYER1Y5NzEevOvxreNAJkQneaAmmu5Ul3mIVcdXbreZowfNFsdYsRaZiq5e1ixGXu6L/1VvwWXmV8Om2RPRn74jiXj4xb492LOEXlCujPfUZsFHUlGuSqBbStH4Y9vbPtUOSZOBYX3uF+id4Df7J0XKZh4i4S; 4:St5BjMStNU/Vn9j+NDec5jwHFdQYtErhUyGnxGiqmIOKtoS2dtUaMW7l3BAHz/X42lPa72Y7DjMWVB9A/NeVb0XFrBBwz/oBWHFI7uFgyqJ7e9tQflq4XKe68UHg+qJGt3VlDeoxZa2D2q3GZ9xWcuCdzKC8IqH9qCFkDoS0BDYbzoeBd/bXz2b9FHQ+RnUcRnAGgpmKKmXjriFoILwFnBMMHdfZcvrwSJvtM6l35F3Q3pn5kI1DGDlIiFIDBuQdNgyhyzLteWw53DjK39Y9BQ== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231020)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0801MB1354; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0801MB1354; X-Forefront-PRVS: 0476D4AB88 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(24454002)(40434004)(199003)(189998001)(97736004)(316002)(58126008)(66066001)(7736002)(36756003)(478600001)(72206003)(25786009)(83506002)(86362001)(6246003)(4326008)(53936002)(39060400002)(5890100001)(16526018)(229853002)(23676002)(106356001)(5660300001)(1076002)(55016002)(47776003)(6116002)(3846002)(105586002)(68736007)(2906002)(101416001)(81166006)(81156014)(8746002)(8936002)(50466002)(8676002)(21086003)(305945005)(76176999)(2950100002)(6666003)(50986999)(54356999)(6916009)(33656002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1354; H:arm.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4MDFNQjEzNTQ7MjM6WjIrbjFQaVN1b1dlTEsyOUlSNHhRbGpL?= =?utf-8?B?QTE0RWgxODdCMVdFakUwTWUzUnY1QmdrYXhhMXk2S0dYNjg4Sk9tS291QUFa?= =?utf-8?B?RkJob2RVdWtXbUlNaUJYZzFyVFRiTnVGeXk3dUdMb3pJT2ZkaU9HUVY0T2Fv?= =?utf-8?B?R2N5RFRmVGdsRmJya1JYZUwvMWVaam1BWUEwNUFKUVRFSmMrYVp2R0k4eDBo?= =?utf-8?B?Qjl2VG1IR2h6bnRiaTZDRVllVmJOZFR1M3M1Z1R5aytEdXQrZncvT0c4UzJ6?= =?utf-8?B?QVV6UFFnV00yaHZSeE82N0lqWUo2V2t0WkZyN2Z6dHFIc3RvbTVKQ3ZMWHNB?= =?utf-8?B?dHBGTkF1OExjWDM1ZUxwRTlDeFAwT3o0a255SWJlc2NaOFlaVFhEU283cGUw?= =?utf-8?B?OXFiL2ZmVHQvUUw1ZVR0cm9EMXF5SnJZeWd2SmZmL1hWeGZXLytZQVhKRGFZ?= =?utf-8?B?eHJleW5ONmtONUFtWVUyQ09rTGF4bDRoTElNVVNQekM3Yy9lWHprVHFsd1N1?= =?utf-8?B?aVJ2MEY0emxGMlB0OVlMUDFEbmJPNVhXTkdSZlBjQlkxQURoSmRvSEI5R3Vt?= =?utf-8?B?cGFCaUtONCtJQjhvUG5FUHRKTWpvK3RVR3FVTzJXQmdCU21UL3MzR1Bpdmcr?= =?utf-8?B?SnloZlRUOVk5T0dzK3dFL1N2dHR1Yk9YaVFoRVVkenMzZmdVb1FkU2MvN0pa?= =?utf-8?B?R3JuYjZMVVVyeDNTU3ZPbzVPL2M3TCs5YlVTRkFjazlBZjNGYmpKbS9GQmZ3?= =?utf-8?B?cUV0S25VS29ZVUxMYnFhZzdPMUFDUEZGUmJnckNCMVl3M0szdFM2ZFZ2LzJs?= =?utf-8?B?ZThyckZQZWs1RmZ4Q0ZyM0lrVWtKcE0zODk5WjVKTjFXbUxHRGNHVVBiTWFl?= =?utf-8?B?czdMd0ZPWkJwSjI5N1VQL2pUZjJRcXA0TkFhSE85Rldoc0pNNDZhbmppeFQ4?= =?utf-8?B?OC91SkRCam8vYTdQUUZnYUk3eE1WbzFEdktxYXlEQ0NFTDdJdGp2bHd3ejEr?= =?utf-8?B?VGpwS2JLS2J1bVVDVnc3dnFWWllIVDZMVjE4bm9SbXdxMng4d0gzQ3RGQ1da?= =?utf-8?B?eWZydFBqYjJ2b0o1dnFVa3ZhOXYvQ1RHTnh6UHR4MTVlVlBoOFBZSUcxRGVy?= =?utf-8?B?WTZZNXE0NnZIdlZ2T1B4SFY3eE43UmpnMnFGajRHcUx3VjN6TkZ4TWJJUkNR?= =?utf-8?B?UWt5VFdWNnFlVXNVOExPU20xVkNwVEVlU2l0RHN4Q05mWWY3OFVSeHBBNHpL?= =?utf-8?B?WXg0bE1LSkpzdVk3cjhaZ0p0K1krMUdNdkl0cXFIdUMvV2tROTZlQTNMQ2RX?= =?utf-8?B?cE5aeXp4L0l1SEM5L1BRS2E4TE44dW9uNTRNL2FuSkpnZFpCbXMyNXN5aFlU?= =?utf-8?B?enp2bWpWbGVGU0FZbVdGL3lsU0NUSmdGYlpuTGJuOHJmeEJVa0g4aWVadTNu?= =?utf-8?B?enYxcUZGK1NjUTBHWjV5SzNLckh1Njh2R043dTdsV2sxZWlNeDRGTFBrZEJF?= =?utf-8?B?N0VlSGphRGJKM2pyVU9DMmdVUnIxY1huL1UzVjF3UWpEMXZaampXZDB5TjBJ?= =?utf-8?B?YlU3S1hKeXdSaEJYUlcyTndJQlNsMzRkcnpmcXBhVXM0ZWNlQzc0K0FMZysv?= =?utf-8?B?bTI1NG1ZQ3Z3UDZUL2swTjIrdUNMblNRcWpxZGY5MnZESnFtUXc4TFJ4bmxq?= =?utf-8?Q?Ap7EbyS9jChaJOzcLZoYUYpeeYVaABet5D8vFJWor?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1354; 6:r0OuJkF5FbFGSuE/v3o7HGa88Gfg4KRHol/8PwgoZJlG/5SOWWwcQ5VaY5ttCCK7LolOKAqw7Yv/Ec35ymcO0QXCZmzqRa4kts2APVV4QwJnmYhrz6h6CmC/I6oN+vWkYGD3YQ0sMXHmgUfBpw7vTKbJWldoFVR2B82CoVBGqsNVRrV7i5d5gNooFUb7y9vse3qPZhb4kHxq0I8Q3J9J3WoOFezila8pbT25lLBkXMXPjqqqa3kIOt9kQuuhZrLwedy/FtIF2Yk2l2hogLSHytW+bve8u3Y8RKiNzhPgQpz2Xz32RCPnPR0omb6QGuOaUQvDlX+iPxlw1dzFJONEiMAMsNobQvXN5+yH4qVzoEU=; 5:r9RrCSoZWo9bk/mQaihsqEUREGaEKZw2fZK6JpE/Kx6jLBTm+2rQ5b1iICa/do+5Fej6vMs+Gs+iR5nwOQy1PovFq6nBMtMC5oj/UOapLAXmJB1ScOv160QLyrkJ7JU5szK1rpTi0LRpm73q9VDg43LGIMKHicjj0FWNQ3+MrWU=; 24:ifVzF2k6sKQ6AEPQV7xON7XZvzsY2Dn90g4+09ebTpv1JeoiKjW++wK7YU6uI1flMKysGIbOmHdyqr+2EOybjWj/9iYY+smwB0KSY3Mv1gM=; 7:EVg4nOkBJq96GcZIzWBKBhK4YTA8o9sWANhm6Czi7Ydjod2+JDA8WtJje9sNzo674628Q8P8eAu+JJAm2M/cg6FA8XmJmDPParWJe1b/S71fe9N9hvGxf1wdL895k9hGM9xWm+oQKD+v6XX/oDqfLrbnWwjCX23Onu/r3Gy0SY5Ao6U28jzxWjkGU85ycBrvpEJ5UDWlw2C2lNTqwACyW6PROMWtPj7D+wNkRjMQDCwGjU+rAqlWrt0PFyJVTvek SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2017 06:00:37.6807 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e66a26b-f53a-45ea-5a14-08d51f5b8c22 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1354 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix NEON instructions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 06:00:42 -0000 The 10/29/2017 13:18, Guduri Prathyusha wrote: > To group consecutive packets with same destination port in bursts of 4 > neon intrinsic data types dp1 and dp2 are calculated such that if > dst_port[]=3D{a,b,c,d,e,f,g,h,i...} dp1 should contain: and > dp2 should contain: in the first iteration. dp1 should > be and dp2 should be in the next iteration. dp2 in > the last iteration should be . > > Whereas the existing code incorrectly calculates dp1 as from > second iteration and thus incorrect calculation of dp2 as > in the last iteration. > > This patch fixes the incorrect ARM NEON instructions on dp1 and dp2. > > Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") > > Signed-off-by: Guduri Prathyusha > --- > examples/l3fwd/l3fwd_neon.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h > index 42d50d3c2..1eace4e03 100644 > --- a/examples/l3fwd/l3fwd_neon.h > +++ b/examples/l3fwd/l3fwd_neon.h > @@ -192,13 +192,13 @@ send_packets_multi(struct lcore_conf *qconf, struct= rte_mbuf **pkts_burst, > * dp1: > * > */ > - dp1 =3D vextq_u16(dp1, dp1, FWDSTEP - 1); > + dp1 =3D vextq_u16(dp2, vdupq_n_u16(0), FWDSTEP - 1)= ; Can you write it as "dp1 =3D vextq_u16(dp2, dp1, FWDSTEP - 1)"? It's my typ= o. > } > > /* > * dp2: > */ > - dp2 =3D vextq_u16(dp1, dp1, 1); > + dp2 =3D vextq_u16(dp1, vdupq_n_u16(0), 1); Same as above. > dp2 =3D vsetq_lane_u16(vgetq_lane_u16(dp2, 2), dp2, 3); > lp =3D port_groupx4(&pnum[j - FWDSTEP], lp, dp1, dp2); > > -- > 2.14.1 > -- IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.