From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0078.outbound.protection.outlook.com [104.47.1.78]) by dpdk.org (Postfix) with ESMTP id 59F002BEF for ; Mon, 30 Oct 2017 07:28:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qjbFgMeZO92gwoWDZtN6GwW36y3rtTWoJLo/3w8Rs5c=; b=LuPzKW3fikK7y7tajMIldsSYDqlkHnEVWgkWNkFewAccFB7Hi7wlb+AT3cDTxqZMlIbgUCDg3HzcoI/4eGOTKjZ7mtmYJgxxcXClTJUPDh/675r4j/uCzlmde3EP0MO9tidp0ObYUxwDtfzwaGJTeFiE24Qp7OCRtOTWJDKU0jc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jianbo.Liu@arm.com; Received: from arm.com (113.29.88.7) by HE1PR0801MB1353.eurprd08.prod.outlook.com (2603:10a6:3:3a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Mon, 30 Oct 2017 06:28:16 +0000 Date: Mon, 30 Oct 2017 14:27:09 +0800 From: Jianbo Liu To: Guduri Prathyusha Cc: tomasz.kantecki@intel.com, jianbo.liu@linaro.org, guduriprathyusha@gmail.com, dev@dpdk.org Message-ID: <20171030062623.GA26958@arm.com> References: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171029074807.30785-1-gprathyusha@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [113.29.88.7] X-ClientProxiedBy: KL1PR0601CA0022.apcprd06.prod.outlook.com (2603:1096:802:1::32) To HE1PR0801MB1353.eurprd08.prod.outlook.com (2603:10a6:3:3a::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02a4c114-539e-43b6-1332-08d51f5f6a1d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199); SRVR:HE1PR0801MB1353; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1353; 3:dlhJgBjd4BO2Gx5yVPqRvYWhkX04bfUVTWQPWf+h1VQMn1eN6g/RswyOgbbhDCEYQ0DW49IYKVnig1LVuqnv5jRVIxGznfonfxYYaVtElZRS9xPyVLoCa8QRJrowpWLSdAgVcpPiBfQ5oaJAkIBKwF0yI1W+26DgSA2QPQdFr+Z6ZTBIjOtEmbB5uLNKZFRUNp5r/+tCa0zVNvxouYuJ/oArC/jIdxW1GmxvU8plgecSGDaPLK1I3q+JSDkig/Pp; 25:olrZDjfp+nk3RR8vL+x+5CslXZqTsIyIqAE3O4onWU5tnIMfMQFD+iA3V2yWyfFbj2Y/Hx2gu7pcaB+ruEkPcuxldM1OPbWmQy9VAhfVbpO7OLFVTMGnNFvxksy1uqTImH5stzjJ28YJexUX7GdZKz32zpGNZG6s51uD8FBiIWxZtAy+dPQBYRUYj8S7Gq51H9QTBiv2/T07sdcxP5ldi9hukR+m124qQuwdfCBmOK2jMDnONBK9w+va9GbWHpit3fVLvE5ttVhac41VVJSh+p9l3j93G9/eId32mNtj2Gshw/2HtbOtJujL/WbnIpjP/YzHnHOHHuOdQx0jr5TTpQ==; 31:DpqFHlQRvXOtC26lnCMD/2RICZz7FJMwGFzUJs90czY8qnf5aeF9D+fZXjWyXbyRgMtAclMGnvtnBCHl09hR8ljfy/Ghw7LGy9bm9vahgvEW98C7aLG28pC9UrNLNzMorU4Bp4U++uc38p4y+9Q8OyYnxbkwqUqL9KWargBm8XTXTQNXSQqFzDJ8Q0Dl/G0NgudsJ13h0P44tjyRceNGXqBKxSG62ecZ7Bfn3p+QDgQ= X-MS-TrafficTypeDiagnostic: HE1PR0801MB1353: Content-Transfer-Encoding: quoted-printable X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1353; 20:ULqegy8as1MLINrB3lBCuiwE80uJp/czVcvdsYb0VlQluS6+36ElrHtiqXS8e3c+42siCNAcF+yTvZXSVi66C0GFu13qvtxMZAZwokZdussK4ko9QtnhToEjhXM1CXYCWVw7mUYF5/1xjZrVBPJ0zSVnWImGr6lGjVAZlJk2A1YAdv4kUIBWcyI3gukn2qG8mKOMoAUFCM7zShLPC/pUA2i71ZK7ZmcOX2eM64B7CnGQWB6ZnVMZgiIMICozL7/fsfwH6ItdsuPq5Lac+huMXBmwuTwiXyjBy6OWYZNYE1oBhUapiaGMvxiv54laHUmJUxdejPdNsWeWkHjSD1F2gXeQl/HvlvfqRuVXiDSuhiu3ad7ssngjZFRj0N1GMw6MS8hjl1+iQVIRGOXuYjINJN8+ZeL2njGtAJ8FHozQ8Ey74edmMIV2PDczdoPne1Y9c9yNH+ZQPOGodeGAAYeWeZ4gwSDAU5vUrt35Omveluyr73x3Q4aEgLev0bU6l9H9; 4:BpXR0qiqHKYTfKMg6G5hMnTKQBjQvaRfj06RXEAzxo9iE6X0LZPmTUUx4TDHTZomNJ7caromCxMM6O1qe9eaqesprFIrLh+rnLb8hFD9gu9JBxAHlMe97La3DgNBQO2STATSz8pt2KyYQFOwAxsrFhhXhApuUXfBHOgpqaCgV8L/yEKHI5a0rap0I3dvUGar+1nqjNsF627PJ/WPCkYwCucwdEQptUTk3p4SCFssIYiOayoXlXJdrRB878jVppktRfX/BFPL+8m5qWRdtJaqsw== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231020)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0801MB1353; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0801MB1353; X-Forefront-PRVS: 0476D4AB88 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(40434004)(189002)(199003)(24454002)(97736004)(76176999)(54356999)(50986999)(229853002)(23676002)(66066001)(4326008)(39060400002)(6246003)(47776003)(36756003)(101416001)(55016002)(53936002)(478600001)(68736007)(7736002)(305945005)(33656002)(72206003)(106356001)(5890100001)(21086003)(105586002)(2906002)(50466002)(81166006)(81156014)(86362001)(3846002)(316002)(25786009)(8676002)(8936002)(83506002)(58126008)(2950100002)(6666003)(189998001)(16526018)(1076002)(6116002)(5660300001)(8746002)(6916009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1353; H:arm.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4MDFNQjEzNTM7MjM6cXdJREtOS0F1eTJmeW8xNVdKbVZTMGlI?= =?utf-8?B?TUhOaVpsMmd2WXdRdkh2NjRIa3AxdWZ6VzFuKzVjSGR1T3NmMWdoOGpJb281?= =?utf-8?B?Nmh3R3oybE1MRTJNdTR2bjJMOWV6TmNEL3VpQm9OSDRqRWwvZ1EwUmFUN2dF?= =?utf-8?B?RzdXT0NIdEdOamczdGVUVjBSVWw0VHc5ay9UakJGZVZqallMWm9qVzF4QWJF?= =?utf-8?B?b09xRS93ajIzZkRrNFpaRGN4Vld6NDE4QkV5MEtrMkJTemNWbHVPNkRUdzF4?= =?utf-8?B?L1QxN2s3NjJ4REZRemxXZFhzcFFPN0tyb0dlS081Y2JPQ3BNcVgvT0FsdWc0?= =?utf-8?B?UCtweU5sTTZxaVFqanA4aVVpd1ZOTkxLVThjRGxKMnc0V05LRTRoZGhpVkVK?= =?utf-8?B?d2N1RjdBTXZVRW00YVRxbkI5bVk3WWFiWnlEYW80K2JEQkU0Uk1xSTZadTVY?= =?utf-8?B?NUtlNDlxbXJoSXM5emExYzZIVERJVFRQbUNxSGFhbXVpQnRlTDVmcHREQ3NJ?= =?utf-8?B?bkFncUdKZTUvemE3aTlmSlNRa3hZcVczbk9MckJvLzBKejZ0eXZxYjJWRklq?= =?utf-8?B?UUpNdkZHSjd2ek02V1lTZVdhTHVEUXIrN05sTXM1cmt5dWw0c1VRd0RiK01R?= =?utf-8?B?bW9KejV1VjJCMlYwOWRGQ2FabU1MenhvcVNsZmk3OHFoTDllSGpQTnRwcmxD?= =?utf-8?B?dFoycmtrNk9yMWhLWHl2am1vNm1CbmNtcGEvbkQ2UWtoYTA2MlhqMDZmMUpu?= =?utf-8?B?dUlZaVYwZkUyOXh1T1RtVU9zVVJ3MGNDb2t2M0VoR0d5eGRJQ29Ca2xxNXdK?= =?utf-8?B?c08vbllIT1Y1Rml5WHVNd2hwMUR3MXBseEJXWHNVckdXM2Zkci9rSS9XTkE1?= =?utf-8?B?MzJHcGdwLzlGSmMzRTAvd0lvdWsyYUU5STA5TlhUMExxUndoTXJWa05VeDlX?= =?utf-8?B?MzVRR2N4OXRWOW1Dd0lkczVuQkVTMDAyYU4wSFFLQkt2TGxyRnIvS1MwR0w3?= =?utf-8?B?N3k0cGp0UlVRZVJKS3VVQnRaQUk5RXZPTXYxYXc1cGJLS25PdnRNMVFZZi9R?= =?utf-8?B?Tk1QVTBLMmhJN2dYRFdtSFRRbS8yK3gwNE9ZNWdKc3hiRWgzcGRGaWlwMHZL?= =?utf-8?B?Vit6dE0rV2VEV2x0cVUvVzBZM3EyQWtHTnZmUlB6NDJYUG1RcjNJU0FUMFVh?= =?utf-8?B?ajJ5WGkvTjY4TGpack5xRC8wV2VpZlprb3JZQnU2dFBmSVA2SGU3MnN2RzNR?= =?utf-8?B?U1NHakx3d2luRTNMZ3kzMjBTcm54OWRka3ZyM1pxOHByKzIrdjRST1NibFVs?= =?utf-8?B?dndFOTFmajA5SFNkazZIejdSUlBEOE5ZVGw3Q0ZGOU5XNG9IaXZrWk1Zb3FN?= =?utf-8?B?MzIrT280Z0Fzd3FJWEdSVk1HQzdYRlJmMDdyb1BRUmdGZk5NTlgxOEdWNFZl?= =?utf-8?B?alhWZExKdHVYS0o2dDVIa0E3dlk4SmhVd1p6RUgwVGc0VXlVSEcwdkhsaWtZ?= =?utf-8?B?dnFMY3htZkpNdmFKRDg3Vld3QVhpT0QvN1diemd6emJwc21rZUVMVENxd3R1?= =?utf-8?B?cFlxUXgyaW0wZ1pPdVpCUkR3TDVLd01EV29BSnhvYTl1L1FXRmwzQUN4Y3Ni?= =?utf-8?B?V0NGMlpSanZhTDhCcGhSaXdHc01INVJlbFBkK0NXclVrQzJEUlk4bkNyckN4?= =?utf-8?B?eHdRSCs0UVNIZUtwN2cvNlJQakdqcHBGbWRtelRKRVhXbmZYOE0wakJBRzIr?= =?utf-8?B?QWZUeU4yeXZNNm1kWjh3akxnPT0=?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1353; 6:QgMhbrQwpC0aoP6u77U0SXCgIkGXLOro0vloDVVREoEK8js4ZKochwzOv58J3eeybD02ut4DEAxWwiXH2H6mhVXPag483E7mJAVL4S+exWMNwGmmMvZpGIU/izyFuPX9alIVflONgjh8S/Y2TRYEIovG57PIau2aive85FfyjNflKbtpjppl5egqrl6K1u5NqAUFESZEyJEVfxnrJswjTdUS+5ZJC+o+yTccuaWTH8lyu5smrCHfG+g2iBYHciuL9U7QnHboDkuDEN9vYdx9T0X0oCAUmyvCHgCQlIF7nfldYvq3ROiPDF4SYbX+GkyKWPaVoudZcEnfZqgCwjYHwFQe5fabvjvuhpg4XcxpJ2g=; 5:mgIqvBh6Ix/LweUShOKHyVpOEfE6PTILr9x1nPxvcX5VgnIoTuoyDZ8GmVj/n0rJPmJFsnABEIWi7rWPUAmA/OPYFG2DIt8M5mJUHprQ+8C0q/2Jb9s97AZoni0xkT/eLNp7bIVDsKPVwtrgmuGqqu+sVGQHCH4qE1dJmIgGKEA=; 24:UKrj18JLbwrmMz54Txtg0/RqMV28QLqY5abThog2noV4Jqwz7EX/zmEI/n0oPPeSV+2fxyy5z4OpggQmiYA4EzR01iLTTB78X/Qy2xA4nq4=; 7:/j+z1GSQ1kCv9oB2EjpLTEqFWuLMBDE/tBLlqZXAbWg5qldVVPqXL5jZHwfcuklqeYC8a5wM4KDEFBSbAQS9Wp1ftRJ472MU2Ar4y2WCBmBmVGChFAvuBPlWNP22pkSmjm5EF1MIcQgfxwDiQ8AO5TaG7OFnxIjv180iP7FSDqP41fXmqTmB/Pa15Mm32vAjZB1ARTXxgVCRupEyAJxMzAEgRc5inqa+5XvajrsZc2fSIO1g+nzxF/NZBWvFic8A SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2017 06:28:16.4186 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02a4c114-539e-43b6-1332-08d51f5f6a1d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1353 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix NEON instructions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 06:28:23 -0000 The 10/29/2017 13:18, Guduri Prathyusha wrote: > To group consecutive packets with same destination port in bursts of 4 > neon intrinsic data types dp1 and dp2 are calculated such that if > dst_port[]=3D{a,b,c,d,e,f,g,h,i...} dp1 should contain: and > dp2 should contain: in the first iteration. dp1 should > be and dp2 should be in the next iteration. dp2 in > the last iteration should be . > > Whereas the existing code incorrectly calculates dp1 as from > second iteration and thus incorrect calculation of dp2 as > in the last iteration. > > This patch fixes the incorrect ARM NEON instructions on dp1 and dp2. > > Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") > > Signed-off-by: Guduri Prathyusha > --- > examples/l3fwd/l3fwd_neon.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h > index 42d50d3c2..1eace4e03 100644 > --- a/examples/l3fwd/l3fwd_neon.h > +++ b/examples/l3fwd/l3fwd_neon.h > @@ -192,13 +192,13 @@ send_packets_multi(struct lcore_conf *qconf, struct= rte_mbuf **pkts_burst, > * dp1: > * > */ > - dp1 =3D vextq_u16(dp1, dp1, FWDSTEP - 1); > + dp1 =3D vextq_u16(dp2, vdupq_n_u16(0), FWDSTEP - 1)= ; > } > > /* > * dp2: > */ > - dp2 =3D vextq_u16(dp1, dp1, 1); > + dp2 =3D vextq_u16(dp1, vdupq_n_u16(0), 1); Sorry, I don't think you need to change this line. Please ignore my comment about it in the last email. > dp2 =3D vsetq_lane_u16(vgetq_lane_u16(dp2, 2), dp2, 3); > lp =3D port_groupx4(&pnum[j - FWDSTEP], lp, dp1, dp2); > > -- > 2.14.1 > -- IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.