From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yliu@fridaylinux.org>
Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com
[66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 1E5CA1B2E9;
Wed, 1 Nov 2017 16:49:16 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailnew.nyi.internal (Postfix) with ESMTP id BFA8211C8;
Wed, 1 Nov 2017 11:49:15 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
by compute1.internal (MEProxy); Wed, 01 Nov 2017 11:49:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org;
h=cc:content-type:date:from:in-reply-to:message-id:mime-version
:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=
fm1; bh=Xb6xH4aypIYrUo80IBamu2rPLG63VLqzXy8bEhFFV2M=; b=Ad0PrAFZ
5ajrVRZ/y/wvECA8gikCVv28dV0ZyDgI7tCyVmzY+RQmsAV9ANKETdRQYHd7VmVQ
6UL2715CKoilDkHpntn9r6ikAvPChCn6E6y16cCm+XoQsZRGJiVsUOXHXEY+UyEm
C8QYUDFTAmejy0Ot3N2A5eCm8WY0UMNb5MMxhX7cku0dCejhyujWVZryfKI1/Lbn
DreQ7dhQXOUtsM3pxklcQW7X/FAQq/Iab70VJd9xvlkcGJam6H8HyDWDxShyscIN
Yp3RAfJdBvON6sbpqaixGMdYXeDlv/5jRXtdjwtOh/ClA8vFs9eg1YmlOc1mz9bs
vlR679Pi6Kvudg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=fm1; bh=Xb6xH4aypIYrUo80IBamu2rPLG63V
LqzXy8bEhFFV2M=; b=YDpPgZdaDDXReL8OkZVAYq3XNyGGusDfu78XdVNPcanzZ
rpuyfCN5qOP3YQCI7YGBONqhMPJ4w6cZoWaDFUpxbV37zeEOMgqoKZ+R86wtToQ4
MA0NaPK/3oMqN1td2mOKkhsUE9wEdy/Vl5xRZP8t7/JTC/xD5JaqIBGmCCJag146
b7BGDgYqFBi8qLEHhSs2A4BYsNdC1B4pgjA+Bk5ZnuE21R30ZH1rP87+6GRuvZAR
ixw6JC+2g2/Lxqj9yyz2T6SvaJF/cHYBYbl0M5g9zHxqGtyLHGDE//faxhkwPh3E
yJVq3eGGxCiQNCp37kx3fP0IfS4sNmTnFrfFhBDEg==
X-ME-Sender: <xms:--z5Wb411Erry2OqOBoLsPtjzIePuuym_EDnnbXPdyOuyv6cGmvfmw>
Received: from yliu-home (unknown [124.79.168.36])
by mail.messagingengine.com (Postfix) with ESMTPA id 97C43244C7;
Wed, 1 Nov 2017 11:49:14 -0400 (EDT)
Date: Wed, 1 Nov 2017 23:49:05 +0800
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Pengzhen Liu <liupengzhen3@huawei.com>
Cc: thomas@monjalon.net, dev@dpdk.org, stable@dpdk.org
Message-ID: <20171101154905.GV1545@yliu-home>
References: <1509076449-20542-1-git-send-email-liupengzhen3@huawei.com>
<20171101153351.GT1545@yliu-home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171101153351.GT1545@yliu-home>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio: fix memory leak
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Nov 2017 15:49:16 -0000
On Wed, Nov 01, 2017 at 11:33:51PM +0800, Yuanhan Liu wrote:
> On Fri, Oct 27, 2017 at 11:54:09AM +0800, Pengzhen Liu wrote:
> > In function eth_virtio_dev_init(), dynamic memory stored
> > in "eth_dev->data->mac_addrs" variable and it is not freed
> > when function return,
> > this is a possible memory leak.
> >
> > Fixes: 8ced1542f7a3 ("net/virtio: eth_dev->data->mac_addrs is not freed")
> > Cc: stable@dpdk.org
> > Signed-off-by: Pengzhen Liu <liupengzhen3@huawei.com>
>
> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
BTW, I have just seen you have send multiple versions out regarding this
patch. Next time please tag your patches with version, something like:
$ git format-patch -v 2 ...
--yliu