* [dpdk-dev] [PATCH] mem: remove old function from symbol list
@ 2017-11-03 11:24 Thomas Monjalon
2017-11-03 11:34 ` Gonzalez Monroy, Sergio
2017-11-06 21:15 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-11-03 11:24 UTC (permalink / raw)
To: sergio.gonzalez.monroy, jianfeng.tan; +Cc: dev
The function rte_mem_phy2mch() was removed with the support
of Xen dom0.
Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/rte_eal_version.map | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index d2a4ff974..7c9bdc2ae 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -62,7 +62,6 @@ DPDK_2.0 {
rte_malloc_validate;
rte_malloc_virt2phy;
rte_mem_lock_page;
- rte_mem_phy2mch;
rte_mem_virt2phy;
rte_memdump;
rte_memory_get_nchannel;
--
2.14.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list
2017-11-03 11:24 [dpdk-dev] [PATCH] mem: remove old function from symbol list Thomas Monjalon
@ 2017-11-03 11:34 ` Gonzalez Monroy, Sergio
2017-11-03 13:52 ` Thomas Monjalon
2017-11-06 21:15 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Gonzalez Monroy, Sergio @ 2017-11-03 11:34 UTC (permalink / raw)
To: Thomas Monjalon, jianfeng.tan; +Cc: dev, bluca
Hi Thomas,
I reckon you need to bump ABI version when you remove public symbol from
.map file.
Thanks,
Sergio
On 03/11/2017 11:24, Thomas Monjalon wrote:
> The function rte_mem_phy2mch() was removed with the support
> of Xen dom0.
>
> Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> lib/librte_eal/rte_eal_version.map | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index d2a4ff974..7c9bdc2ae 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -62,7 +62,6 @@ DPDK_2.0 {
> rte_malloc_validate;
> rte_malloc_virt2phy;
> rte_mem_lock_page;
> - rte_mem_phy2mch;
> rte_mem_virt2phy;
> rte_memdump;
> rte_memory_get_nchannel;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list
2017-11-03 11:34 ` Gonzalez Monroy, Sergio
@ 2017-11-03 13:52 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-11-03 13:52 UTC (permalink / raw)
To: Gonzalez Monroy, Sergio; +Cc: jianfeng.tan, dev, bluca
03/11/2017 12:34, Gonzalez Monroy, Sergio:
> Hi Thomas,
>
> I reckon you need to bump ABI version when you remove public symbol from
> .map file.
Yes, of course, unless it has already been dumped:
http://dpdk.org/commit/f26ab687a74
> On 03/11/2017 11:24, Thomas Monjalon wrote:
> > The function rte_mem_phy2mch() was removed with the support
> > of Xen dom0.
> >
> > Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > lib/librte_eal/rte_eal_version.map | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> > index d2a4ff974..7c9bdc2ae 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -62,7 +62,6 @@ DPDK_2.0 {
> > rte_malloc_validate;
> > rte_malloc_virt2phy;
> > rte_mem_lock_page;
> > - rte_mem_phy2mch;
> > rte_mem_virt2phy;
> > rte_memdump;
> > rte_memory_get_nchannel;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list
2017-11-03 11:24 [dpdk-dev] [PATCH] mem: remove old function from symbol list Thomas Monjalon
2017-11-03 11:34 ` Gonzalez Monroy, Sergio
@ 2017-11-06 21:15 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-11-06 21:15 UTC (permalink / raw)
To: dev; +Cc: sergio.gonzalez.monroy, jianfeng.tan
03/11/2017 12:24, Thomas Monjalon:
> The function rte_mem_phy2mch() was removed with the support
> of Xen dom0.
>
> Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-06 21:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 11:24 [dpdk-dev] [PATCH] mem: remove old function from symbol list Thomas Monjalon
2017-11-03 11:34 ` Gonzalez Monroy, Sergio
2017-11-03 13:52 ` Thomas Monjalon
2017-11-06 21:15 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).