From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 208C11B2EB for ; Mon, 6 Nov 2017 16:56:58 +0100 (CET) Received: from lfbn-1-6068-189.w90-110.abo.wanadoo.fr ([90.110.3.189] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1eBjrU-0002BT-4b; Mon, 06 Nov 2017 17:02:57 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 06 Nov 2017 16:56:48 +0100 Date: Mon, 6 Nov 2017 16:56:48 +0100 From: Olivier MATZ To: Thomas Monjalon Cc: Santosh Shukla , sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org Message-ID: <20171106155646.bvjt2pri2n3gejp6@platinum> References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <20171106014141.13266-1-thomas@monjalon.net> <20171106014141.13266-13-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106014141.13266-13-thomas@monjalon.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 12/15] mbuf: rename data address helpers to IOVA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 15:56:58 -0000 On Mon, Nov 06, 2017 at 02:41:38AM +0100, Thomas Monjalon wrote: > The following inline functions and macros have been renamed to be > consistent with the IOVA wording: > > rte_mbuf_data_dma_addr -> rte_mbuf_data_iova > rte_mbuf_data_dma_addr_default -> rte_mbuf_data_iova_default > rte_pktmbuf_mtophys -> rte_pktmbuf_iova > rte_pktmbuf_mtophys_offset -> rte_pktmbuf_iova_offset > > The deprecated functions and macros are kept to avoid breaking the API. > > Signed-off-by: Thomas Monjalon Same here, there are some remaining references after I apply the patches (maybe we are not on the same base commit id). $ git grep 'mbuf.*phys' ... lib/librte_mbuf/rte_mbuf.c: fprintf(f, "dump mbuf at %p, phys=%"PRIx64", buf_len=%u\n", ... test/test/test_cryptodev.h:pktmbuf_mtophys_offset(struct rte_mbuf *mbuf, int offset) { test/test/test_cryptodev.h: printf("pktmbuf_mtophys_offset: offset out of buffer\n"); test/test/test_cryptodev_blockcipher.c: pktmbuf_mtophys_offset(iobuf, test/test/test_cryptodev_blockcipher.c: pktmbuf_mtophys_offset(sym_op->m_src, Apart from that, Acked-by: Olivier Matz