From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 0D7E91B201 for ; Wed, 15 Nov 2017 09:13:38 +0100 (CET) Received: from lfbn-1-6068-189.w90-110.abo.wanadoo.fr ([90.110.3.189] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1eEsv8-00043L-Os; Wed, 15 Nov 2017 09:19:44 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 15 Nov 2017 09:13:30 +0100 Date: Wed, 15 Nov 2017 09:13:30 +0100 From: Olivier MATZ To: Thomas Monjalon Cc: Ivan Boule , dev@dpdk.org, john.mcnamara@intel.com Message-ID: <20171115081327.gzr2rzhpftcu5hn2@platinum> References: <1508164067-22952-1-git-send-email-ivan.boule@6wind.com> <44436245.kbII4kygmp@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44436245.kbII4kygmp@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for ethdev port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 08:13:39 -0000 On Wed, Nov 15, 2017 at 12:50:55AM +0100, Thomas Monjalon wrote: > 16/10/2017 16:27, Ivan Boule: > > To help administrative tasks on ports, new per-port information need > > to be added into the data structure rte_eth_dev_info supplied by the > > dev_infos_get() function exported by a Poll Mode Driver. > > > > See http://dpdk.org/ml/archives/dev/2017-September/074885.html for > > details. > > > > Signed-off-by: Ivan Boule > > Acked-by: Olivier Matz > > --- > > +* librte_ether: additional fields will be added into the ``rte_eth_dev_info`` > > + structure in 18.02, breaking the API. These fields will contain: > > + > > + - the set of supported link modes, > > + - the set of advertised link modes, > > + - the type of port connector, > > + - autonegotiation enabled or not. > > This patch is not accepted in 17.11 for following reasons: > - it requires at least 3 acks > - we are not going to break API in 18.02, except maybe for EAL devargs > - the link mode is redundant with the speed capabilities > - such fields require work (and time) for every PMD to be fully supported > - we should discuss more generally which infos are in the scope of this function > > Sorry for the short notice, I was waiting for comments and to see if > other deprecations were sent (or not) for ethdev. Thomas, be aware that it's very frustrating to have this kind feedback 9 weeks after the submission of the RFC, and few days before the release. Olivier