From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E9248200 for ; Fri, 24 Nov 2017 06:39:18 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2017 21:39:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,444,1505804400"; d="scan'208";a="6393843" Received: from deepin-15.sh.intel.com (HELO deepin-15.5-oivbkq) ([10.67.104.165]) by fmsmga001.fm.intel.com with ESMTP; 23 Nov 2017 21:39:17 -0800 Date: Fri, 24 Nov 2017 13:38:52 +0800 From: Tiwei Bie To: Xiao Wang Cc: dev@dpdk.org, yliu@fridaylinux.org Message-ID: <20171124053851.d24yf2cgxmo2j63i@deepin-15.5-oivbkq> References: <1511521440-57724-1-git-send-email-xiao.w.wang@intel.com> <1511521440-57724-2-git-send-email-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1511521440-57724-2-git-send-email-xiao.w.wang@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: make control queue thread-safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 05:39:19 -0000 On Fri, Nov 24, 2017 at 03:03:59AM -0800, Xiao Wang wrote: [...] > diff --git a/drivers/net/virtio/virtio_rxtx.h b/drivers/net/virtio/virtio_rxtx.h > index 54f1e84..24e3026 100644 > --- a/drivers/net/virtio/virtio_rxtx.h > +++ b/drivers/net/virtio/virtio_rxtx.h > @@ -84,6 +84,7 @@ struct virtnet_ctl { > rte_iova_t virtio_net_hdr_mem; /**< hdr for each xmit packet */ > uint16_t port_id; /**< Device port identifier. */ > const struct rte_memzone *mz; /**< mem zone to populate CTL ring. */ > + rte_spinlock_t sl; /**< spinlock for control queue. */ Please use spaces instead of (4 spaces) tabs between the code and comments. Best regards, Tiwei Bie