DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: Declan Doherty <declan.doherty@intel.com>,
	dev@dpdk.org, Gaetan Rivet <gaetan.rivet@6wind.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] security: fix device operation type
Date: Fri, 24 Nov 2017 13:07:29 +0100	[thread overview]
Message-ID: <20171124120729.ily7e4c6exvkla3v@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <538dcacd-8d64-66b8-56dc-21339d1e8188@nxp.com>

On Fri, Nov 24, 2017 at 03:03:52PM +0530, Akhil Goyal wrote:
> Hi Nelio,
> On 11/23/2017 3:32 PM, Nelio Laranjeiro wrote:
> > Device operation pointers should be constant to avoid any modification
> > while it is in use.
> > 
> > Fixes: c261d1431bd8 ("security: introduce security API and framework")
> > Cc: akhil.goyal@nxp.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> >   lib/librte_security/rte_security.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h
> > index aa3a471a3..679c0a696 100644
> > --- a/lib/librte_security/rte_security.h
> > +++ b/lib/librte_security/rte_security.h
> > @@ -94,7 +94,7 @@ enum rte_security_ipsec_tunnel_type {
> >   struct rte_security_ctx {
> >   	void *device;
> >   	/**< Crypto/ethernet device attached */
> > -	struct rte_security_ops *ops;
> > +	const struct rte_security_ops *ops;
> Do we require this change for crypto ops as well.

Yes, only drivers should be able to change modify this pointer.

> >   	/**< Pointer to security ops for the device */
> >   	uint16_t sess_cnt;
> >   	/**< Number of sessions attached to this context */
> > 
 
Thanks,

-- 
Nélio Laranjeiro
6WIND

  reply	other threads:[~2017-11-24 12:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22  8:10 [dpdk-dev] [PATCH " Nelio Laranjeiro
2017-11-22  8:10 ` [dpdk-dev] [PATCH 2/3] crypto: fix pedentic compilation errors Nelio Laranjeiro
2017-11-22  9:48   ` De Lara Guarch, Pablo
2017-11-22 10:35     ` Nelio Laranjeiro
2017-11-22 13:56   ` Neil Horman
2017-11-22 14:31     ` Gaëtan Rivet
2017-11-22 16:50       ` De Lara Guarch, Pablo
2017-11-22  8:10 ` [dpdk-dev] [PATCH 3/3] security: fix pedentic compilation Nelio Laranjeiro
2017-11-23 10:02   ` [dpdk-dev] [PATCH v2 1/3] security: fix device operation type Nelio Laranjeiro
2017-11-24  9:33     ` Akhil Goyal
2017-11-24 12:07       ` Nelio Laranjeiro [this message]
2018-01-08  9:58         ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
2018-01-08 10:05           ` Akhil Goyal
2018-01-08 12:34     ` De Lara Guarch, Pablo
2017-11-23 10:02   ` [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors Nelio Laranjeiro
2017-12-11 11:49     ` De Lara Guarch, Pablo
2017-12-11 12:42       ` Nelio Laranjeiro
2017-12-11 13:54         ` De Lara Guarch, Pablo
2017-12-11 14:16           ` Nelio Laranjeiro
2018-01-08 10:00             ` De Lara Guarch, Pablo
2018-01-08 12:35     ` De Lara Guarch, Pablo
2017-11-23 10:02   ` [dpdk-dev] [PATCH v2 3/3] security: fix pedantic compilation Nelio Laranjeiro
2017-11-24  9:34     ` Akhil Goyal
2018-01-08 12:35     ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171124120729.ily7e4c6exvkla3v@laranjeiro-vm.dev.6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).