From: Chen Hailin <chenhl@arraynetworks.com.cn>
To: Aaron Conole <aconole@redhat.com>, jianfeng.tan <jianfeng.tan@intel.com>
Cc: "ovs-dev@openvswitch.org" <ovs-dev@openvswitch.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
cloud <cloud@arraynetworks.com.cn>,
qemu-devel <qemu-devel@nongnu.org>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type
Date: Fri, 24 Nov 2017 17:59:09 +0800 [thread overview]
Message-ID: <2017112417590937512732@arraynetworks.com.cn> (raw)
In-Reply-To: <f7tine8z6pj.fsf@dhcp-25-97.bos.redhat.com>
Hi Aaron Conole && Jianfeng,
The stp could not work in ovs-dpdk vhostuser.
Because the attached vhost device doesn't have MAC address.
Now we have two ways to solve this problem.
1. The vhost learns MAC address from packet like as my first patch.
2. The virtio notifies MAC address actively to vhost user .
In my opinions, if we treat it as a device, we should allocate
MAC address for the device when the VM started.
Which one do you think better?
Best Regards,
Chen Hailin
chenhl@arraynetworks.com.cn
From: Aaron Conole
Date: 2017-11-18 10:00
To: Hailin Chen
CC: ovs-dev@openvswitch.org; Maxime Coquelin; cloud@arraynetworks.com.cn
Subject: Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type
Hi Hailin,
Hailin Chen <chenhl@arraynetworks.com.cn> writes:
> The stp could not work on netdev-dpdk if network is loop.
> Because the stp protocol negotiates designate port by sending
> BPDU packets which contains MAC address.
> However the device doesn't have MAC address in vhostuser type.
> Thus, function send_bpdu_cb would not send BPDU packets.
>
> This patch will set the MAC for device when received first packet.
>
> Signed-off-by: Hailin Chen <chenhl@arraynetworks.com.cn>
> ---
Thanks for the patch.
In general, I don't think this is the right approach to deal with this
type of issue. I believe the problem statement is that OvS bridge is
unaware of the guest MAC address - did I get it right? In that case, I
would think that a better way to solve this would be to have virtio tell
the mac address of the guest. I don't recall right now if that's
allowed in the virtio spec, but I do remember some kind of negotiation
features.
I've CC'd Maxime, who is one of the maintainers of the virtio code from
DPDK side. Perhaps there is an alternate way to solve this.
_______________________________________________
dev mailing list
dev@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
next parent reply other threads:[~2017-11-24 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171117063635.9244-1-chenhl@arraynetworks.com.cn>
[not found] ` <f7tine8z6pj.fsf@dhcp-25-97.bos.redhat.com>
2017-11-24 9:59 ` Chen Hailin [this message]
2017-11-27 14:27 ` Yuanhan Liu
2017-11-27 15:34 ` Tan, Jianfeng
2017-11-27 17:01 ` Aaron Conole
2017-11-28 16:06 ` Tan, Jianfeng
2017-11-27 16:14 ` Aaron Conole
2017-11-27 16:35 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2017112417590937512732@arraynetworks.com.cn \
--to=chenhl@arraynetworks.com.cn \
--cc=aconole@redhat.com \
--cc=cloud@arraynetworks.com.cn \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=ovs-dev@openvswitch.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).