From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, yliu@fridaylinux.org, tiwei.bie@intel.com,
jianfeng.tan@intel.com, vkaplans@redhat.com
Cc: stable@dpdk.org, jfreiman@redhat.com,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v2 0/3] vhost: MQ live-migration fixes
Date: Fri, 24 Nov 2017 19:08:23 +0100 [thread overview]
Message-ID: <20171124180826.18439-1-maxime.coquelin@redhat.com> (raw)
Sorry, posted the wrong version. Only patch 2 changes in the v2,
the log_lock is read-locked is moved after the VHOST_F_LOG_ALL
feature check, so that it does not degrade performance when
not doing the live-migration.
This 3 patches series fixes issues met when doing live-migration
with multiple queue pairs.
Patch 1 is theorical and unlikely to be reproduced in real use-cases,
so it may be safe not to pick it in stable trees.
Patch 2 reproduces quite often when lots of packets are being processed.
Easiest way to reproduce it is to run DPDK in guest and perform IO
loopback with testpmd. This patch targets both v16.11 & v17.11 stable
trees, and will require a rework for v16.11 as some dirty logging
functions moved from virtio-net.c to vhost.h. I'm not sure of the
process here, but I can provide the v16.11 backport if needed.
Patch 3 is a regression introduced in v17.11. For a reason I have
yet to understand, QEMU sends VHOST_USER_SET_VRING_ADDR requests
when live-migration is initiated. The problem is that the vhost-user
protocol thread has no way to be sure the PMD threads are accessing
the rings or not. As the new addresses sent by QEMU are the same
it sent intially, this patch just ignores them.
Regards,
Maxime
Maxime Coquelin (3):
vhost: fix fd leak in VHOST_USER_SET_LOG_BASE
vhost: protect dirty logging against logging base change
vhost: don't invalidate vrings if new addresses are identical
lib/librte_vhost/vhost.c | 2 ++
lib/librte_vhost/vhost.h | 14 +++++++++++---
lib/librte_vhost/vhost_user.c | 32 ++++++++++++++++++++++++++++----
3 files changed, 41 insertions(+), 7 deletions(-)
--
2.14.3
next reply other threads:[~2017-11-24 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 18:08 Maxime Coquelin [this message]
2017-11-24 18:08 ` [dpdk-dev] [PATCH v2 1/3] vhost: fix fd leak in VHOST_USER_SET_LOG_BASE Maxime Coquelin
2017-11-24 18:08 ` [dpdk-dev] [PATCH v2 2/3] vhost: protect dirty logging against logging base change Maxime Coquelin
2017-11-27 8:16 ` Victor Kaplansky
2017-11-27 8:27 ` Maxime Coquelin
2017-11-27 8:42 ` Victor Kaplansky
2017-11-27 9:00 ` Maxime Coquelin
2017-11-28 10:06 ` Maxime Coquelin
2018-02-14 2:03 ` Tan, Jianfeng
2018-02-14 7:52 ` Maxime Coquelin
2018-02-22 2:54 ` Tan, Jianfeng
2017-11-24 18:08 ` [dpdk-dev] [PATCH v2 3/3] vhost: don't invalidate vrings if new addresses are identical Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124180826.18439-1-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreiman@redhat.com \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=vkaplans@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).