From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A64CD201 for ; Mon, 27 Nov 2017 15:27:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3F98920CDB; Mon, 27 Nov 2017 09:27:52 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 27 Nov 2017 09:27:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Mhnw9Q u8p6rbOzxQ05CA8Mdgqz07DVfwNPwjs2fzc8M=; b=Q6YOszzOiRTyZY2tlwL5eA zRXAAoSz180cJDRoMQEY8iSrzjaE2ThBvCytWklv9nOZ1pS11/xdLVOX/yVjRgnz AxGVw7xs6SM48f7txlL53Im3CuGwOD6UaQa/HqA2qqM6gsqJrFrY4k3nfJKu+1YF f7ft7zPU94+19Ksy9QXT2rnLq3l28TL0JkpbL6mEpenC6K8+cbAZMAOptuFiyFG9 jWt208qb9Rqjkf6CYIFfRnClyzQHJ7tCA4FhVRWrSNjPJ0MtHDxsZwULWWG46LXF /E1BiN7Wxh379drNhfV9BRnWesx8ov6l1NzAD/vJdebVsyF+tg30kZzJaTIUtxlg == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Mhnw9Qu8p6rbOzxQ05CA8Mdgqz07DVfwNPwjs2fzc 8M=; b=qWurdvs/xsdIbrZLT0SvJF+cmQrpdlvrYOcsfb5pKt9XsvGNOQJ3HvPz+ A3ZwdSdycYPatayRVNnEeweKy3N5qjxwMWl/bHbdA0fQ5sPyZBwlTUJleOUYmjPl O1NICDFKb2CgRGKzpglahwD+fvBAMMmjggRntBx43c9yPOph7mt+VijTealMJSjv A7ae6eUO3H08RytMLAAbjef8K8pJJ3JQFsxpI16nulr48Y0P8RdaHPzzDmPWn3PD XMUlrHPMzpJazryvISLQ75nSBtn5wCfAjs1dKzd5yNdvZFn/a6E5le9//hjoAuJ5 5EhG67pRlrp6JWn4WSgjDDfm1Atrg== X-ME-Sender: Received: from yliu-dev (unknown [180.158.62.82]) by mail.messagingengine.com (Postfix) with ESMTPA id CE24A7E56E; Mon, 27 Nov 2017 09:27:50 -0500 (EST) Date: Mon, 27 Nov 2017 22:27:32 +0800 From: Yuanhan Liu To: Chen Hailin Cc: Aaron Conole , "jianfeng.tan" , "ovs-dev@openvswitch.org" , Maxime Coquelin , cloud , qemu-devel , dev Message-ID: <20171127142515.GA450@yliu-dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2017112417590937512732@arraynetworks.com.cn> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 14:27:52 -0000 On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: > Hi Aaron Conole && Jianfeng, > > The stp could not work in ovs-dpdk vhostuser. > Because the attached vhost device doesn't have MAC address. > > Now we have two ways to solve this problem. > 1. The vhost learns MAC address from packet like as my first patch. I do agree with Aaron this is not the right way. > 2. The virtio notifies MAC address actively to vhost user . Unfortunately, AFAIK, there is no way to achieve that so far. we could either let virtio/QEMU to expose the CQ to vhost or add a new VHOST_USER message to carry the mac address. While vhost-user is a generic interface adding a virtio-net specific message also doesn't seem quite right. Exposing CQ is probably the best we can do. Anyway, both need spec change. --yliu > > In my opinions, if we treat it as a device, we should allocate > MAC address for the device when the VM started. > > Which one do you think better? > > > > Best Regards, > Chen Hailin > chenhl@arraynetworks.com.cn > > From: Aaron Conole > Date: 2017-11-18 10:00 > To: Hailin Chen > CC: ovs-dev@openvswitch.org; Maxime Coquelin; cloud@arraynetworks.com.cn > Subject: Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type > Hi Hailin, > > Hailin Chen writes: > > > The stp could not work on netdev-dpdk if network is loop. > > Because the stp protocol negotiates designate port by sending > > BPDU packets which contains MAC address. > > However the device doesn't have MAC address in vhostuser type. > > Thus, function send_bpdu_cb would not send BPDU packets. > > > > This patch will set the MAC for device when received first packet. > > > > Signed-off-by: Hailin Chen > > --- > > Thanks for the patch. > > In general, I don't think this is the right approach to deal with this > type of issue. I believe the problem statement is that OvS bridge is > unaware of the guest MAC address - did I get it right? In that case, I > would think that a better way to solve this would be to have virtio tell > the mac address of the guest. I don't recall right now if that's > allowed in the virtio spec, but I do remember some kind of negotiation > features. > > I've CC'd Maxime, who is one of the maintainers of the virtio code from > DPDK side. Perhaps there is an alternate way to solve this. > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev