From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4AC4A2B9E for ; Tue, 28 Nov 2017 12:22:28 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2017 03:22:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="181466815" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 28 Nov 2017 03:22:25 -0800 Received: by (sSMTP sendmail emulation); Tue, 28 Nov 2017 11:22:24 +0000 Date: Tue, 28 Nov 2017 11:22:24 +0000 From: Bruce Richardson To: junjie.j.chen@intel.com Cc: sergio.gonzalez.monroy@intel.com, john.mcnamara@intel.com, maryam.tahhan@intel.com, reshma.pattan@intel.com, dev@dpdk.org Message-ID: <20171128112224.GA5724@bricha3-MOBL3.ger.corp.intel.com> References: <20171128095654.6452-1-junjie.j.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128095654.6452-1-junjie.j.chen@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] doc: add a restriction to multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 11:22:29 -0000 On Tue, Nov 28, 2017 at 04:56:54AM -0500, junjie.j.chen@intel.com wrote: > From: Junjie Chen > > This patch add a restriction to multi-process support: secondary > processes should only run alongside primary process with same DPDK > version, so that secondary processes can use the same hugepage mmap > layout as primary process. > > Signed-off-by: Junjie Chen > --- > doc/guides/prog_guide/multi_proc_support.rst | 1 + > doc/guides/tools/proc_info.rst | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst > index 9a9dca7fe..0cd67ae2d 100644 > --- a/doc/guides/prog_guide/multi_proc_support.rst > +++ b/doc/guides/prog_guide/multi_proc_support.rst > @@ -51,6 +51,7 @@ For now, there are two types of process specified: > Standalone DPDK processes are primary processes, > while secondary processes can only run alongside a primary process or > after a primary process has already configured the hugepage shared memory for them. > +And secondary processes should only run alongside primary process with same DPDK version. > > To support these two process types, and other multi-process setups described later, > two additional command-line parameters are available to the EAL: > diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst > index fd17e278c..512fd3263 100644 > --- a/doc/guides/tools/proc_info.rst > +++ b/doc/guides/tools/proc_info.rst > @@ -36,7 +36,8 @@ The dpdk-procinfo application is a Data Plane Development Kit (DPDK) application > that runs as a DPDK secondary process and is capable of retrieving port > statistics, resetting port statistics and printing DPDK memory information. > This application extends the original functionality that was supported by > -dump_cfg. > +dump_cfg. Note that dpdk-procinfo can only run alongside primary process with > +same DPDK version. > > Running the Application > ----------------------- > -- Good to add to the docs. I suggest that you add them using the proper "note" markup to make it clearer in the docs. /Bruce