From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0047.outbound.protection.outlook.com [104.47.41.47]) by dpdk.org (Postfix) with ESMTP id BED102B9E for ; Wed, 29 Nov 2017 04:50:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1Xtb1Ia2iTRPhVMOx/cEF210kC3lLJqcpvsAJ4hyv8Q=; b=ZpCzfSRTPoPOLFetzUkw1jkyJ30lAeiElyAwN2kOEhkY9NFM2M1XyGffjxOA8RTup+OyVzVx/0VrQ32tSbvay2QLf0QDlY9bXg6ClUnsPj1aCKv7I+brRx8YiCy21BiolypaTe5nvwu4MzJrsYBEC3m2bzg/i91EhYGRu1aTwE8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.112.235) by SN2PR07MB2527.namprd07.prod.outlook.com (10.167.14.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Wed, 29 Nov 2017 03:50:54 +0000 Date: Wed, 29 Nov 2017 09:20:35 +0530 From: Jerin Jacob To: Abhinandan Gujjar Cc: dev@dpdk.org, Nikhil Rao , hemant.agrawal@nxp.com, nipun.gupta@nxp.com Message-ID: <20171129035034.GA1810@jerin> References: <1510210357-61382-1-git-send-email-abhinandan.gujjar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510210357-61382-1-git-send-email-abhinandan.gujjar@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.76.112.235] X-ClientProxiedBy: BM1PR0101CA0072.INDPRD01.PROD.OUTLOOK.COM (10.174.220.162) To SN2PR07MB2527.namprd07.prod.outlook.com (10.167.14.155) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f45aa81f-1acf-4f11-2840-08d536dc65c0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603199); SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 3:T/YjBMSgccqDyRa2vm5CqT3JxjvtgMIwEBjC/IThvzrRkIz7zFCspHnB6bbd3JHKmvP33/SNMDR9IFjcb31h/WBEmgpTPG9nCMd8wY6ov8FLTT2W88rfUZtPo7Z0/bJMjBuNK4iGAp7vG2EUQT8ma/3WbjvsriR2Sb+tSp8mQ2ntmEtlN3JFZWM/6mzzL+ojbmSFirc69o3oNLvO8xUmj5QrfjHtkqXv4E7QjHh1fsknfexh9dXTrZtwsZedm5Ea; 25:WY3eO47sfok6MPrHQdYBKr+2LK0c0m5b/0bipSz3vliOHU1ici/6xQFwpyeoOQ09akBN/dR/MwrjkGO0mDKyRqtH8TMqwT+8pJLZLk8KEGCWwCWhQGOfs/pKMZE36IA/mdN0VOc1gSbry38Jb0hbIKR8W+A5AlxHcy+zN95dfUk8klkg28LhSz34eWW/wk88dORQkrWElstYLEonK8MydEJL9i8a+pirOcZdjYTSd3z26Ua9Wla1BAxYIaHAeo/MZi/9ontGAQsI1MZMYSLxTei6uy338jAH7SeAVD/PsZTrBcCSA5p90aQXJYt3JO01wvCmdmgVMB9PAgwSe5yJEQ==; 31:3UafFDk3YgWs7BLzpoJ/an3O0e7acolj4SenBGkGioHIYAhqScUnU95fPjrXHtmxF9JUvgutA+MKFTf18o3eq4fuvDiQ1JBNR2lovHYDWcZjSF0N6/4Ku0sOI/jVRpT2F2XICxi2jOq1sd+stxm1jwKvABXwcC62iZPbnUQmaGnokuQ7uIdFZ+t+8XOCOaQoxOByZ2EXXJUpzW0r/4qv1tCij+S6mjOgSsb75wLf4oM= X-MS-TrafficTypeDiagnostic: SN2PR07MB2527: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 20:PKnzgxff7PJFCqgUo81qTzf9POC8b9/cy9KKsztw0Af+19fF543sj9M0MhoOOE2zSQNCeW4/cjD6XNsO/0/gfciXJZNdio6Yz72xY8wV3zR8/BYk7WuSim/2BUEgWDdqF4vvtemWE3PrOtKZGbKrnge6KiTQYOBXHRpx4EOx0n0gzO7VrGL7izW1yfJ6o1hmVvrNXADyYFFwOOp9iJBhdZdRJXrOVujyRRTqU6E+ODJzyPiJC1zqa3kBgn7uicGmJYKW+itwqsr8maHfSe4vNDJAnGwKkzzkq+vRcMYL1aKPvx+UWk7BgSiH/aMg61SHPOtqIt/a2u/chNRYgna3iUfn2qqZgrJlHK5GCR/o8ER1oiFgeVs6o25w6bAOK7lYcBvBCdgb4F6xEGqgO4GFJfUC52ftNY2g2WWz59vhL0v+tp3Gh5BcrYFn7jqfuUOQNyCnYEJlDwnvi4yUPI8MaabDmJmceDNe3k43NgVtjO1QbWuMoiHXtWh1e1KIyewXeIiL6bcpyGbMnvuC6jNEpI0XL/OFQl/+iS7c1uvEa3EaZLbzecAU3rxQslCXdW+ifa5oEG+kdoKgQhvYr7I7AZii1+JricdReE+oI46BlII=; 4:od75Z4/bBvEBTifBxIvPEjl8DgE3DvYFZx1gXDIDSSt7HHkyrPWgnmRX7pg+JxyrVIeo3p08o3qXfu6/bwjgc4aelKyclIxUHuXCNVDKZfJfTT1rkcCxtWSdz3+WuHeU/6YchaS15R4PT5IA0gx+P+VTFSCc2K9qz3jt8M4pcqYYYGWs2D21bHDLcyYJpPQcNBG0PgAxtxks0qN3H0a9x5qvnjFzDl1rX9SVmhx3vciBltLfka/itfLG1CHVxGFkZ1Q3SJIc+oG2K2qDCK8GV2GGkVq77he4aee0/je4mgmtQitRH6sxYddnniw3w4d7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(93006095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(6072148)(201708071742011); SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2527; X-Forefront-PRVS: 05066DEDBB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(366004)(376002)(51914003)(13464003)(189002)(199003)(6116002)(3846002)(68736007)(1076002)(23726003)(4326008)(5660300001)(6246003)(8936002)(2906002)(16526018)(97736004)(52116002)(72206003)(478600001)(25786009)(316002)(66066001)(16586007)(58126008)(47776003)(81156014)(76176999)(50986999)(101416001)(81166006)(6496006)(54356999)(83506002)(33656002)(229853002)(8676002)(8656006)(305945005)(105586002)(106356001)(55016002)(189998001)(7736002)(33716001)(53936002)(50466002)(6666003)(9686003)(6916009)(42882006)(2950100002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2527; 23:6z7oGR5pfFz6GxQW6tSGRtozNxgnTaHtD/xPmxXwk?= =?us-ascii?Q?Z0hKbykZvmjP/AX4kEQB2XK81SZoV6PhIfNpsL/iJBFuA+0X2qZ5b+dxmE8N?= =?us-ascii?Q?C9zvVZp14zL2utZo5ACsHntcbY/tSWMBTtNaI1wnPv/efxknWhTqdfjVFon6?= =?us-ascii?Q?Isz9gO9lrdl9aHGoSfYd8VR/aYmgaPpHriimLRPFQKvs3VUiG1vWRUbZ6r1h?= =?us-ascii?Q?igbYsI06wSf95bm4vmAnwbLTy+0pHO7BTDtk+ccx66wsWh06WZhWhlhHZxew?= =?us-ascii?Q?EDBYeyloybiofoABoxMrWblEnefdSPq9QsBapQfO7B45KerqkZWUTqYw6aKw?= =?us-ascii?Q?JPuKj8+XxG2MnJ98B4QkhCmYWIzOgPWH2X5GMiEPau/6YhVpAiecEOOmEgqK?= =?us-ascii?Q?+MpbdxOpYmVerQBOVFyr5XlZTVUvHJ0IAnXcJNoCDgjOVDCz+cUC8kNXMa1B?= =?us-ascii?Q?/MHOOmlbvc1YVcXvVtix9YtB9B3infx06BBAKIvzb7n1gecCAiWwiAx44uXU?= =?us-ascii?Q?6CGqGPSjvFonthtumdkNHyIl0D4C4YBosb6BnVuUNngfOTp7b1weTgotXfcF?= =?us-ascii?Q?rZWz4+rQbscDF0ofeKiymE7cfBb9W4q9Yp3Kau9aPaubCkpliEctSxYlXrTm?= =?us-ascii?Q?iCfZ0NXZ+yn+Bu1X0XY0CRzgmXoegV2Vkc2kHNul50dYxwA3VFZQRgNqsDP2?= =?us-ascii?Q?F5fsaF51D7pXKfZFjmWQ9hR28M3gKEsIvatNbLX6XUGtblwShwnctXe2m3Re?= =?us-ascii?Q?/89Y3zBZI5DNX8zLmRiswA5IkbQbw54ZARrSYh4jWtTWR3MjNhOm3LT9Ulmv?= =?us-ascii?Q?KfV5/t+YQpH8qYOUdOjO4FRLbio9j8/K/w9Q2golZvrJmtaUwf+Lx+rwKMOI?= =?us-ascii?Q?WauDRNKC1KI4b5sAI4vzgLil2C9/swCzrdccZVgqc5CcjjKe1eK5vh9FBHUt?= =?us-ascii?Q?g/UZuHrkDk14wqKREPF2RPbXGTG2EplYu5kCPfa8mukqR0izI4fW9QDbxRVF?= =?us-ascii?Q?2Zl+IRcPYrSihM7Go/NdKHpLAbEdXd+AQdHEZCqCCoxv5VUIRRff/chSdCu0?= =?us-ascii?Q?xpMnNmbsGtDsIOIj2xSNI3OyzIgjVARQHSHA1K6yq3zvLvpw0ZZ5ti+Z9RHX?= =?us-ascii?Q?dkjkU+MSljH8M1bxBHk2a4nkq8Eo/hRamZU6PusILdqRQ2YFxlyupmb4FFiL?= =?us-ascii?Q?Y/sUlqSSmxzWzaf0MELumc9+oFkkP2Neg6E4gu8gmgCXlpk6sL59WS0ztgvV?= =?us-ascii?Q?65aLCJVA48LlpY/rfzmXz+EZw+FwTiZu5VICm6P?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 6:S5z1PatI1qtEA6xqRaab/nqiBLMZQbHbAduV6zrq6c9m6jDDIGm3Old3vAHaQBoGxAgxcsDQPVEZEmNbmwQpgZfhf2wnz4pI7YsOcp4N0BJgfgOiXGTNHsnPeerp+pTn+SxG4Hb2I/wuN9u5inXcoreLi9jEAhfalrzbA21q87uAQJ93Uv3egloft+vAGjZ5vPCZGuUeESC1cR1r/pBQZ5iuAEaZfLSC+K1smOcQzNaBOTvy93R4JjvXVNf5dtHDyliP7NCVH2yRDT3OF1dIVth4PqyZFloLjND/LVKGanYVQdDVgRUlxeu2M9KDkeTV1MRHrEuag8qkWAQoXs+uHu8988YbcW6uFmbmAmIi1J0=; 5:Wfa//ot9JO0tieK9ZfzIGeai1zifoxt6J9HBSWnOGoAPXQASSCqDeFmpBsF7k6XdPwFapQc0EDXUJVW4j0vBf1jeTWkJpI3x0H8fDVXUHv+BOd1CJU+YgAEZVQ5UMyVNBpawuAdjdfj0gePe0ZsYQS36aMNgxVO5wJZ2FVROZDU=; 24:pL0Ip6+gpThoyzrAjAmioJqAeFfht07Xs27jONa/X9CKwQhIGa8WHOHEwQd5teba425tlmS3D80K/xNQsfQSZdKAzCgriNq858k/LC+c8I8=; 7:QdDInKpWwJclPVApkSbU5VpDd6w80iB+CaYpuQOCxxLGOBnzhKw8zv5UiL/W1Ni9kLpOuMMrBeOlrhz8/Ylr7xF8jNMnWmpfl/X1BX90RwPkFJXGHQA2+x75Q6BqBbynvk9P0bOBwLC6DqANp2+Mp+VjkG5obzvcCotgKn/NmN1vYeqdVm1ZuaXjWBz4ROJ+VSFvzgAoiQCDNOeRPNRHdbTPcugExKS/WtASCLZ/GyYPKoi9kB8SvfJt4btQC0l4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2017 03:50:54.9340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f45aa81f-1acf-4f11-2840-08d536dc65c0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527 Subject: Re: [dpdk-dev] [RFC] eventdev: add caps API and PMD callback for crypto adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 03:50:59 -0000 -----Original Message----- > Date: Thu, 9 Nov 2017 12:22:37 +0530 > From: Abhinandan Gujjar > To: jerin.jacob@caviumnetworks.com > CC: dev@dpdk.org, Abhinandan Gujjar , Nikhil > Rao > Subject: [RFC] eventdev: add caps API and PMD callback for crypto adapter > X-Mailer: git-send-email 1.9.1 > > Signed-off-by: Abhinandan Gujjar > Signed-off-by: Nikhil Rao Hi Abhinandan, Thanks for the contribution. Some comments below, > --- > lib/librte_eventdev/rte_eventdev.c | 25 +++++++++++++++++++ > lib/librte_eventdev/rte_eventdev.h | 44 ++++++++++++++++++++++++++++++++++ > lib/librte_eventdev/rte_eventdev_pmd.h | 32 +++++++++++++++++++++++++ > 3 files changed, 101 insertions(+) > + > +/* Crypto Rx adapter capability bitmap flags */ > +#define RTE_EVENT_CYRPTO_ADAPTER_CAP_INTERNAL_PORT 0x1 > +/**< Flag indicates HW is capable of generating events. > + * Cryptodev can send packets to the event device using internal event port. > + */ > +#define RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ 0x2 > +/**< Flag indicates adapter supports multiple event queues per cryptodev. > + * Each cryptodev queue pair can be connected to a unique event queue. > + */ > +#define RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ 0x3 The value should be 4 as it is a flag. > +/**< Flag indicates adapter supports event queue enqueue based on mbuf metadata. > + * Mbuf metadata will be used enqueue to unique event queue. > + * Event information will be stored in metadata of each mbuf > + * @see struct rte_event_crypto_adapter_mbuf_metadata Since CPU is enqueuing the crypto ops to HW(Unlike ethdev Rx adapter, Which is hardwired to Ingress packet Input hardware), I think, we may NOT need RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ and RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ capabilities. Adding NXP folks to get the comment on capabilities requirement for their HW. If no one needs RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ and RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ then we can remove it. Jerin