From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Gage Eads <gage.eads@intel.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com,
bruce.richardson@intel.com, hemant.agrawal@nxp.com,
nipun.gupta@nxp.com, santosh.shukla@caviumnetworks.com,
pbhagavatula@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH] eventdev: set rte errno in port link/unlink functions
Date: Mon, 4 Dec 2017 10:42:32 +0530 [thread overview]
Message-ID: <20171204051231.GA19673@jerin> (raw)
In-Reply-To: <20171204030619.GA549@jerin>
-----Original Message-----
> Date: Mon, 4 Dec 2017 08:36:20 +0530
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> To: Gage Eads <gage.eads@intel.com>
> CC: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com,
> hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
> santosh.shukla@caviumnetworks.com, pbhagavatula@caviumnetworks.com
> Subject: Re: [dpdk-dev] [PATCH] eventdev: set rte errno in port link/unlink
> functions
> User-Agent: Mutt/1.9.1 (2017-09-22)
>
> -----Original Message-----
> > Date: Tue, 14 Nov 2017 16:44:10 -0600
> > From: Gage Eads <gage.eads@intel.com>
> > To: dev@dpdk.org
> > CC: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
> > bruce.richardson@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
> > santosh.shukla@caviumnetworks.com, pbhagavatula@caviumnetworks.com
> > Subject: [PATCH] eventdev: set rte errno in port link/unlink functions
> > X-Mailer: git-send-email 2.7.4
> >
> > The return value for rte_event_port_{link, unlink}() is defined as the
> > "number of {links, unlinks} actually established." However, the eventdev
> > layer's error checking returns negative error values. This commit aligns
> > the eventdev code with the API definition by having it set rte_errno and
> > return 0 if it detects an error.
> >
> > Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs")
> >
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied to dpdk-next-eventdev/master. Thanks.
>
prev parent reply other threads:[~2017-12-04 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 22:44 Gage Eads
2017-12-04 3:06 ` Jerin Jacob
2017-12-04 5:12 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204051231.GA19673@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).