From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 18BC8237 for ; Mon, 4 Dec 2017 09:10:46 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id k61so16174550wrc.4 for ; Mon, 04 Dec 2017 00:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hQU395z8C0E9P7Or6DZ7rQmCt1fpI8ykDRm9EcABhoQ=; b=WWkHo636WfSxGddqBpFqSAszXBaAMGkqJWv7lwBvsHeavRsSZ4ooWd8j4ssf1jt/kE 6pxT5rSbgybW3stSKxV/thU4y6blBv7Ci2KJcHDEdxO6cN+OIaUAPtllz5FZxN1/VSCE l2yMoqlJpzmXfgtmrVcpuHkPLuF+SrSrioHfyM/9hdoxTGjQHf8maFd5KbbwaqZfaZa9 //9YEPMimfBpVKYQaFTvMAhEDOBFjxY6JaY9C6wSdMlczPRqMNYjbQ06l7NT00uILoT3 bYodx0koAucrC7zRTG5/LsyZ4miBEYNqfPYoIGmTNZoLnsogoXRXYhGRVRFyfgvHeR7k nHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hQU395z8C0E9P7Or6DZ7rQmCt1fpI8ykDRm9EcABhoQ=; b=X+EcHXqpDWvPbGYfP6FVSLiHeMiMkpltubwjFWyt/6MwQGgqDSNpORAQG7QEAxIV+n D9FdXn/Ee+3ntzTYA8TwtDEeXzsutat+m++s1cCNaTVr1STAkozWvVDR80hOiERX3iQv HelcnZFqsUnq9fyzOvGZtpsgmIZr7BVs/Xa4wrmjdFY9bYop4qrkw4Jl4n21puX5nveN CGnS1Rk21jd728iCIzjkgxbWdIgdIJr2QzTkyiJa84owiWija1csPJYugy1SbyXb9+4B NBv40srLN1Ps9lmDu5CzXfMy82j+VUSm07PTUahjsECaW1j+hOKTRVZkwUDpT8c10ecS axVQ== X-Gm-Message-State: AJaThX67FVkB/Psu6fAOyYPxtqXWom32OPFq5S/m935jxNHsdbvEnaZy WFGSAsbEYXvrDKpL9C9ZGfgz X-Google-Smtp-Source: AGs4zMbsUhlTHiFZNIoDAgwDv+h7j6iiA1e91j6XO1VNiuAtrFhQ0iYMQw2ooQCkjzkFsDXKz+aY1g== X-Received: by 10.223.136.250 with SMTP id g55mr11472783wrg.54.1512375045748; Mon, 04 Dec 2017 00:10:45 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l31sm24156704wrc.50.2017.12.04.00.10.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Dec 2017 00:10:45 -0800 (PST) Date: Mon, 4 Dec 2017 09:10:56 +0100 From: Nelio Laranjeiro To: Xueming Li Cc: Adrien Mazarguil , Thomas Monjalon , dev@dpdk.org Message-ID: <20171204081056.2rrtocnglat7u4ow@laranjeiro-vm.dev.6wind.com> References: <20171129173106.120828-2-xuemingl@mellanox.com> <20171203060812.74932-2-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171203060812.74932-2-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC v1 1/5] ethdev: support rss level on tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 08:10:46 -0000 Hi Xueming, On Sun, Dec 03, 2017 at 02:08:08PM +0800, Xueming Li wrote: > There was no RSS hash fields level definition on tunnel, implementations > default RSS on tunnel to outer or inner. Adding rss level enable users > to specifiy the tunnel level of RSS hash fields. > > 0: outer most, > 1: inner, > -1: inner most(PMD auto detection if nested tunnel specified in fields) > > Signed-off-by: Xueming Li > --- > lib/librte_ether/rte_flow.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h > index 47c88ea52..41ab91912 100644 > --- a/lib/librte_ether/rte_flow.h > +++ b/lib/librte_ether/rte_flow.h > @@ -1078,6 +1078,14 @@ struct rte_flow_action_dup { > */ > struct rte_flow_action_rss { > const struct rte_eth_rss_conf *rss_conf; /**< RSS parameters. */ > + /** > + * RSS on tunnel level: > + * 0: outer RSS > + * 1: inner RSS > + * 2-254: deep inner tunnel level RSS > + * -1: inner most level according to flow pattern > + */ Not clear enough, some PMD like MLX5 accept rules starting from the VXLAN level, the comment "Inner most level according to flow pattern" does not inform inside which tunnel the RSS will be done as this pattern does not provide any information related to the position of the tunnel in the packet. What are the expectation for such situation? > + uint8_t level; > uint16_t num; /**< Number of entries in queue[]. */ > uint16_t queue[]; /**< Queues indices to use. */ > }; > -- > 2.13.3 > Thanks, -- Nélio Laranjeiro 6WIND