DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: revert workaround for broken Verbs
Date: Mon, 4 Dec 2017 17:52:39 +0100	[thread overview]
Message-ID: <20171204165239.GJ4062@6wind.com> (raw)
In-Reply-To: <1511947286-4911-1-git-send-email-matan@mellanox.com>

On Wed, Nov 29, 2017 at 09:21:26AM +0000, Matan Azrad wrote:
> This workaround was needed to properly handle device removal with old
> Mellanox OFED releases that are not supported by this PMD anymore.
> 
> Starting from rdma-core v16 this removal issue shouldn't happen when
> setting MLX4_DEVICE_FATAL_CLEANUP environment variable to 1.
> 
> Set the aforementioned variable to 1.
> 
> Reverts: 5f4677c ("net/mlx4: workaround verbs error after plug-out")
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>

You should expand the commit ID a bit:

Reverts: 5f4677c6ad5e ("net/mlx4: workaround verbs error after plug-out")

Other than that,

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Thanks.

-- 
Adrien Mazarguil
6WIND

  reply	other threads:[~2017-12-04 16:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  9:21 Matan Azrad
2017-12-04 16:52 ` Adrien Mazarguil [this message]
2017-12-06  6:39   ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204165239.GJ4062@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).