From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 80060325B for ; Mon, 4 Dec 2017 17:52:52 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id 9so7034978wme.4 for ; Mon, 04 Dec 2017 08:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZaLfPDfcQ1MX6sm5noqzCymiVfWWOdv76R9lEGu3C8Y=; b=mjLZltE85USv0RG8nm0xXZunia3LHaHyLhAmfVe9+675U22yMkzFS6y+ekByO1heIw UAw7/j8AXzyYixeUoBm8XMG/LqUz7/0ZYtbkFsOtSy/MmJuYtvLZ0OWrLCrkO8WNAYtw 1MFByKDVdpARur2ouAPjvWjXAbCGB1IiZb9WbxTPhbd7fxadHUvygyPFDEbDDhHHeejD j8PQUG4c17OAmif1UGBGTVSkLRARal1+zjwpzlZlXhLZCEXsYjbpBUlaPEqBgL3yTRU5 J0gM6CsrXLIo+EnTKTDleM92JPDuVcyXZ+ePTEcKMbPg7pTQvYBv9l7hK44lvKz4HJA2 ZgTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZaLfPDfcQ1MX6sm5noqzCymiVfWWOdv76R9lEGu3C8Y=; b=Rg9q6KF9+H8eRG9fUT/91QpcX3rm+0w6TeoYS5rDxQg4uLGqBPqtYm2KEcqhSDT0RU k2gRBYIS1IdfotjriVE313q0fs8z8lgZfqTfZtQwIzKhFgwj2JCdTrvSDnLtTwnmzXy6 ihvdgi3njvEJKw5bGr6OM5PjJsjNgAtf/BlSRxk+lRFexnM2FUhP7pEN4/K9QEhBFRMg l6AbUkqYwsUX7vIxH8HQN5Y898ihoXSFfvBxHp47ghKLe8xQYjpkgTI4BgynR8za5/5J bPDPwY/EHKywyGVMHYfbrh6p6PCmGzpP5XEanpuFZ+DrGnT8yzj6OoCbyHfqX4lvLR2h SrPg== X-Gm-Message-State: AKGB3mJeU/n5di/dQIXNpdZOxy/hk6ew4oqow6cS+c+0mKlpeaNGeDsy d5imyEq8QoyoqRG79B65fqsb/Q== X-Google-Smtp-Source: AGs4zMYJT4EBntVjv8UljtcrbpCpzpHFKlo12qnSgvrFaR0rJeJbhjWTKuetIve5qFSqxG+bGs2zvw== X-Received: by 10.28.8.67 with SMTP id 64mr7608750wmi.34.1512406372148; Mon, 04 Dec 2017 08:52:52 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k11sm8789045wmi.18.2017.12.04.08.52.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 08:52:51 -0800 (PST) Date: Mon, 4 Dec 2017 17:52:39 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org Message-ID: <20171204165239.GJ4062@6wind.com> References: <1511947286-4911-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511947286-4911-1-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: revert workaround for broken Verbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 16:52:52 -0000 On Wed, Nov 29, 2017 at 09:21:26AM +0000, Matan Azrad wrote: > This workaround was needed to properly handle device removal with old > Mellanox OFED releases that are not supported by this PMD anymore. > > Starting from rdma-core v16 this removal issue shouldn't happen when > setting MLX4_DEVICE_FATAL_CLEANUP environment variable to 1. > > Set the aforementioned variable to 1. > > Reverts: 5f4677c ("net/mlx4: workaround verbs error after plug-out") > > Signed-off-by: Matan Azrad You should expand the commit ID a bit: Reverts: 5f4677c6ad5e ("net/mlx4: workaround verbs error after plug-out") Other than that, Acked-by: Adrien Mazarguil Thanks. -- Adrien Mazarguil 6WIND