From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id F25D31E2B for ; Tue, 5 Dec 2017 10:56:25 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id n138so131921wmg.2 for ; Tue, 05 Dec 2017 01:56:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HHjxAadzi+hpj97EbAPcUaGzfsSMf4yNL3AqFntzqWc=; b=YOLjojR3OnzAaNBnhqiHbQCcscXbopALeFq65DnZ5U0nvDyT9lKRBHEP7H39cPaBxB Fg/f2yd7dCMyuMivDIPW9UggWRtNKCY2TOyf6V4fxzSKwpER6PFdKXCBF23sStd5TzgM gNy6SJobvFsRVNF3CQNR9LMbRPNJ+bmHaFv5/jQRkMwLYCvPoje9Fv88+knW49TDt6BI ig8dtqWJRFFPdOHWbhdXsYN9PzcxFYeOGOP/syE5ZPyfTguu1ynYHfgDsSvhU8aq5OpI KfXfOs6d38/PyADTHyS3ZX11tL1XmbmJkdGySVGarFfME4wzDuinw0fDqABLq4iySbjl p/cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HHjxAadzi+hpj97EbAPcUaGzfsSMf4yNL3AqFntzqWc=; b=RsOZT93kFdcC8IFa2s+VmqtQGsS4kuqAFwRW1YI3LKgBgzI56Gtqlek55gz3eXBoY/ jka80cmanBJK5C5llsLhlk/XklpFXLhmn9ME2z98ARp5YWXueHH68G7KiuF+zWYRgzs2 XIiZdAgzAILriK2cJKQ7UW6RQNyHK7hKhDF5+oolaFHk0QoaUh14eoDxUpybrJlrSOeH wuYYthGPH811VSDCXy2GbIC9MWlxFiX85jte6W31wnpMLvtPHf3sdd5RJyMfflnEt74L 5Y0TpaEY+7lg98EQYdVXIAXljNmhhMxVuCSK8cU5IIh8MpeyQ7ipE3PBpifdZL67N0ky BOeA== X-Gm-Message-State: AKGB3mLFNjDLDGIwBYu3zg6K2h51dUyDUQ7o6sHbNfzMDjSChLJ6nwC8 v48VgWXrejQvO7vSuRxrGlK/ X-Google-Smtp-Source: AGs4zMaHSuQPOngcpxgrkqfeOg9mUE3z1daJSAAlbj1BgOpIYnw/RhSS7I+huKedyW9ShKko5Eb1UA== X-Received: by 10.28.127.197 with SMTP id a188mr9230231wmd.138.1512467785662; Tue, 05 Dec 2017 01:56:25 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r82sm40822wme.31.2017.12.05.01.56.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Dec 2017 01:56:25 -0800 (PST) Date: Tue, 5 Dec 2017 10:56:39 +0100 From: Nelio Laranjeiro To: Raslan Darawsheh Cc: dev@dpdk.org, shahafs@mellanox.com, stable@dpdk.org Message-ID: <20171205095639.sebpze34rhlt5jdd@laranjeiro-vm.dev.6wind.com> References: <1512466670-19229-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1512466670-19229-1-git-send-email-rasland@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 09:56:26 -0000 On Tue, Dec 05, 2017 at 11:37:50AM +0200, Raslan Darawsheh wrote: > Chnaged ibv_flow_attr type for allmulti rule to IBV_FLOW_ATTR_MC_DEFAULT > instead of IBV_FLOW_ATTR_NORMAL, in case allmulti was enabled. > > Fixes: 272733b5 ("net/mlx5: use flow to enable unicast traffic") > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/mlx5/mlx5_flow.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 1eda836..eaa53e2 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -429,6 +429,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { > /** Structure to pass to the conversion function. */ > struct mlx5_flow_parse { > uint32_t inner; /**< Set once VXLAN is encountered. */ > + uint8_t allmulti:1; /** Set once allmulti dst MAC is encountered. */ > uint32_t create:1; > /**< Whether resources should remain after a validate. */ > uint32_t drop:1; /**< Target is a drop queue. */ > @@ -1165,6 +1166,17 @@ priv_flow_convert(struct priv *priv, > } > } > } > + if (parser->allmulti && > + parser->layer == HASH_RXQ_ETH) { > + for (i = 0; i != hash_rxq_init_n; ++i) { > + if (!parser->queue[i].ibv_attr) > + continue; > + if (parser->queue[i].ibv_attr->num_of_specs != 1) > + break; > + parser->queue[i].ibv_attr->type = > + IBV_FLOW_ATTR_MC_DEFAULT; > + } > + } > return ret; > exit_enomem: > for (i = 0; i != hash_rxq_init_n; ++i) { > @@ -1262,6 +1274,7 @@ mlx5_flow_create_eth(const struct rte_flow_item *item, > eth.val.ether_type &= eth.mask.ether_type; > } > mlx5_flow_create_copy(parser, ð, eth_size); > + parser->allmulti = eth.val.dst_mac[0] & 1; > return 0; > } > > -- > 2.7.4 It also concerns DPDK 17.11, adding stable@dpdk.org Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND