From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id A5F971B160 for ; Wed, 6 Dec 2017 11:57:58 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id l141so6433009wmg.1 for ; Wed, 06 Dec 2017 02:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d0Ruc68UadMD6TRSoHgpAbtCsXokXsqDgpggUJqGOMo=; b=vv6Fizsh0lWlTr5MaMzQ3bTKuM5IiwBDzqZgwRfMeZrvh+h34KbyZCnuH+4/B7LIWp mEfW40A7Dhj0CuJvd7owMu3nTqr9ZV3Bjx8uDtdwOHENdOnp/xjcPcwlRZEJ714Ln2ul 3O1fCdUNisss00cCOU3b37I+F5FiOJz89bBNF5z/xJE72Q0Ij4gQaXL5dV7AgR6NwnIC SvA+geyFiy7d6beo/LNnIfzxGJGdFaLSmTPo8G4pfwXNozX2eVSyBsdm5ORcgoF8Hwq2 sboj/uhWC1JBybcmdQ00bKQvRiWsbQ/57l4jS3BLzNO08fHmRCNzTT2oVxz9fVXc2kjJ cz+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d0Ruc68UadMD6TRSoHgpAbtCsXokXsqDgpggUJqGOMo=; b=unzBnaDevTwW5rhPV35kJH4rIVC68IpqxDaCMotiKFwiVoBPlTAEGQnN8okV2zVxRX fIj8zRPyk7seQODVW8y9LKxhBJKVf5as9iYysygc7pVdxfV1DgpiJ5vFaRadqXACTY06 N+rp9UZ71VMlENrmF28fBeu1+Lv36PpHtWJGWxnSXEvYDU+Qt1jK2ocyBc+cBGGu8pUb XyadD1uD2EvbpSqQNfP5+0AVihKVxyUYgSwV/uKbWvL2WK5At0hunYSZRHgfSWXDrmn2 wdo0J4yTkdNr/uOtEhy5hLZ5PGR+Dta13CXnIRrYSarby+Lh69ChNCRymP19HeOD7m4X 6VqA== X-Gm-Message-State: AKGB3mIjE2q8UfHYOo1QG9N3zaa3yjjDScuY69aNXecpdryAgNqaKnpD vQHVf50de6e5V32xeZbx5WycAQ== X-Google-Smtp-Source: AGs4zMYf5LTk+tFcTALKsKdwdusB1lMPPKfT2czy5r2POvxpEeoGpGPjm8RU54K2BabLusSgL/GDDg== X-Received: by 10.28.147.84 with SMTP id v81mr8589904wmd.133.1512557878334; Wed, 06 Dec 2017 02:57:58 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d23sm2623999wma.48.2017.12.06.02.57.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 02:57:57 -0800 (PST) Date: Wed, 6 Dec 2017 11:57:42 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20171206105742.GS4062@6wind.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> <1511871570-16826-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511871570-16826-2-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH 1/8] net/mlx4: fix Tx packet drop application report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 10:57:58 -0000 On Tue, Nov 28, 2017 at 12:19:23PM +0000, Matan Azrad wrote: > When invalid lkey is sent to HW, HW sends an error notification in > completion function. > > The previous code wouldn't crash but doesn't add any application report > in case of completion error, so application cannot know that packet > actually was dropped in case of invalid lkey. > > Return back the lkey validation to Tx path. > > Fixes: 2eee458746bc ("net/mlx4: remove error flows from Tx fast path") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND