From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 723501B193 for ; Wed, 6 Dec 2017 11:59:20 +0100 (CET) Received: by mail-wr0-f177.google.com with SMTP id v105so3431632wrc.3 for ; Wed, 06 Dec 2017 02:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FVBRuB1m2KhwYqlHmJfPjxjgQJvIImcfP+HFh+oszCU=; b=KhaPSU85UwnkraNgljOgIi4kXW8JKhiaRXyIz/oEhmWwsTEKCqeLvy4XFJo/H+4WYd 8XPRY/kh7Q76/GgkHkJKHNfuITMW/ocTw4eGIE1Ch+TQ884JKy4+kP7J6JJgjSdf2lXF eijBDY+n9jcjKi1I8tJnIVP+HHRUM2dZqIrTBPrcoaTqvDBYMZROhPogsvy63Qpag1KO 2eTb8UugwTBsKaFv8T5cnf9WLnUEcT6y4hlhbb03qjfmMMWId1qOn//2PZ+r7QggeQTN HzujwXe45kbTs42UqDF1NX1uQ8iQx9mTeypmWIDDYLMPpuU98c07eJCk8BRVWVgK0+lT KPMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FVBRuB1m2KhwYqlHmJfPjxjgQJvIImcfP+HFh+oszCU=; b=MBB+8sgaDdSu+ZFE9nKc5wMu9Uiw9kbGNGOGVm4G8mGA+0oQWNRLEu3c9S+flmV1oL jO4KnmLNv6Hs3rLNKySCm5je8rmCTekkWk1TeN6v2WhqV2cEX0kU3hVlmJTtP1TDA9qn VX72x1wQE5REBxAXPeJ1zpJu7+y6x3jqFY5rbGSZaQTkTc5j7ah7MzsKDNU2QbYICW98 z2psWY3wJ6NkMU5NJg99r6UZ6/1CPsLltqCUWZXl0oZVZ2HKSvj2chtpp4Z/e5MFnbRh 2d/UvH9lN+nm/wCefKmZWSiGu6gWxJv+id4k5ISi9JqlGN/Lf3/3YzZO4x6F8iWSEGNw HoYA== X-Gm-Message-State: AJaThX4KyexM/yBqo5mglM3CebkkJ+DTM1jkfoDEzwMHXoAvZsmHq6rs jVjohkEGupCzSgX8nK7ERZwqAw== X-Google-Smtp-Source: AGs4zMau0rTkIgagzt7cVvkevE01jpK5nuajPSszzTdw69WEtaUSLTlGT9AGdf0mxtXKi/evEuiCRQ== X-Received: by 10.223.169.183 with SMTP id b52mr20951113wrd.63.1512557960256; Wed, 06 Dec 2017 02:59:20 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 73sm2224193wrb.64.2017.12.06.02.59.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 02:59:19 -0800 (PST) Date: Wed, 6 Dec 2017 11:59:08 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org Message-ID: <20171206105907.GX4062@6wind.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> <1511871570-16826-7-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511871570-16826-7-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH 6/8] net/mlx4: mitigate Tx send entry size calculations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 10:59:20 -0000 On Tue, Nov 28, 2017 at 12:19:28PM +0000, Matan Azrad wrote: > The previuse code took a send queue entry size for stamping from the > send queue entry pointed by completion queue entry; This 2 reads were > done per packet in completion stage. > > The completion burst packets number is managed by fixed size stored in > Tx queue, so we can infer that each valid completion entry actually frees > the next fixed number packets. > > The descriptors ring holds the send queue entry, so we just can infer > all the completion burst packet entries size by simple calculation and > prevent calculations per packet. > > Adjust completion functions to free full completion bursts packets > by one time and prevent per packet work queue entry reads and > calculations. > > Save only start of completion burst or Tx burst send queue entry > pointers in the appropriate descriptor element. > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND