From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 35B987CFC for ; Wed, 6 Dec 2017 17:23:07 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id g130so23836003wme.0 for ; Wed, 06 Dec 2017 08:23:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=imz8zfG/uWv7fii0456mXu3bu2Hnjw6Zx+M/hDsFBI0=; b=VPdsZheH/RiF4daaWT/tS9C9gtjM0Z8q7rJ8WZUu2H6He6njCsnZzqC2uEL0Lf/09Z viX0U50NyjD+M0gEpjznBFJCW4onprvraSoAsUKUzSsaKNAdAEb1656bFk/tSekC9ulr UqqlPEcfFmjU4LevO8BhOeir9dq/+49xiRAjsN39w25sk1ONwL/tTnKibKDpbXaB2KFG Ouv9xqSRQ0jW7RZ79Wm6KzUIx3zrlLlpT3wCq454Cb4dPF117zsPsoWus19AFSHQZEZG jyZQE91Ofet3DsnlgRK3tX/68NWeGPGPJpK0epGfunoFM87Qk1TMh4GYv2q/Q1kexIvQ WGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=imz8zfG/uWv7fii0456mXu3bu2Hnjw6Zx+M/hDsFBI0=; b=QuDJOgE4gYQRTqVLgcIOp8iWDgZp55eGM/Yf7/xGNcHEoD9eOETJaZgYn9lqNdvj5b clsBCmBg3WeqkPJhQGPKEZiNtAJTc7U+R3CqkQKy/QuiND6Mn4QML6Cry5aZk1kJ8jzY +MVLVZVg+E8FzBXn2p3dI+9Xtb3Zst3ISI+T43dGCmHXWsZv9sxpcQqwZyuN3v0TMKOp rZ73CHDvxGTSIYFIyUhGOrsj+/FYcnlRpBjIdm/O/qyMzY5zYhIFz1p/ztOxJTPkgsGO 90/SZhljBtOCVQFV3Iyy5OHCiiDjXHPWlUQq0KGY49E3zPsEc1vUtpiJ4vMncXBNIcrj sXwQ== X-Gm-Message-State: AKGB3mL+oNXrlgGdI69WX4g4nyCA7XaBTeypMDP39gj4Z+K+3cqYScTo 0MtUZvCP8OzB8pQcHpXNCxwoC5BV X-Google-Smtp-Source: AGs4zMaQ2yaorF3nH7cVI7ZWNSuTxF5nAEPO8AFyTNaKltafRfeAwU0Q4guFlF71M87MF97HZ2OIKw== X-Received: by 10.28.107.211 with SMTP id a80mr8694638wmi.71.1512577387775; Wed, 06 Dec 2017 08:23:07 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f18sm3305578wrg.66.2017.12.06.08.23.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 08:23:06 -0800 (PST) Date: Wed, 6 Dec 2017 17:22:55 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org Message-ID: <20171206162255.GJ4062@6wind.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> <1512571693-15338-1-git-send-email-matan@mellanox.com> <1512571693-15338-9-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512571693-15338-9-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v2 8/8] net/mlx4: remove Tx completion elements counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 16:23:08 -0000 On Wed, Dec 06, 2017 at 02:48:13PM +0000, Matan Azrad wrote: > This counter saved the descriptor elements which are waiting to be > completted and was used to know if completion function should be Looks like you forgot one minor change before adding my ack: completted => completed > called. > > This completion check can be done by other elements management > variables and we can prevent this counter management. > > Remove this counter and replace the completion check easily by other > elements management variables. > > Signed-off-by: Matan Azrad > Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND