From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7A7D92B89 for ; Thu, 7 Dec 2017 11:33:21 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 02:33:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,372,1508828400"; d="scan'208";a="11353972" Received: from deepin-15.sh.intel.com (HELO debian-xvivbkq) ([10.67.104.165]) by fmsmga001.fm.intel.com with ESMTP; 07 Dec 2017 02:33:19 -0800 Date: Thu, 7 Dec 2017 18:32:50 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: yliu@fridaylinux.org, dev@dpdk.org Message-ID: <20171207103250.4zghbdrbatww5msr@debian-xvivbkq> References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-6-tiwei.bie@intel.com> <248fce65-c2af-e3c7-d833-201c60506f05@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <248fce65-c2af-e3c7-d833-201c60506f05@redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Subject: Re: [dpdk-dev] [PATCH 5/5] net/virtio: squeeze repeated blank lines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 10:33:21 -0000 On Thu, Dec 07, 2017 at 10:22:43AM +0100, Maxime Coquelin wrote: > On 12/07/2017 06:30 AM, Tiwei Bie wrote: > > Squeeze repeated blank lines with below scripts: > > > > for i in $(find . -name "*.[ch]"); do \ > > cat -s $i > /tmp/x && mv /tmp/x $i; done > > > > Signed-off-by: Tiwei Bie > > --- > > drivers/net/virtio/virtio_ethdev.c | 1 - > > drivers/net/virtio/virtio_logs.h | 1 - > > drivers/net/virtio/virtio_pci.c | 1 - > > drivers/net/virtio/virtio_pci.h | 2 -- > > drivers/net/virtio/virtio_rxtx.c | 2 -- > > 5 files changed, 7 deletions(-) > > > I don't really like such cleaning patches. > It does not bring added value, but can create conflicts later when > backporting or rebasing. > Okay. I'll drop this patch in the next version. Thanks! Best regards, Tiwei Bie