* [dpdk-dev] [PATCH] pdump: fix error code check when creating/canceling pthread
@ 2017-12-08 10:20 Olivier Matz
2018-01-16 16:02 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2017-12-08 10:20 UTC (permalink / raw)
To: dev, Reshma Pattan; +Cc: stable
On error, pthread_create() returns a positive number (an errno)
but does not set the errno variable.
Fixes: 278f945402c5 ("pdump: add new library for packet capture")
Cc: stable@dpdk.org
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_pdump/rte_pdump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c
index bc18f814a..44dcc9531 100644
--- a/lib/librte_pdump/rte_pdump.c
+++ b/lib/librte_pdump/rte_pdump.c
@@ -581,7 +581,7 @@ rte_pdump_init(const char *path)
if (ret != 0) {
RTE_LOG(ERR, PDUMP,
"Failed to create the pdump thread:%s, %s:%d\n",
- strerror(errno), __func__, __LINE__);
+ strerror(ret), __func__, __LINE__);
return -1;
}
/* Set thread_name for aid in debugging. */
@@ -604,7 +604,7 @@ rte_pdump_uninit(void)
if (ret != 0) {
RTE_LOG(ERR, PDUMP,
"Failed to cancel the pdump thread:%s, %s:%d\n",
- strerror(errno), __func__, __LINE__);
+ strerror(ret), __func__, __LINE__);
return -1;
}
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] pdump: fix error code check when creating/canceling pthread
2017-12-08 10:20 [dpdk-dev] [PATCH] pdump: fix error code check when creating/canceling pthread Olivier Matz
@ 2018-01-16 16:02 ` Mcnamara, John
2018-01-17 13:58 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2018-01-16 16:02 UTC (permalink / raw)
To: Olivier Matz, dev, Pattan, Reshma; +Cc: stable
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Olivier Matz
> Sent: Friday, December 8, 2017 10:20 AM
> To: dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>
> Cc: stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] pdump: fix error code check when
> creating/canceling pthread
>
> On error, pthread_create() returns a positive number (an errno) but does
> not set the errno variable.
>
> Fixes: 278f945402c5 ("pdump: add new library for packet capture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] pdump: fix error code check when creating/canceling pthread
2018-01-16 16:02 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
@ 2018-01-17 13:58 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-01-17 13:58 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, Mcnamara, John, Pattan, Reshma, stable
> > On error, pthread_create() returns a positive number (an errno) but does
> > not set the errno variable.
> >
> > Fixes: 278f945402c5 ("pdump: add new library for packet capture")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-17 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08 10:20 [dpdk-dev] [PATCH] pdump: fix error code check when creating/canceling pthread Olivier Matz
2018-01-16 16:02 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
2018-01-17 13:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).