From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [RFC 4/4] eal: set affinity for control threads
Date: Fri, 8 Dec 2017 11:26:57 +0100 [thread overview]
Message-ID: <20171208102657.2699-5-olivier.matz@6wind.com> (raw)
In-Reply-To: <20171208102657.2699-1-olivier.matz@6wind.com>
The management threads must not bother the dataplane or service cores.
Set the affinity of these threads accordingly.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_eal/common/eal_common_thread.c | 20 +++++++++++++++++++-
lib/librte_eal/common/include/rte_lcore.h | 4 +++-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index b4335e04e..f1798cebc 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -45,6 +45,7 @@
#include <rte_memory.h>
#include <rte_log.h>
+#include "eal_private.h"
#include "eal_thread.h"
RTE_DECLARE_PER_LCORE(unsigned , _socket_id);
@@ -199,7 +200,9 @@ int rte_ctrl_thread_create(pthread_t *thread, const char *name,
.start_routine = start_routine,
.arg = arg,
};
- int ret;
+ unsigned int lcore_id;
+ rte_cpuset_t cpuset;
+ int set_affinity, ret;
pthread_barrier_init(¶ms.launched, NULL, 2);
pthread_barrier_init(¶ms.configured, NULL, 2);
@@ -216,6 +219,21 @@ int rte_ctrl_thread_create(pthread_t *thread, const char *name,
goto fail;
}
+ set_affinity = 0;
+ CPU_ZERO(&cpuset);
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ if (eal_cpu_detected(lcore_id) &&
+ rte_lcore_has_role(lcore_id, ROLE_OFF)) {
+ CPU_SET(lcore_id, &cpuset);
+ set_affinity = 1;
+ }
+ }
+ if (set_affinity) {
+ ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
+ if (ret < 0)
+ goto fail;
+ }
+
pthread_barrier_wait(¶ms.configured);
return 0;
diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h
index f7f67868c..0d85a91a8 100644
--- a/lib/librte_eal/common/include/rte_lcore.h
+++ b/lib/librte_eal/common/include/rte_lcore.h
@@ -265,7 +265,9 @@ int rte_thread_setname(pthread_t id, const char *name);
/**
* Create a control thread.
*
- * Wrapper to pthread_create() and pthread_setname_np().
+ * Wrapper to pthread_create(), pthread_setname_np() and
+ * pthread_setaffinity_np(). The dataplane and service lcores are
+ * excluded from the affinity of the new thread.
*
* @param thread
* Filled with the thread id of the new created thread.
--
2.11.0
next prev parent reply other threads:[~2017-12-08 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 10:26 [dpdk-dev] [RFC 0/4] new function to create " Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 1/4] eal: use sizeof to avoid a double use of a define Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 2/4] eal: new function to create control threads Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 3/4] eal: set name when creating a control thread Olivier Matz
2017-12-08 10:26 ` Olivier Matz [this message]
2018-02-27 14:46 ` [dpdk-dev] [PATCH 0/4] fix control thread affinities Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 1/4] eal: use sizeof to avoid a double use of a define Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 2/4] eal: new function to create control threads Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 3/4] eal: set name when creating a control thread Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 4/4] eal: set affinity for control threads Olivier Matz
2018-03-29 8:04 ` Burakov, Anatoly
2018-03-30 7:30 ` Olivier Matz
2018-03-28 12:54 ` [dpdk-dev] [PATCH 0/4] fix control thread affinities Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208102657.2699-5-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).