From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0049.outbound.protection.outlook.com [104.47.36.49]) by dpdk.org (Postfix) with ESMTP id C4CB337A2 for ; Sat, 9 Dec 2017 10:26:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=c9itE82zUOTmyrS4iqNryOZqcqBMksVF6GpUywHWCHw=; b=ODXXkm+voDuJS+iLRVfa0udv0eeVaJK8APhQNEjLOsK9MQSlUKo8mYk3koVeeL/iMQTobeEmHbsDYI81WnjeB8MqOHSs99jMInecNQbiuC58KRb1DoBPBk5vQnuo0PnZ1HkqSzBHlfbC6n2CrXYT6CATw/ppUQ+GkeFoRC+0gVc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (103.16.71.47) by BN6PR07MB3459.namprd07.prod.outlook.com (10.161.153.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Sat, 9 Dec 2017 09:25:59 +0000 Date: Sat, 9 Dec 2017 14:55:40 +0530 From: Pavan Nikhilesh Bhagavatula To: Ferruh Yigit , santosh.shukla@cavium.com Cc: dev@dpdk.org Message-ID: <20171209092539.xbrhmekhgsoohbvc@Pavan-LT> References: <20171128145855.27106-1-pbhagavatula@caviumnetworks.com> <20171208110807.wafb4z6q74t7hzht@Pavan-LT> <7ebbd6b4-e7ea-4ed0-f06d-572fb1cc3957@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ebbd6b4-e7ea-4ed0-f06d-572fb1cc3957@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: SG2PR01CA0085.apcprd01.prod.exchangelabs.com (10.170.138.139) To BN6PR07MB3459.namprd07.prod.outlook.com (10.161.153.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e52e0a9d-f8db-4067-b4c1-08d53ee6dcbe X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:BN6PR07MB3459; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 3:MUpC8m2useLAN4Y0cIXQbjpaFG+/+bjHuCy2h4NZ7zPkTMcepkOgsE58LCx2R4mNZJ0F6zYOwt3CHgZduJz13CognnyhVnAmI2NCFY9eFBCrv/52s5wHy+mP2qCFUgWeChYhHLVTd3c62BF1FXLIB6WXxOLNCZJ2VHdMQIQoDunns3HQrw4zTfaU6BhpQlwOppbP8jsk8BdY3ZoMkxj5+ICmwWtSgqv+UCQXU13Bne+dG4R7qjX8ENiG+lL7WQ/3; 25:bIfhrs3ud5iU9YITDK+BkHo9IXWeOAe5+Yf1RZCXze9XJna9OModoyQcea5y1fV/3Y576ePyfaG7tpb16xvElv8YvhbfNmN2YqHv2a1XHOqxtAv5B1m9nRj5PvoJK+9VDcsfD1gL3HPAfMZ8m6ybV7XK22RpFl6QeMGzszeUaalFy2w9RTGVgnsdheH/DJeARvFpVC2apa3oWJKdxdh8Rs6zCx2zkQxCS2GWpPU7Q0yRjPe4/PHqg071uYeeccs1J7E5tyyrsWs6Hp8kCZrr5hmMNC6E1YrHrC+GytDRU5YfEoSglvpS2ASXn3DBhTCRtbk5i0j2dTqyd1apKycH9g==; 31:d3STmO/0NYaQBwcnn8qOnpEdUKYyLCu6zN64qZnWAjdGhExxPi/lNCmBXsKzwyLYZjbSw8zR4IkBR2IguuTrP1mmuO8Hmn/jeEcrAhT78Ai+/PAdpRZ8D/0LkC/icNv1s8DDQTkFw3FfhzAgVNZfgB+iin2QDc3AbuKks5NCGfPRwoaZSNzmjhd8AZ5EhUxHgo6bjt/Xkr22VfOXmLq+fHzMFhIOtZvKD4RD//BXkKU= X-MS-TrafficTypeDiagnostic: BN6PR07MB3459: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 20:gofMmpQKalayIepxgw/NVrGpboSx2oAiRUi/Px0ZVLt1ufBT5kNbZf3cr0EBgqNczRiF2fB5+zoGpFCeDXqMBIvGASkKzzT/2nG/3Y/yr1OjpClw2/RCpiNRxUaUdkJ/EY0OjoLmiFa/1NNRA4Ctr390oZUbHPdTyMsryUTq/jIRznIMQDuJVkvFT/DDlvAUd6giBP0QkZSpZ/sHfLXrdsKTPOOKMDFV18krPIoj5uj8YoRS7KSKkRlbvggD8H9GauMPC50eyY56P0nm/E1GtwsXCD6TQwXxoLo8uTQlRk7Od8WlzF1zQxH7TES9WlaGIOMCDPMYLYVtV2P0wFunK36VTyJ0nZWY/3UIbFq1yDckewxpC34VCSwU1sZYifdHGZA+I2Sxwo2Liqq8qklv711SfFZPLKsHYsvhp/aAreFox1rLvq2aWdnbVUl8hb50c0EJd/BYAv04mfjCsTjsErIHvmAOtkwX8nH244HHtPaN1yOpU6MiLVQVLCKPwL74Zb066ltr9wwMUZq6M38SjVO36IBYZCgJzTqmc20bmb8UIrbyG1cyRvo1+edOqWmEY/Rc/IU14PQM4+NV2DaKky3HDANL86Ajy56sk240Gbc=; 4:OIa5ncuNSxWHMmz2Qq6hMcOQjHcVZBiPMyMj0Wd3caJelvVpFiXSPpVoAxe3NgE2C5KgrmTu/U/C/K+EkOfN0vWfowQvuS673tHB5bDl+y42yAUZpQxxwlyX1lhldhmev6MkGHGl8kMAbgsX68Sd5qi1oY6tq3XM7+yVhpBvJFcuCKdR4nkiUs3hkKYPm496LxcC+1YYWOYHMEW5kn0+sba4VZ8CrOczIOapL+ZoLv8aVkhnuXQPTVtOCQvs8WsvvCRXg7yhVOaaJL4I/HFKsw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(3231022)(3002001)(10201501046)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011); SRVR:BN6PR07MB3459; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN6PR07MB3459; X-Forefront-PRVS: 05168A3970 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(24454002)(189003)(199004)(5660300001)(8936002)(33716001)(81166006)(76176011)(1076002)(52116002)(97736004)(81156014)(16586007)(58126008)(55016002)(23726003)(316002)(106356001)(50466002)(8676002)(83506002)(33896004)(6496006)(3846002)(68736007)(3716004)(6666003)(42882006)(2950100002)(7736002)(53546010)(6116002)(9686003)(305945005)(72206003)(2906002)(478600001)(229853002)(16526018)(25786009)(53936002)(47776003)(6246003)(66066001)(93886005)(33646002)(4326008)(105586002)(59450400001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3459; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3459; 23:rQj2IXJH8vvJtKLFPeLUo9UwkWFD6uAoU8Sd5a1BX?= =?us-ascii?Q?I1cM7f0Q7wWf9feGqwk+RILIKFq9sGZvOtRIsaZeM+zzTsi9RjifH+F3NRGO?= =?us-ascii?Q?V8gRATLB4x5okV1dwNg+Xce9icQVI42tyvWDUS8PxeW4/6BdU38iNtcsZQ+T?= =?us-ascii?Q?LQM3OCDM/Bv7O7vFE386+ZDIwjW4QCcmKZxMB7FGtCnn7FjG+9h5UT4oLJ+6?= =?us-ascii?Q?zVWyE4cWNAkjRDzuTn4kgQJAtymSxjWIhmgkWqN4ctcY/FY4p5Ci6A/qH+lW?= =?us-ascii?Q?GcTooLxy/pDnmPyNgy6XQxJs6q4xsCEDoLWufxt8pmm8ebjFRXMVcPuaYiM7?= =?us-ascii?Q?6iVkPH1dSWsClm2HXMqxWvKIItRhfu+f1D06fDHJjxzlNdx8SBigQyuizkQU?= =?us-ascii?Q?khr0j1vvP1FvFxHRpkOanvFYyYMvN7y8sc0eBHl3t8MgrSD9oLN7jtehdJjb?= =?us-ascii?Q?Wi0+RMizlHJ7S3u5Ws06B8NCRYJbax4POv/N6D2vZSe8/xxCHSD2yNbra7pF?= =?us-ascii?Q?jLD13v5XS21dsMbEjkc6Qo5yMKFGGOXy8LSwfULebfmlRG3qi9LSKD/uhS4s?= =?us-ascii?Q?c5V5WcA92kgsnmoL8YCCpcME4AlAalMpnWPSluq/wR7T307iaH4PIctktzar?= =?us-ascii?Q?uTK9pZq2Dtd7mvzvT5MUfWMr5BihF3aeb7+UIQ3EQIRHosLGGJvrozeNlh2V?= =?us-ascii?Q?CuLu0shgCkS5Rk3XAS0lYaWKka7c9QLVvivs+RDWZUoNTv2pl0X83EgTEY5b?= =?us-ascii?Q?1pxjxXzYxXtbKovV8gl/Oy5FoFEmH3R5vVZeCw/ud6gt1Ef1tqmxM/QOtCyU?= =?us-ascii?Q?e/AsJt7TBzxms63cO0jaZeBZJUflM422MomULpDB/r9KoWk3QX8JGbA3yuYP?= =?us-ascii?Q?bMkuj6P5vp95lj86zoDTN90RajmnqY83YDIZHoxj1bbgJZeFn3THbYMpKTNp?= =?us-ascii?Q?L34wgUFL5JcKKGsF6BL0KNyDY51BB5ybpugIDzUx7mPuV+j0l9iP+OEqg8x8?= =?us-ascii?Q?5neNpa0Kl13f2lszbpZ1FOHSJ9YaU/dkRDgckAf0H4DqMoQO39HvH5k81Hmc?= =?us-ascii?Q?nzjZXddXgfuf3gaTi2aCI5XUD4BQaWV9bRxMHLmXARzTGwcPKfJe/Uk2lxus?= =?us-ascii?Q?cLPYZCOoLHK1EGXU5+5FIvHWtva4O/g4BbpPnUbj4C4E8Tj9d+3aSBCD37yA?= =?us-ascii?Q?RCQYUjo6druXDKG+3orluF1jEVa+h+XVkwZI/gKRnPJgrdJHAysmPBwuQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 6:7Pq45EHHH/FZRJYzjlGynzunzsTZs+blmD0WgSaesCVezHHtHuoWakfq5yTL75xBAXnAIIKIXhBiixoagJIOaFybddgQyuGEMmCwUvk1ifo2gII6TveQc0N4pp3ZmBpsaZ9IOPjzaFIhqrm3OFiT+BotUBRE97wLqm3FJ+G3/62zEILZKGFD8gy3RprrxZq5rXfng4VDd0AnjrAOx979EkLu0BWag+zqXRN7Ipy/JRv7koGpRKIAf93soEBFCVgAPt3bTKVVcdHWMD/OV/sXMlrmKUDO4b4oCRrQHiOgyVBRv0hMRzJLBXriSwwjqcVDpIvbvSvYTt7xSK9r43+1W9K4N9iVd8huSgT6fqlAFPg=; 5:JFlGBTe7RDm/YLyEhJ04x1vbLnn5ZW1fH3KMUMC0rCkBjEmyl8KZKkcbv/RqbQ/Sh9oVZ7hAn40h4kZJiiYwf23UOTIHIG4UgWGrlysxKRIlxSe56Yad0g441u/BIS7CobSkVj6mApY1Q1iNEq6zrQKWG1+pj8N+9WZlyWlYoq0=; 24:iP0J514EHgFauudOlc3cDxMG3BaAO/GYkfcHUMJJVVdWbd6vlczYNsXZIMhPK8FFwoepJTTDOEqJW26U2n6IHG+EkAqMYkdKh6DnbINXeDg=; 7:9j+Ceg5cVnQhHwowRnvm3NrwoKaRQUzAl8iIGQqNK6KG1q+qD3HMy8kuhRFhpk9bf/Avthky+0aKK3l4sSXFDPm/DKuc6VXDhkAN23rXzu5OjpWOF47Q/DtKq2MMlpJfEw56PuNlsziFz1rCoAnV3+WXLrVtUfZmnNbVwZb9JG6Ib08vJf1TfU1YKjc+U35XfCxXqad0upSiNpTFAECI1RkTHNsBLQ22RO/Dh0/YDx5KyZHwEeIHFPh/pHACam63 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2017 09:25:59.4678 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e52e0a9d-f8db-4067-b4c1-08d53ee6dcbe X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3459 Subject: Re: [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to port id mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Dec 2017 09:26:04 -0000 On Fri, Dec 08, 2017 at 09:39:00AM -0800, Ferruh Yigit wrote: > On 12/8/2017 3:08 AM, Pavan Nikhilesh Bhagavatula wrote: > > On Thu, Dec 07, 2017 at 04:41:04PM -0800, Ferruh Yigit wrote: > >> On 11/28/2017 6:58 AM, Pavan Nikhilesh wrote: > >>> The channel to port id map is used by event octeontx to map the received > >>> wqe to the respective ethdev port. > >>> > >>> Signed-off-by: Pavan Nikhilesh > >> > >> <...> > >> > >>> @@ -52,12 +52,18 @@ > >>> #define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port") > >>> #define OCTEONTX_MAX_NAME_LEN 32 > >>> > >>> +#define OCTEONTX_MAX_BGX_PORTS 4 > >>> +#define OCTEONTX_MAX_LMAC_PER_BGX 4 > >>> + > >>> static inline struct octeontx_nic * > >>> octeontx_pmd_priv(struct rte_eth_dev *dev) > >>> { > >>> return dev->data->dev_private; > >>> } > >>> > >>> +uint16_t __rte_cache_aligned > >>> +octeontx_pchan_map[OCTEONTX_MAX_BGX_PORTS][OCTEONTX_MAX_LMAC_PER_BGX]; > >> > >> defining global variable in header is generally not good a idea, is there a > >> reason why not variable defined in octeontx_ethdev.c and exported here, so that > >> both octeontx ethdev and eventdev can use it? > > > > The reason extern definition in .h and declaration in .c is not done is that > > it would break shared compilation. > > This should work, you can put object into .so and access from application and/or > other shared libraries. I did a quick test, and seems working, is there anything > I am missing. > > > The other approach is to do it in octeontx_mempool area but it wouldnt make > > sense. > > I could use the mempool approach if it sounds good to you (or) let me know > > if any alternate approach comes to your mind. > > > >> > >> btw, is build time dependency between octeontx ethdev and eventdev documented > >> somewhere? > > > > Currently, there is no build time dependency between event_octeontx and > > eth_octeontx i.e everything builds fine with CONFIG_RTE_LIBRTE_OCTEONTX_PMD=n. > > octeontx eventdev is using a variable from octeontx ethdev header, how can be > there is no build time dependency? > Hi Ferruh, I misread the order in which thing are built. I will send out a v2 with the suggested changes soon. Thanks, Pavan > > > > Thanks, > > Pavan > > >