From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0086.outbound.protection.outlook.com [104.47.33.86]) by dpdk.org (Postfix) with ESMTP id 6144E29CF for ; Sun, 10 Dec 2017 09:34:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=j3zBjrMEE09PpSmGDaHc+JcwBajdpIZz6x1odF6DB/Q=; b=i61NmUn8W6snMZQLaRy2WKNHc74QGwg8+8D6uKM/niHYx4MTkPSKKcZUGTualk5Txmcic0c/ruR9bXjhfniZJb+SNObrj7ZmetxhIc4jhbYGPyTkFjaPIseO3ZgrBN/HoQjKX4niixKI9lDmpkwkNbdfyi8BcWvXfVucixnc1i4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.104.209) by SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Sun, 10 Dec 2017 08:34:49 +0000 Date: Sun, 10 Dec 2017 14:04:33 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: bruce.richardson@intel.com, harry.van.haaren@intel.com, gage.eads@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, nikhil.rao@intel.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org Message-ID: <20171210083432.GB11770@jerin> References: <1508330348-30060-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508330348-30060-2-git-send-email-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508330348-30060-2-git-send-email-pbhagavatula@caviumnetworks.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.76.104.209] X-ClientProxiedBy: MA1PR01CA0083.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::23) To SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e84f32e-e87b-47cf-fcbc-08d53fa8e20e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 3:LeT3RtiE3mApSooEwGqBJ5HlgCf+zp7UwbtvCfmD6grOdBGyHtaTdSdnyEveou9iFe5lpByPa4cSe3gyWLcrLQ3IZi7adp0qq6lJrE+EvkaUXmoI+vFm2lDXsFwAN0Ru1GSrAKeBXl40NLcn9KAxSWibC7UXZ9DhYV3xkF7Bdy2qIC2PbJF89z7sKfEy/jGh8P+jHIQRAdfi0SxUPFR+RqYY9rdBNyCl2faHAVlBheuiabYvJVLde178wrIp/aqj; 25:qNApzx/bakdrUL1u7JriL4TsxxQC81tVuMtVf4nQsz9Lq0V+mWenrSZVq4B+PpX0/TIHxE/89wrlGp21anuRrUdmZ2+yl95Np7+me+BPgWQpkBzS9RGxs7/rUWS6AAEwScof5EA2Jigtz16HbNYznEteN0t5zZD047mw2RIwrw5l/+Ly7VRU+LZXu1zQTUqsP3034qp4FW7xUC/1r9Kj6M/igNQxGp8dCjb6l20qevvF5WnTkKkEcECSh3GqLUe2qPW9Bs+tlyISLZBTSKl6+SG/GdpCDfzLCMFfV4lE2BK6KTMbP0JCV4Pl9NyaeeEfK/DElWgBA68/F6uvPmyvYw==; 31:umg3rULztENdZyhoU/rvHdnWklJ/g+rwCrXefDT334/H3Giy1yMX1nYULi8BmeMNf4yFhTJ4roOAnmAaUvoPifR8LwsexY/8rKWWwq1QmH/rqcMkdcjYP3xGbpXKNxfrSlY7s5GN5FPbU4IqkQJ3BuaurOfNy1lFRwb3k/WHKKQ9+/bZNiQPkM7Sc3Gmb3Et5CXDwkMM3fflxlwSvwBPd/7JDR2jGFUEnDKIiIL1kEU= X-MS-TrafficTypeDiagnostic: SN2PR07MB2528: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 20:SmV4gZIVps4Gr3A4XIAJ6GSDhNPNY9gR8sqyF8X/Dbwi3TQNJUJ+ZANmAj12pGFJf8v0QVgl+O/+AobD0BYWjJkSdEySm83mv0KYgS1XNPrxO9Dze5OO+YYcLwe3g1bhwd214lP8vaL0tq+nL/mvCmx/iM7728loc5qaztrsoV0M5r7fyO5av5k6AKBflcXHf17xYrhg0B2wwdIxmdmDclFsaaFsnaBszcQDcK1Fl4hG72dcrnv+yAUQSrXEX0dLIaFG8/P1Dpq2aWhKTipbtAW/D2S5Bo5wAkdDSWvzoJTHuba78eKenC66huusSPyv7tWtAYXJ4C56JiyPSm2soN6UIIhgcESa+DQFGj5+XbArGxODMJgWk7WQTkK7jIei9ece7uhKivxHSVsuSTN1JAqadDbIilJf4HbrGWZSOn9nQlwqN0VG+sampNbJImsJ8twjlhlh9euButygS6MC1+5ruQpkezXfnzmBfG/1RCelJSvmr34u3axq2LEcWIC9YCsPwcz5lzjsA6vgXh62Ohh/Fk9TY3tlrtUC4xe+l12fOdWpmr611glfLnNMPskHYB/O6WvJOkZa9QQiRjDeWKjLGXi+iwnG3Edqkv/CE3s= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(3231022)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(6072148)(201708071742011); SRVR:SN2PR07MB2528; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 4:PNZ2JtCR/T4fmQvTA0Rn90PEY7C1xP1Q4jXiHb2uGeP4vcgFELsG67Q1AAQYV9i6tuiMyZ20NOSifT19XVdq0KtCMRr2QcQIrNFlmhmlReLBbBb2z1omfmPn/rJ2Mkbz58TPgUI1grsPsQ7IHLM44QL9Zj/tDOdj7rRnLybb87C10qeqZWZ762LILwEbYP8kEzug25Z4KTR2LU6THQcmm365kCWMSj6eA3yVxYSxN/uMMNUfVxZBgvapsrPSlXAyYBSOfeATas7l2h7dKRT8F9LogIq1lOTJmVZ6a7EcYckJwgJvYEOEJl8bRupgQvybD7IpD/STk9T5l+hvNpTNNBVU9gBBI9sjG4Jd8MZvPsg= X-Forefront-PRVS: 05177D47DC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(13464003)(199004)(189003)(66066001)(8656006)(2906002)(68736007)(16526018)(106356001)(16586007)(6862004)(105586002)(81166006)(8676002)(6246003)(9686003)(50466002)(4326008)(83506002)(42882006)(76176011)(2950100002)(7736002)(316002)(6496006)(478600001)(8936002)(47776003)(6116002)(229853002)(25786009)(6636002)(3846002)(52116002)(58126008)(53936002)(81156014)(6666003)(33716001)(23726003)(5660300001)(33896004)(1076002)(33656002)(97736004)(305945005)(72206003)(55016002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2528; 23:H5gGbiQcsPaVUwisihlNWTkhJixehLyiSV/JrZ9ez?= =?us-ascii?Q?pHCA4qYer6lHurhmnEEjEsmwik+i74t+ABsH/Vf7DS5XGWkVRZ4DH700xfKb?= =?us-ascii?Q?B6yjGgDNauaKiPor7QCTVZjBjBUWkUmY58rbfFxZglT1KYaErlyr4IkwFO+w?= =?us-ascii?Q?q+u/ypsibdbpcEOv7crOvhQeuWyGj6o6X4y0msp4tIfzJiippQ8EDalxNUY7?= =?us-ascii?Q?hU5rrLn/NP3Khes17aS6rUtE6NaXF8t1MvJlhCE8YIdFlpYn92kvuMCn0IoN?= =?us-ascii?Q?74np6BMd8ubuvVFWI3O6K1giSb1+YlCcRmTwhSGYDs7tTagC35how2nQ9shp?= =?us-ascii?Q?xfY5MkFDt5qOJUT8C0BIdFFAYKTrddjjLt93gk2paOqkqjF/AosSIw0BfJ0d?= =?us-ascii?Q?KO26+oxieKRGOzoKof5zq9+xxIL+kN6FLCxmHZLMyR2uJ7GDq2jTmxtsviUz?= =?us-ascii?Q?LqencBIaCSMZjHrUmtqJ0IvoAjBmWA4N2b8n3hFRX5SIZyBlgIJWwnlDQ43R?= =?us-ascii?Q?XVeUVXj6XtSrejs4LWRs2JLQ7Mt+iyTSnItLNLnS7K71811lhByU0vr7/auZ?= =?us-ascii?Q?rfnGDUiMMPjFodEooob1bn98SwXOj4qw5/1n8lDIxWE/Rc64KvUmT4ob0ExZ?= =?us-ascii?Q?qUK2adeeFSgaWWifAXYo78oQaC5lP6UHSk8pmX5YHy2sK8SmMFSblsFslMVZ?= =?us-ascii?Q?PZeOgZXlzWK7BC9zbshwJlHJu9YYUaa7Q7A2TPqBmbyndRLBykZ8VDOOKOF0?= =?us-ascii?Q?5jYfsjb+JpYbiyOMziqSP+iIQL3Q1Qd4QqUWIYBPv6rDba80dnEkPkUHSkcC?= =?us-ascii?Q?dZugH5ba7zse1WlPb0ZXjPUBn21v8hGscq83vmzZ509jdv0F1r9sICLuPcHk?= =?us-ascii?Q?YrmH3TxEQbvbz+8HFzMHw6zRHPQCcLBjHjwb4/nQ+M/upbis1yKTKhK0u2B3?= =?us-ascii?Q?c68s4sszhgV8ppcc3iweRPkEwC/Mk2IB8wxwrLf6GoJ4/Z3Ph0ym1c8xwtXA?= =?us-ascii?Q?Az6eGDYMYz9BKRHPKVnigsJGP8AVZs4srqgoCJwU2zfuXFW4c0okWVkBX5s1?= =?us-ascii?Q?/f8F4lYDBmsqnd5l9/lHYIwRdIsBR9YC3iQkaaYR0jgzs8uOCm3U55mpe6TD?= =?us-ascii?Q?5dDHxIKvP4snRvSnWUAzvWkkrxhBfY/WMcD062c0ObIie0XtoCxKOraVRopv?= =?us-ascii?Q?wE+ttXqSRAqxIE=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 6:kDxK6B9hdih4Sg9zMlmqps+1AE0kbAVetGoUK1IB9avNvlx/QdQ/SeTvXVkJ9BxxamCxxOjBD4X+x7bOsP83VSrAa4yPbdJoqm2USN3zzwD+T8Dl0WrwjBY4JPtMVM9oULGfCTS9XH1oqOXAU9GotF8IijByh9cBd9a1vXRRTGfYZYALhKWh4JgWnDgQ8l5e6G2ixKz/WoHBfajVkfqJsolhAKCrjDWlqyh9EaDE+8vyjOw++6NeWYz27AAnsjtaSDUS9ez+6zE2wMcMHyp2jNhSUkVD5eEPLhHoU+zFap0o7hajGSHopU6izocer0vVdYvcu8nfL94//RiFzmOYtakrRlOOulSdRktx9jx/7Xc=; 5:K5GBI8Glo/AwaHOeCuwh55bQAxYbj+MbTvzatWY+gkgbq/yycuqDy+Namo4T7LsWUoWMQZFZklxwiJ9FAfMuy9IoVnGY6sGHaJEtWU/LLyyzi/oXqJz7eA1+FdQGo5FYedhqPrjQep5JV8B4Mwfi3m5SgWT9asMdF8ntuKnnNIU=; 24:0C7ZAtTHnsg4nzuNeozv9+aM56WEK9Q4c3jZD+rwOX3FcPbTIL/nok75qe2utXS0GiXt0EnkkxEAI0Bic/GFT9I3oFiJ8fdeInjOiQeoRck=; 7:Ct1lq5WhklssQxY6vcl1vBH8z1udNW7w2yfq9L7bHbTqEcukB+p5tdmlFhkRoDPqj7e+kNVzIVZX5PiLCimQN2W5S9bOL3vHLcBBC7mqAJTJF1+8Uu7Vj/XIahP+TgIATNJZUrEYJMydWD7lVFCLyOgu+5ru3Hg4QoQ229LKxSINdbiGzqS68eMvBqbi2oltA1Jfb3z2fAeBRU+MUUYjYTl5KcPGrcW15isBugbvG1tx8LY4ArgB3RaqnQ1beuz5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2017 08:34:49.0450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e84f32e-e87b-47cf-fcbc-08d53fa8e20e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528 Subject: Re: [dpdk-dev] [PATCH 1/8] app/eventdev: add ethernet device producer option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Dec 2017 08:34:54 -0000 -----Original Message----- > Date: Wed, 18 Oct 2017 18:09:01 +0530 > From: Pavan Nikhilesh > To: bruce.richardson@intel.com, harry.van.haaren@intel.com, > gage.eads@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, > nikhil.rao@intel.com, santosh.shukla@caviumnetworks.com, > jerin.jacob@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [PATCH 1/8] app/eventdev: add ethernet device producer option > X-Mailer: git-send-email 2.7.4 > > Add command line option --prod_type_ethdev to specify that the events > are generated by ethernet device. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-eventdev/evt_options.c | 11 +++++++++++ > app/test-eventdev/evt_options.h | 29 +++++++++++++++++++++++++++++ > app/test-eventdev/test_perf_common.c | 34 ++++++++++++++++++++-------------- > 3 files changed, 60 insertions(+), 14 deletions(-) > > @@ -272,6 +282,7 @@ evt_opts_parse_long(int opt_idx, struct evt_options *opt) > { EVT_SCHED_TYPE_LIST, evt_parse_sched_type_list}, > { EVT_FWD_LATENCY, evt_parse_fwd_latency}, > { EVT_QUEUE_PRIORITY, evt_parse_queue_priority}, > + { EVT_PROD_ETHDEV, evt_parse_prod_type}, There could be more producer type like timer or crypto in future. So, IMO, the name can be like "evt_parse_eth_prod_type" or something like similar. > }; > > for (i = 0; i < RTE_DIM(parsermap); i++) { > diff --git a/app/test-eventdev/evt_options.h b/app/test-eventdev/evt_options.h > index a9a9125..a6607e1 100644 > --- a/app/test-eventdev/evt_options.h > +++ b/app/test-eventdev/evt_options.h > @@ -58,8 +58,16 @@ > #define EVT_SCHED_TYPE_LIST ("stlist") > #define EVT_FWD_LATENCY ("fwd_latency") > #define EVT_QUEUE_PRIORITY ("queue_priority") > +#define EVT_PROD_ETHDEV ("prod_type_ethdev") > #define EVT_HELP ("help") > > +enum evt_prod_type { > + EVT_PROD_TYPE_NONE, > + EVT_PROD_TYPE_SYNT, /* Producer type Synthetic i.e. CPU. */ > + EVT_PROD_TYPE_ETH_RX_ADPTR, /* Producer type Eth Rx Adapter. */ > + EVT_PROD_TYPE_MAX, > +}; > + > struct evt_options { > #define EVT_TEST_NAME_MAX_LEN 32 > char test_name[EVT_TEST_NAME_MAX_LEN]; > @@ -76,6 +84,7 @@ struct evt_options { > uint8_t dev_id; > uint32_t fwd_latency:1; > uint32_t q_priority:1; > + enum evt_prod_type prod_type; > }; > > void evt_options_default(struct evt_options *opt); > @@ -266,4 +275,24 @@ evt_dump_sched_type_list(struct evt_options *opt) > evt_dump_end; > } > > +#define EVT_PROD_MAX_NAME_LEN 50 > +static inline void > +evt_dump_producer_type(struct evt_options *opt) > +{ > + char name[EVT_PROD_MAX_NAME_LEN]; > + > + switch (opt->prod_type) { > + default: > + case EVT_PROD_TYPE_SYNT: > + snprintf(name, EVT_PROD_MAX_NAME_LEN, > + "Synthetic producer lcores"); > + break; > + case EVT_PROD_TYPE_ETH_RX_ADPTR: > + snprintf(name, EVT_PROD_MAX_NAME_LEN, > + "Rx Adapter producers"); How about the name as "Ethdev Rx Adapter producers" > + break; > + } > + evt_dump("prod_type", "%s", name); > +} > + Other than that, it looks good to me Acked-by: Jerin Jacob > -- > 2.7.4 >