From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0071.outbound.protection.outlook.com [104.47.33.71]) by dpdk.org (Postfix) with ESMTP id 77C029FE for ; Wed, 13 Dec 2017 18:32:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q+Ymzzg22m0T+N13c50bU8yyxchtrqtcU0drPxITM3k=; b=H2gL5cRfmTQ8CkORSj77fezod7mlEyrYVeAoOfaDbalNf/rnV8I/xrua8E5iannZ4yjP02CLNWrduxTQfB1+MmkG9bzUILCWNhTdpbVLDTEcv7WDGYVo7VXIEK0/Q2BPQ7jIq8ZHeDyLkYBpXbbbHdyrRhxSejtsqPv450kCZWg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.167.65.15) by SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Wed, 13 Dec 2017 17:32:21 +0000 Date: Wed, 13 Dec 2017 23:02:04 +0530 From: Jerin Jacob To: "Ananyev, Konstantin" Cc: Shahaf Shuler , "dev@dpdk.org" , "Nicolau, Radu" , "arybchenko@solarflare.com" Message-ID: <20171213173203.GA3462@jerin> References: <20171123121419.144132-1-shahafs@mellanox.com> <2601191342CEEE43887BDE71AB9772585FAC8AEB@irsmsx105.ger.corp.intel.com> <20171213075518.GA18228@jerin> <2601191342CEEE43887BDE71AB9772585FAC9140@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAC9140@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [122.167.65.15] X-ClientProxiedBy: PN1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::18) To SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c716381-ec36-4bfe-a841-08d5424f787f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 3:7eTOSsGt09DzWNfZ7e8G4hlO3yNspa/P75o+7+JnOXYyKSSFv9QkJk3vq56cgPJaOgVULMFBgax827l475vjFlKgEoZpuO3RYFeF8eazRiHYhdi0n/yoXJSzKFWPH0rqYQs02OWNy7UFifAT82I9CN+pUtlLtTrAqBNzIDHUNwpeMqkkCSnAZaf4C8aLaZtHOkgmqqxTvCndyLzfJKN3fCzjLSdjRiwCe9DVSeFXf9gg6m3e7X9W0MypWMA82kl2; 25:rp+BKqcvKg3C5FlplA7MIxGRBrTIRT4aFNez3TEZjYtg4DLgqF/0JZtN9vzt3vXZj0fTessfKQsPWIoirIWswP41B7QRFcanHeBxTKZmWNER1HnL7N1qrFCTdVXQxplhduUTAgcflim98Fa16Kq6GCnAZUVvh+2m4YT8Ke9Nrw5ljyHk2+8OWuz3BLp6aXVj6Wd2amsMOzIxWPDbTUSG9Ivhb9q6biG1kVZ/9XN20KhCuLHM8mFY1O7sid9OZjuJtQdKXsxsi7oFIrNcPT9RmVKQgA1A+dKXJf32oU9LUebigh/Kbga4sr/NW1SrTkcuRb37KZy8S0Lv9aT79kYY0Q==; 31:K+9VOuwNIZW4w63xuqlVE/MRyBPVFE6Qtt2usJZw9kruFG+5hXIF0/fBMw7ydJv1flwmJX8v/OWTWVWsqkYIiZkhvE4uAtY3wjjcCVjmzVavdK0t2GULjf3pZwFX69/MHvBWUcVe8XUXi2L/nYfmL/0/Hcs/ey/VfJf6mSfGGvMJDAG9YRKtSFUGc0/0SUp69OkPQLvY0DBljRPyRg2U0sh5Z/i/8OTVmtahqbRkKCM= X-MS-TrafficTypeDiagnostic: SN2PR07MB2528: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 20:NSfWkdw6lXSUO1OloODfxHl+IPUArU0g9ERinjmSTrNEnFwKZmrYr8Opfg6mXC8L5RAlSc/lusmgiTqBsnCVBV3bLfu1dmub84QIBPPlrWLaW9Gt0Qd3rXbbbaUuKqFYftkCVjpEymtFgWGKuG9U4WjhrySVhZGFrjeJRfqbTC9uLlvvAp+9Hv/GSbmSlJDqxmxBIfCAayJL2rD5dm6HJpdh0Tf91HPN+97IRtSigi7h7+MdyAMF3YAKZ3WB3biAeW0fzT97rSyKLsJh9IHSWnuVGMy+thZU3+OGXDUbbVYTOv0lCOP6mwXRf6ooA4gkpnKejXZL+E7N5eytLHuVf94cWCbZuA9KHgSsOdSSERRgSmeav/BANZAN831X7ddo/UDwai/WE4JhmjmHnBcJ2FV+5V8+XUtLJrmZcr2Vrqs8LgeKqU9UaTWjYiao9fEhqcmPzzLtpp8SDFHvPD4G67a7vWGdkdn+a4Yp0ZSPbugeC8iv/jLZBwInMEcz9FZSqLLKD8sVrVbcF65e7s5wQaberva8lRPeYUM/s+e6o4j/mFg2uRjOraz+2SxPdhPQ9YIe1AACgDqeaBLmhD9WH8SILBTX2shiQrn5NAGDy7w=; 4:3jQqrmxhZI9bp7hAsUx2lh1X3Y1+ervvqQeu8YV7cSh7AhYyj7S3QUm7cQNmtuz5dC7bcEi/lFbgpvsBl7S2clsJ/986C5b2/M+izgUuzVdI7hCSBYHEn49P1oK8kQ+aP8KKycqrFY/iJvocW/HJ/O/YgzRa026W+G+ZJG/rFgifMeLN0N/gCboyiPHGcrcHFrnOYqVB2O4FVjR/Houe4cf9SBAc+oRC+m8v1P5WA3yDCeime4hy025l5QgkOGBOA27/4xExcjf8hw66aUceFYj54veFFJhgXt4Pju4X7733Xk+CWLtxz2I0JZ+42UEU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(3231023)(10201501046)(3002001)(6041248)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN2PR07MB2528; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2528; X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(13464003)(199004)(189003)(54906003)(316002)(72206003)(16586007)(66066001)(81166006)(68736007)(16526018)(2906002)(229853002)(105586002)(106356001)(7736002)(478600001)(83506002)(9686003)(386003)(2950100002)(76176011)(6916009)(42882006)(50466002)(8676002)(4326008)(59450400001)(47776003)(53936002)(6116002)(8936002)(25786009)(6496006)(5660300001)(6246003)(33896004)(23726003)(6666003)(93886005)(58126008)(52116002)(33716001)(33656002)(81156014)(305945005)(55016002)(1076002)(97736004)(3846002)(53546011)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2528; 23:KjFJszqhfyqdy9k1cQWs9NickzSjN2pvZh0Qw5+jf?= =?us-ascii?Q?78eZyGcGmaC5m0Wu8o+QftNAdcEbitQ6Gcvc49zkGcepvQc+k8hAZhCnFMH+?= =?us-ascii?Q?isMW47YIhiwrk5gwY1OT54Bv7+wFO1LxN+vukQLqDs4+reTQYzeGPtoJPgit?= =?us-ascii?Q?2LlPJ23pe6v/CCqO9XTCHwzSsQYJog/t/F8FuOVZ2DLZVi1Wug0KKgJ+yRX0?= =?us-ascii?Q?v+pwi2YLaKsui8Exbvv1K1q9Mq2ShEGEssxvznJqhV1elqJ8OaFyoj/f2GPq?= =?us-ascii?Q?bNV8ZWELVeyr8RX5RqKnajUNGgsju/BCfjbf6auAMoqyO2S/ylwB2AmvIeMG?= =?us-ascii?Q?tmj2Br5aZWXNBfY/a0Bj80z4BSTXEvCe3m1lw/JV7C85EUADiopFh873L2mJ?= =?us-ascii?Q?TDT4I2K9+kPgaUjPMZfQwXpI4KKcU3dCwx2Qd2Oy0hMQx4W3mhh/4sVdJpg7?= =?us-ascii?Q?si9d++dpld6B9brbvVI7uSNQJ/eOgIX8Q1f3D5HjlokEb+n9RzYFxv6NYqCB?= =?us-ascii?Q?Q9zKCyo//gVQoy6onwgSXd6UYI9zBEDp9RXQpK+QBm2s8xyheCYcTq4vP+9Y?= =?us-ascii?Q?eXuNdqE9eKn5NtJNhUy2EyhbllQjkCnmJGPW7iyz7/f0zLoAuNweTpOicEB7?= =?us-ascii?Q?C+/bt4rhl7TDtNP/GdqCNAheOcReAT4OW9wQpyJ7plch4u7dJHid/vl+BTGT?= =?us-ascii?Q?ORgOpzNB5+dsmeI6EpWDpI6nFsP0AItunfujse3+vxtO3vgpyRReQ/wiw7yn?= =?us-ascii?Q?B7fjMNGeCYFrNGc7u09g3OYRN7PlsNijCbDSTQgT3nFj3vA+3otCEAv1soIT?= =?us-ascii?Q?NKsVdxixjn1Dx+28EkIWRlnXplLnlNxCDAuHj4A3c9mwt2rmJqf2byd5vSa5?= =?us-ascii?Q?qgo3HSq5zFPRTMvpw/lm/9P5fHOAOcEhQTUubFjblTX4hfTZwHaZ1v2y29Xr?= =?us-ascii?Q?l7BHZRlbRQ8WVXB8dU7dAm6SP4XsP7kw4PxzmESPkVDRzzt8YuDMnJlgdp60?= =?us-ascii?Q?GwtO6ML+fx2ACr3AiSiJwLrAcJlNY/bZveZOARH+jx2g5LTJyJ3mbSH4PhSh?= =?us-ascii?Q?1feNA9p+ijz7k4iDK5zoQYfyoubJi1ef6v1HGV6ck8nvseBtHupWJY/Nrz2e?= =?us-ascii?Q?FbomhREUhcg9lN0fuFb1JeoewU2Ds3yesQn49C79mgd/o1dw+6XnINSByq37?= =?us-ascii?Q?G3sdJ+FHsIroyzPnqYBgdIcag4REcdbCAAZkMnQQUOtrPTCSHYrfybhkZEB+?= =?us-ascii?Q?Q6CuK4ZYh6xiWcv8wc7OX4P5YZf4nCMWEoQqsZA?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 6:iKz+L7eGk/nJUiL1K7ZRztPn6CZ+6pK9mJR21Mz9UxYWyz3eH5dVVURxXXSmHFNUh8OFtPFJShwSoEOVoCyNtYvTILCGeOr8f9XmmiJwdvn6XRJbRUv2yujM56xmYU5E1EfII943vdrQwJqmUk6UxdVqTxfI4aoFQrlSPUjTHmOqsDnFxRQ2dmjcW5Q0ogESmvoxDdRlo3m7HxS1/4JEE3qUhhww3Y2XCVRq/2+W+u3MSC/kS7IekOUt5fSLvG27So8vm0FUrfFY1YnPHk74rPr8o2peLO3jnsUwXZ/SuN39UPnE60RMc3WQ+KyjwePaRlDMCgFLQWe4BnJ6xX7DWHoH7qWcaUdjwLUSUMRdiEg=; 5:81oc6RJG9xTij7weongn2k0sxA25kvOL7vsKA0Pw6E9F3Lw8z7Q9tI6tGe0Ben2ZJzbGFdlH4An5FvZSoicNjI3dgqTWjZBbZlILujBH8tECenLT+y+wR3kYYy3JAYhEjuCh6oedwzUZ4NA5mFvSteZevzty9dNWgKxfFiR6kHg=; 24:3U1LlDnnuDUcNVBT+qKYz9SH7k7ZMqIYG3CQDCFwrqNmWR8BH9qyqNle9WcSxcwy8EncjDeEVYPQGkEDydRiUzBOpyQjsUtcg5tTNNlcNUo=; 7:GjDkYCbED5Zb2L8VO2RFxmGv/DecA9qS5KhXRpo8KM7lF4Hv5Rvpsz3lcNl78mOFNaog+wDXSg8hdic78CASh/CxXJUFlU8FDFq0SI931l+XPS7/biKIjotLMr2qnCJZrF/b27kL3Q+OweaBOGHPuyO8MPtMA/SUOmC6B2d5xGy7SVn6BwQkvE2WtNOW7Wn+1CcAtHnRNT9QCf+zhb2RP4EPNgW4FBYLxDewdQPeJjPuOAqg0+NWukj79mvTXtI7 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 17:32:21.4431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c716381-ec36-4bfe-a841-08d5424f787f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528 Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 17:32:25 -0000 -----Original Message----- > Date: Wed, 13 Dec 2017 12:10:26 +0000 > From: "Ananyev, Konstantin" > To: Jerin Jacob , Shahaf Shuler > > CC: "dev@dpdk.org" , "Nicolau, Radu" > , "arybchenko@solarflare.com" > > Subject: RE: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev > offloads API > > Hi Jerin, Hi Konstantin, > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, December 13, 2017 7:55 AM > > To: Shahaf Shuler > > Cc: Ananyev, Konstantin ; dev@dpdk.org; Nicolau, Radu ; > > arybchenko@solarflare.com > > Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API > > > > -----Original Message----- > > > Date: Wed, 13 Dec 2017 07:21:01 +0000 > > > From: Shahaf Shuler > > > To: "Ananyev, Konstantin" , "dev@dpdk.org" > > > , "Nicolau, Radu" , > > > "arybchenko@solarflare.com" > > > Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev > > > offloads API > > > > > > Tuesday, December 12, 2017 7:12 PM, Ananyev, Konstantin: > > > > > -----Original Message----- > > > > > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > > > > > Sent: Tuesday, December 12, 2017 12:26 PM > > > > > To: dev@dpdk.org; Ananyev, Konstantin > > > > ; > > > > > Nicolau, Radu ; arybchenko@solarflare.com > > > > > Subject: [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API > > > > > > > > > > Ethdev offloads API has changed since: > > > > > > > > > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit > > > > > cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > > > > > > > > > This commit support the new API. > > > > > > > > > > Signed-off-by: Shahaf Shuler > > > > > --- > > > > > examples/l3fwd/main.c | 40 ++++++++++++++++++++++++++++++-------- > > > > -- > > > > > 1 file changed, 30 insertions(+), 10 deletions(-) > > > > > > > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > > > > > 6229568..3bdf4d5 100644 > > > > > --- a/examples/l3fwd/main.c > > > > > +++ b/examples/l3fwd/main.c > > > > > @@ -149,11 +149,9 @@ struct lcore_params { > > > > > .mq_mode = ETH_MQ_RX_RSS, > > > > > .max_rx_pkt_len = ETHER_MAX_LEN, > > > > > .split_hdr_size = 0, > > > > > - .header_split = 0, /**< Header Split disabled */ > > > > > - .hw_ip_checksum = 1, /**< IP checksum offload enabled */ > > > > > - .hw_vlan_filter = 0, /**< VLAN filtering disabled */ > > > > > - .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ > > > > > - .hw_strip_crc = 1, /**< CRC stripped by hardware */ > > > > > + .ignore_offload_bitfield = 1, > > > > > + .offloads = (DEV_RX_OFFLOAD_CRC_STRIP | > > > > > + DEV_RX_OFFLOAD_CHECKSUM), > > > > > }, > > > > > .rx_adv_conf = { > > > > > .rss_conf = { > > > > > @@ -163,6 +161,7 @@ struct lcore_params { > > > > > }, > > > > > .txmode = { > > > > > .mq_mode = ETH_MQ_TX_NONE, > > > > > + .offloads = DEV_TX_OFFLOAD_MBUF_FAST_FREE, > > > > > > > > Hmm, does it mean a new warning for all PMDs (majority) which don't > > > > support DEV_TX_OFFLOAD_MBUF_FAST_FREE? > > > > > > Good point. > > > Unlike other offloads which are must for the application proper run, this one it only for optimizing the performance and should be set only > > if PMD supports. > > > Am continuing to aggregate reasons why the DEV_TX_OFFLOAD_MBUF_FAST_FREE should not be defined as an offload. Anyway we > > passed that... > > > > > > I will fix on v3. > > > > Removing is not an option as the PMDs rely on that flag to will have the > > impact. > > # I see DEV_TX_OFFLOAD_MBUF_FAST_FREE as hint driver to depict the application requirements > > # All the drivers by default can support DEV_TX_OFFLOAD_MBUF_FAST_FREE(They are using the hint or > > not is a different question) > > > > So, How about setting DEV_TX_OFFLOAD_MBUF_FAST_FREE in all PMD driver as > > dummy one? I think, currently, it can be moved to old API to new API > > transition function till the drivers change to new offload flag scheme. > > I don't think anyone plans to remove it right now. > If you believe your PMD does need it, that's ok by me. OK. > Though I still think it is a very limited usage for it, and I don't think > we have to make that flag supported by all PMDs. OK. I just suggested because adding the flag in PMD is harmless and we can avoid an extra check(setting the DEV_TX_OFFLOAD_MBUF_FAST_FREE only when PMD supports it) in application to hide warning as you pointed out. No strong opinion on the specifics, I am just cared only reaching the flag to driver. > Konstantin > > > > > We are planning to change nicvf driver to new offload scheme for this > > release so with this change, we have the performance impact on l3fwd > > application. > > > > I think, the other option could be to change usage/meaning of > > DEV_TX_OFFLOAD_MBUF_FAST_FREE flag where when the application needs > > multi-pool and reference count scheme then "it sets" the offload flags. > > If so, we don't need to set by default on the these applications.