From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0053.outbound.protection.outlook.com [104.47.33.53]) by dpdk.org (Postfix) with ESMTP id AC56B107A for <dev@dpdk.org>; Wed, 13 Dec 2017 18:38:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a6dXPS1xK4KzzN18hq91OZrlz8xF8RBz5JVy//LE3bo=; b=mqxDDig2t/QMGEu/4Y0KUJ2MAeq6O1RJvVHBVw/LDSmHX13OWJlDVrKp+4QZgyPZwEA+mnKIcwsiWGo+gnvl6Po9pRZSVszWxf/ZmfZjZdRS0a36Prb6+ji/vwNdb1tJnHblHUBLnS4R4yIQ2xC40yla4Sa9b4+FEps6GrtbKrg= Received: from jerin (122.167.65.15) by CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Wed, 13 Dec 2017 17:38:12 +0000 Date: Wed, 13 Dec 2017 23:07:53 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Akhil Goyal <akhil.goyal@nxp.com> Cc: "Doherty, Declan" <declan.doherty@intel.com>, Abhinandan Gujjar <abhinandan.gujjar@intel.com>, dev@dpdk.org, narender.vangati@intel.com, Nikhil Rao <nikhil.rao@intel.com>, Gage Eads <gage.eads@intel.com>, hemant.agrawal@nxp.com, nidadavolu.murthy@cavium.com, nithin.dabilpuram@cavium.com, narayanaprasad.athreya@cavium.com Message-ID: <20171213173752.GB3462@jerin> References: <1510210453-61428-1-git-send-email-abhinandan.gujjar@intel.com> <20171129114153.GA16467@jerin> <a43876e7-fa9a-4473-1b1e-24175a0fd2f2@intel.com> <20171213112606.GA5166@jerin> <b28f2e29-a4e4-0102-f609-a948c68fb7fb@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <b28f2e29-a4e4-0102-f609-a948c68fb7fb@nxp.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [122.167.65.15] X-ClientProxiedBy: BM1PR01CA0089.INDPRD01.PROD.OUTLOOK.COM (10.174.208.157) To CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3cee0359-819c-4366-5769-08d542504a9c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 3:2idTSh/cWe99pxycylGeqOqMDhT97NsWJQjt5TNGRcas7S6A8y04gL6+Kx7a9JHiXThE+ymtqthFPJ2MUX+E9UuaGihKrJKOj+RfYJlIOpXKCgCqm9qXkdXOwLk3exvUWZ6MKQ90eS5mGBodUZq6ZdRjBu65W/mNWtQ4ifx7ITdQ8JGjvDLbWCKKN6IuwzG+j7Pw4YomYafkdbatyYe7FLYRqKX4nYFzuefuardNpPfizsXWEvEg9g9om28g2mhk; 25:0q20ovI+0zfm7n2HM+fZwLFXjctQS7szafoIbKIWWeFH/7zb+UxVjkoHuatzGnynZIhk0HOq81SSDrxKqnqJuEkMom7NZWDLlNIYwxB3EV/Bo3elX6DJfQgkXghRFXKzOpfY1W7ZPMNj2ClUuNylANq5fyqW82bFktwilVXQMR71l0ZkZRgyFN2tahGPgybdyUo0JAASpG48RK648ZsmPefth+DzN5xO8B7nfjBOMToIUU+G9AVjw65S8bSxnuzmwSx2cXnd5Qwk2NCl6YrYE7dYS3OzyYaxhP+vzIwpMLiSku0RcLrMENYW6K2QnnzoYKAVxRhQtoFaFwxyHkSo7A==; 31:oF2L/juNa+Yvq7goicZCUnQBJwacG+7h8Z+dwRohSZABCuMNvR1fr55kWhNvhIFJWabDLhxOcuwUB4EEp2GF2yA4FsEeTfhLLRsTTaMhkWecivHv71rOxdF/PnYeWEZ6SxkdYyaBdabg3pTdwv60XwPNGIZHO7XP59eNVOoff/qTXJmXt5Qq+T4LdOhdT6hpJV2GcE5FgqXUQRx/lR7hW0buyfGYIb+ozaimva+B1HM= X-MS-TrafficTypeDiagnostic: CO2PR07MB2518: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 20:iWcXrh+vQO2NEyCPrEmoAr2t6ubymDYZ2CioYMJE6mRQgeRJ/vs76txmMBZVQ8Z9TM2TNapgSFkCAd1MC0OdxGXutDrXe6BBvTi5HML7YTtvn3gSb6NjF2lggCKr5jYCNnBQMYzqx5Zhv9zjUbmSLyg8JppqlGywsGQ8LKVh0VKZfNyh0pog2FqrXO7JY+Bn3r7nDq6XH5Se4r2CneeT/aGAq5fLN7E3CwqsSQ6awOOzMSEwLHvGspzn15nkUi09JTH2l+RJlHTk1lKOZVctVqaKPOPkCN3QY29OBMaRUI8bLek6hTMfSED+0AFYrO/uyNZqbbpr0TyEYo2BFYFGDtVCxvqjYsiIAqHbfuxlGBNxtELtLGM8DUazAJoaDxNjo9V/n/1WGeyEyJ/A8LQApuz9F/a/HUUbiTBh5MtgrcYkFt8nOTky2Z11NhfBrkLp9rDS6mlUed0lmtCNxiIxygvGBcy3ZElzT8Puz9wUHv/e6q8RU9EU6OUi04XiG3cNa8X4uHkDqYilXOyVrRdr6DxLTMgnL1qs8JsI706ABp3IpTLpoOP7PJSuPfclOjfaAWssFE51521DSaRCY/ZhPiCMTTvnzF1n3NKgimnSdxw= X-Microsoft-Antispam-PRVS: <CO2PR07MB2518CF71565884AAF01B3879E3350@CO2PR07MB2518.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3231023)(3002001)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011); SRVR:CO2PR07MB2518; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 4:GpkJ9MceUX+tKFsukX1QncH/ICFZaE3qgdRtId41KoGMWZdvszLPTtpaekJE2PSwSiDVYEjOeqdDYVm7pVk/hq2mEkBdvh9jXLxf8IdnpytZ7vFfmpTDvvyGrD5lFlVvSnnl5dKZogedG40erSzCzrA3zQZl7K3cUj6LtRFBp1hoFIkt5/tj1IyVqPwZ4dAuE9r1IBGFBsnq7GMh2piJO13riPHBP1J8PbeIwDyeLOZwRnrfvLx+xYneez/HP+huUOFOkLEg87X0I/NN0mjTlV6kkqHWjbEyIRHKVqWBceO2JaQ5m/bF5pIdvlCa482VI4kIfFwsQc/fTVbbXJsK+UWn/uFdsFBlWT7nsgnkh34= X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(13464003)(199004)(189003)(24454002)(55016002)(107886003)(81156014)(66066001)(97736004)(5660300001)(76176011)(47776003)(1076002)(58126008)(3846002)(52116002)(33896004)(7736002)(478600001)(72206003)(33656002)(105586002)(6246003)(6496006)(50466002)(54906003)(25786009)(16526018)(305945005)(23726003)(2906002)(2950100002)(316002)(8936002)(93886005)(81166006)(83506002)(8656006)(53936002)(6916009)(5890100001)(8676002)(4326008)(9686003)(229853002)(42882006)(6116002)(33716001)(6666003)(68736007)(106356001)(386003)(53546011)(16586007)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2518; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2518; 23:+ymwBo/3gF3nZgR7MYw2wtjlocSyC9Cwdxg/3/1rJ?= =?us-ascii?Q?pHVgCCnq1A9qQFcGeYyG22O7lEtiCoec+8dvJSoLdrwLKAPxmrJX6yLfabzd?= =?us-ascii?Q?0tIp4JrI0AxnRh5LvDccM+1DjXpOUn83NDDcjqYeEZLXcIBkox4gaqASW+8/?= =?us-ascii?Q?oOQyuyibHaeoZg81SpKJyIET2BrwbOsW7twklFgqpwV3Fz0Bz/UnNbFaPg9P?= =?us-ascii?Q?Gy479T95jl7dvhc3KK54A86Lr8aDChvJ8CyvVU570vc5bJZizx1sK4KWPiAW?= =?us-ascii?Q?wwx9i4rjvTyLFbofckWRPyPwf1zxbashdj+0mVvHciDjQ7mETOi0iiR9dBOE?= =?us-ascii?Q?AlutiJGMh1AL+ver6hZ5/Sdbjk67t3KfsDGKtGTplrVKuJvYpBMrULGgnEKa?= =?us-ascii?Q?bPWg4NJfVMNTo1lYAiB0PsvAFHG+U8nUVlUqZHL1elQhsxfPv7Opi1mP4u9p?= =?us-ascii?Q?6M2GRfoYVMrv9gpsyjFXnMT1BVTKXeifORLAjMzjEpKMwSO4cF2rzk8cE9ky?= =?us-ascii?Q?FkVKh4434V/DhwiDrUX9zc5bywYqAwwj/du9oeaEcKkM3mU0uAtO/i5XVHqg?= =?us-ascii?Q?hjHyzw+03JgSx/9lxBENW1++jGRFYyALUyM4VBDqtsdGiMvftrTKICRvC3xC?= =?us-ascii?Q?0X8UeXjz5sde0AVOltcAzfkLhegtYhiW6mKNfzrKLehYrNCQ+NlLlDL4fXMq?= =?us-ascii?Q?wNzgmMaPasiqIv4joImEnzgftzdriy9h1KNRiNPbskRdmYpe2GXm06B3VGUh?= =?us-ascii?Q?S0wfVgui86s2kbqeCp4OiSU8vY+WJt0uHj8g9c4S1FnvjGwACWoL6baNn/H2?= =?us-ascii?Q?DdtfkQJGDBqr7ApaN4jH6fDYBj21srDKHWBWmzJQb9RxAeqTrTtYTptsZ8Ow?= =?us-ascii?Q?Ou5/X06M1glCf0robN4uN7DbcyZgw/6MEFsHij5vVgXAv1BCAUY4ngf5DMPX?= =?us-ascii?Q?hIuSKCYmMu6AL6qC5ogkhESNjbxVDPrugl4ruHFktDYnwKUOwSjpmW4BZrKq?= =?us-ascii?Q?LAwvYxVYxN/75wBnbdfpL+ptaS5OodaiZj4pvkvxm05IJazKQl9EOHV0l4B+?= =?us-ascii?Q?yJVmOSb7rhlub4URN7xBVM8T/PfOvPwkzRY3ypnyiUWhtuTVb9ZDPrnwAT+N?= =?us-ascii?Q?RDBuQuqdRYtITTUCpXF3BlzVVvNADazYw1bkCv6+XVNIdASyQAk9dSlKJhD/?= =?us-ascii?Q?MDiX0MfCfc1pB7NBZObHAP4oJvQc8pzDo1d6wJ04nXgs4KUHgYVAjFepGCrk?= =?us-ascii?Q?fMkhJd6J56ymO3lbIHUKGNGL3UwEZN9MZD5FdnxK8HTBiYONbhsmEmVOL5v+?= =?us-ascii?Q?C5FcUvvzA+vRE5nKahQ1/b2EOdC4reD2llTlukO4p3M?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 6:eEId/ckHixKZMSYLhbfedbe0Kh6AGgj2G2y+/VgdtsFRqliqun0RG12m/RYrR8iCn43eqzJOaKnhULyajDH3zgT+szDPsKUOE1xTQ0y5LD/zhheOfJQONy71AuX8CTr+6zXwwu3X5ldNROMJMGuJ8p4hT24WoMRYjuOF0TVZfHTjN602tabN/L+ktwblzYrUN1h7xwa3Fg9y/nn/yt8wZe3A7RDbWnkqR8GuXJyxpJdIjjS45N+kajTeopID649WRs/LASjhKNZWV9dh2Mso94VdX4N4ezgmW/lsT1GxvCqdv0zt3tWJXRJ2U5EG8YYyK5jRkSDXITPsqilBb/ZNe6yKBgR7Q/HtkjctbfvuVco=; 5:eFW1gRw4SMdO/bbmdagBQnyRBMf6Gt1NjJOQkmwcX1kgDHpfBxtiloj8gK1l7ruQFY7wo5BZrkkiYruoR3PdTPJs1asVEHYfqLtNSqOBYlR4L/7zL4csC9kfMomsJPSs8t+GxdwXrO2hmVPrXwuBCKWEjAklAcwvDXn+avtJmg8=; 24:RvxxU+ZkmUksFvYhmedf5EBVrG4/9E0674wal8TxzsFGnSIeV02Yf1XRBsDlAM8sraF6WLO9JNYwrFWIOw/jHQtYhmHFKZp0tp76ELPnidU=; 7:+56WldnPGaZznvdy+wMPp6WgCfGeCbG6Egefg026BQ6IF/CPgYgOCA5DsDYwAlkEPl0iY7dX/vJ+cRtN3gq5zPHF7yj02ZqgkiAwwpAes4MfJhQDqzmwFX2J8QH+cWfKyDfTbI9oyvZ58zbdsbpZlL8sgw2uP+KcXhRUKrPQFwl80IAFrCpuhmlEPwqiEQIbmZ4Gg4xVk90UIn2Q3t/E0k4xexdtQNWrKq8q0MoibaJH6G2ZQkY78q13LHvKF0Eu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 17:38:12.6557 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cee0359-819c-4366-5769-08d542504a9c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2518 Subject: Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 13 Dec 2017 17:38:19 -0000 -----Original Message----- > Date: Wed, 13 Dec 2017 19:52:24 +0530 > From: Akhil Goyal <akhil.goyal@nxp.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Doherty, Declan" > <declan.doherty@intel.com> > CC: Abhinandan Gujjar <abhinandan.gujjar@intel.com>, dev@dpdk.org, > narender.vangati@intel.com, Nikhil Rao <nikhil.rao@intel.com>, Gage Eads > <gage.eads@intel.com>, hemant.agrawal@nxp.com, > nidadavolu.murthy@cavium.com, nithin.dabilpuram@cavium.com, > narayanaprasad.athreya@cavium.com > Subject: Re: [RFC] eventdev: add crypto adapter API header > User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.5.0 > > Hi Jerin, Hi Akhil, > On 12/13/2017 4:56 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Wed, 13 Dec 2017 11:03:06 +0000 > > > From: "Doherty, Declan" <declan.doherty@intel.com> > > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Abhinandan Gujjar > > > <abhinandan.gujjar@intel.com> > > > CC: dev@dpdk.org, narender.vangati@intel.com, Nikhil Rao > > > <nikhil.rao@intel.com>, Gage Eads <gage.eads@intel.com>, > > > hemant.agrawal@nxp.com, nidadavolu.murthy@cavium.com, > > > nithin.dabilpuram@cavium.com, narayanaprasad.athreya@cavium.com > > > Subject: Re: [RFC] eventdev: add crypto adapter API header > > > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > > > Thunderbird/52.5.0 > > > > > > On 29/11/2017 11:41 AM, Jerin Jacob wrote: > > > > -----Original Message----- > > > > > > ... > > > > > > > > > > > Adding Declan and Hemant. > > > > > IMO, RTE_EVENT_CRYPTO_ENQ_MULTI_EVENTQ may not be very useful > > > > from application perceptive as the scope is very limited. > > > > In real world use cases, we will be attaching destination event queue information > > > > to the session, not to the queue pair. > > > > > > > > > > > > IMO, RTE_EVENT_CRYPTO_ENQ_MBUF_MULTI_EVENTQ scheme may not very > > > > convenient for application writers as > > > > # it relies on mbuf private area memory. So it has additional memory alloc/free > > > > requirements. > > > > # additional overhead for application/PMD to write/read the event queue metadata > > > > information per packet. > > > > > > > > Since we already have meta data structure in the crypto > > > > area, How about adding the destination event queue attributes > > > > in the PMD crypto session area and for, _session less_, we can add it > > > > in rte_crypto_op stricture? This will help in: > > > > > > > > # Offloading HW specific meta data generation for event queue attributes > > > > to slow path. > > > > # From the application perspective, most likely the event queue parameters > > > > will be different for each session not per packet nor per event queue > > > > pair. > > > > > > > > > > Hey Jerin, > > > > Hey Declan, > > > > > > > > given my limited experience with eventdev, your proposed approach in general > > > makes sense to me, in that a packet flow having crypto processing done will > > > always be forwarded the same next stage event queue. So storing this state > > > in the crypto session, or crypto op in the case of sessionless ops, seems > > > sensible. > > > > > > > Something like below to share my view. Exact details may be we can work it out. > > > > > > > > > > I terms of your proposed changes below, my main concern would be introducing > > > dependencies on the eventdev library into cryptodev, as with this new crypto > > > adpater you will have a dependency on cryptodev in eventdev. > > > > I agree with your dependency concern. > > > > > > > > I think the best approach would be to support opaque metadata in both the > > > crypto op and crypto session structures, as this would allow other uses > > > cases to be supported which aren't specific to eventdev to also store > > > metadata across cryptodev processing. > > > > Make sense. Just to add, adding a pointer would be overhead. I think, we > > can reserve a few bytes as byte array and then later typecast with > > eventdev api in eventdev library. > > > > uint8_t eventdev_metadata[SOMEBYTES]; > > > > Thoughts? > I believe only 1 uint64 is sufficient. The metadata that we need here is > rte_event which is 2 uint64 and the second one is mbuf. Since mbuf is > already part of rte_crypto_sym_op, we do not need it. Yes. > > So only a pointer/uint64 is required. I would say uint64_t, as the pointer is 32bit in 32bit systems.IMO, We need have reserved metadata(uint64_t) for eventdev(not generic).