From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 74F271D90; Thu, 14 Dec 2017 15:24:34 +0100 (CET) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 88CE9114577; Thu, 14 Dec 2017 15:16:09 +0100 (CET) From: Olivier Matz To: dev@dpdk.org, Thomas Monjalon Cc: Samuel Gauthier , stable@dpdk.org Date: Thu, 14 Dec 2017 15:24:11 +0100 Message-Id: <20171214142411.25375-1-olivier.matz@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 14:24:34 -0000 From: Samuel Gauthier The 'install-sdk' target creates an invalid symlink in the install directory: # make install-sdk DESTDIR=/tmp/toto V=1 [...] ln -snf $(/root/dpdk.org/buildtools/relpath.sh /tmp/toto/usr/local/lib \ /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/) \ /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/lib [...] # ls -l /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc drwxr-xr-x 2 root root 4096 Dec 11 11:49 app lrwxrwxrwx 1 root root 21 Dec 11 11:49 include -> ../../../include/dpdk lrwxrwxrwx 1 root root 12 Dec 11 11:49 lib -> ../../../lib # BAD LINK This happens because the directory is not created. Moreover, it makes sense for install-sdk to install the libs, which could be necessary to build something against dpdk. After the patch, the link is correct and the *.a libs are properly installed: # ls -l /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc drwxr-xr-x 2 root root 4096 Dec 11 11:53 app lrwxrwxrwx 1 root root 21 Dec 11 11:53 include -> ../../../include/dpdk lrwxrwxrwx 1 root root 12 Dec 11 11:53 lib -> ../../../lib # ls -l /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/lib/ -rw-r--r-- 1 root root 1378 Dec 8 14:08 libdpdk.a -rw-r--r-- 1 root root 123380 Dec 8 14:02 librte_acl.a -rw-r--r-- 1 root root 3406 Dec 8 14:02 librte_bitratestats.a [...] Fixes: 6efca1e9f873 ("mk: split install rule") Cc: stable@dpdk.org Signed-off-by: Samuel Gauthier Signed-off-by: Olivier Matz --- mk/rte.sdkinstall.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 4e97feff9..338fb4971 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -157,6 +157,8 @@ install-sdk: $(Q)cp -a $O/.config $(DESTDIR)$(targetdir) $(Q)cp -a $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include) + $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir)) + $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir) $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib) install-doc: -- 2.11.0