DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 3/5] ethdev: remove (redundant) parenthesis
Date: Thu, 14 Dec 2017 15:32:19 -0800	[thread overview]
Message-ID: <20171214233221.30928-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20171214233221.30928-1-stephen@networkplumber.org>

Obvious extra parenthesis do not help readability

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ether/rte_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 318af2869743..c53b28bf80fd 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -810,7 +810,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
 	 * Convert between the offloads API to enable PMDs to support
 	 * only one of them.
 	 */
-	if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) {
+	if (dev_conf->rxmode.ignore_offload_bitfield == 0) {
 		rte_eth_convert_rx_offload_bitfield(
 				&dev_conf->rxmode, &local_conf.rxmode.offloads);
 	} else {
@@ -2693,7 +2693,7 @@ rte_eth_dev_uc_hash_table_set(uint16_t port_id, struct ether_addr *addr,
 
 	index = get_hash_mac_addr_index(port_id, addr);
 	/* Check if it's already there, and do nothing */
-	if ((index >= 0) && (on))
+	if ((index >= 0) && on)
 		return 0;
 
 	if (index < 0) {
-- 
2.11.0

  parent reply	other threads:[~2017-12-14 23:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 23:32 [dpdk-dev] [PATCH 0/5] remove double parenthesis Stephen Hemminger
2017-12-14 23:32 ` [dpdk-dev] [PATCH 1/5] bnx2x: remove (redundant) parenthesis Stephen Hemminger
2017-12-14 23:32 ` [dpdk-dev] [PATCH 2/5] kni: " Stephen Hemminger
2017-12-14 23:32 ` Stephen Hemminger [this message]
2017-12-14 23:32 ` [dpdk-dev] [PATCH 4/5] distributor: remove (unnecessary) parenthesis Stephen Hemminger
2017-12-14 23:32 ` [dpdk-dev] [PATCH 5/5] loadbalancer: " Stephen Hemminger
2018-01-05 21:09 ` [dpdk-dev] [PATCH 0/5] remove double parenthesis Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214233221.30928-4-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).