From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9FBD7271 for ; Fri, 15 Dec 2017 12:58:21 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2017 03:58:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,404,1508828400"; d="scan'208";a="12078650" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by FMSMGA003.fm.intel.com with SMTP; 15 Dec 2017 03:58:18 -0800 Received: by (sSMTP sendmail emulation); Fri, 15 Dec 2017 11:58:17 +0000 Date: Fri, 15 Dec 2017 11:58:17 +0000 From: Bruce Richardson To: Radu Nicolau Cc: dev@dpdk.org, ferruh.yigit@intel.com, pascal.mazon@6wind.com Message-ID: <20171215115816.GA12540@bricha3-MOBL3.ger.corp.intel.com> References: <1513337677-29923-1-git-send-email-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513337677-29923-1-git-send-email-radu.nicolau@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 11:58:22 -0000 On Fri, Dec 15, 2017 at 11:34:37AM +0000, Radu Nicolau wrote: > Functions like nl_recev and nl_send name clash functions in the > libnl library (https://www.infradead.org/~tgr/libnl/). > All functions declared in tap_netlink.h were decorated with tap_ > for consistency. > > Signed-off-by: Radu Nicolau > --- If these are publicly accessible functions should they not have an "rte_" prefix?