From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 61C17271 for ; Mon, 18 Dec 2017 19:28:38 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id w7so9480367pgv.6 for ; Mon, 18 Dec 2017 10:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yi8mgo7QRz8FimG8Bqx6ySEyUNO/txFxEnMREunrvU4=; b=v1ieEXjM7YRpwey0jx6MJ0S+LKa29QML7OJubJwXyVlfBnz71rT6DO8fxRrdpmYr5o Ej4J050o5M+Xvq2T9VpRrs5WwADAs9rrZjstZcM5pOdX66mxm5ZHY4tdJscBN8LfzJI2 eU4OjvF+iELlDF57O3Ks0DR9xg8QFaL6l6ZRhkjOShCRagcaek6XAAWN6IYzPbOkO60c 2IiDgs4LNwVaChYFgHmzx2ju8hPv8d8G+PaisU+xhhnArGh/E4seJh6IL7caLnXNngSj CDzZn5qo/BYDzBD47gcCy5aMKdWqW2GCnTAtYJ0nrafQkK9WU3qGZTjCUlR1FrEvTpo0 qOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yi8mgo7QRz8FimG8Bqx6ySEyUNO/txFxEnMREunrvU4=; b=pm3z/DqIJmubKxsOqUUdcgg1ztcdhWeK6DLeHT9LcbKSWKK2Kljnpdp19kcwHsGqmy k3O03jXH4/HasSWyDCKacIAwTLwVO1Gg+abmUHcDZbIPLxkc2S4A0Pq52N3YG6Sa5vTV +6p+sti1spjSsyaJm6vM/P4OaNyU7wi4XWZF0hG19Ms66Bs35bLLMI+0jhJqGI6KBK7t ZxrLHiPpdIBl2dWeYxd4kmJJ+pTGJUE8TyLVOafdH4qILEtljTwNbEgJyGIP0lIk7Cwd TUJPnn9DVtSvA8yYMHz8ldCydBZe1UQ7piODHm/AF7RZE33lk/m4MuNoIc5YyGgOmNW2 jd2A== X-Gm-Message-State: AKGB3mIrxKihoSwC6JwypJUaPF7v1jtykAH8Qwg0D5NMprfzVAASsKV4 2p9qpN4bndi2bFqjouRLqhuI8g== X-Google-Smtp-Source: ACJfBosIXwxwaRIN5LeGFcJF/k7GPmlKLnT511ssV/fTWHO3p2WzYHSVuECQ983Y3Z0Gs//mjS0LYw== X-Received: by 10.98.242.67 with SMTP id y3mr596438pfl.82.1513621717401; Mon, 18 Dec 2017 10:28:37 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id p72sm28117022pfa.84.2017.12.18.10.28.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 10:28:37 -0800 (PST) Date: Mon, 18 Dec 2017 10:28:35 -0800 From: Stephen Hemminger To: Adrien Mazarguil Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20171218102835.7602545f@xeon-e3> In-Reply-To: <20171218162443.12971-2-adrien.mazarguil@6wind.com> References: <20171124172132.GW4062@6wind.com> <20171218162443.12971-1-adrien.mazarguil@6wind.com> <20171218162443.12971-2-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 18:28:38 -0000 On Mon, 18 Dec 2017 17:46:21 +0100 Adrien Mazarguil wrote: > +#ifdef RTE_LIBRTE_HYPERV_DEBUG > + > +#define PMD_DRV_LOG(level, ...) \ > + RTE_LOG(level, PMD, \ > + RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > + strrchr("/" __FILE__, '/') + 1, \ > + __LINE__, \ > + __func__, \ > + RTE_FMT_TAIL(__VA_ARGS__,))) > + > +#else /* RTE_LIBRTE_HYPERV_DEBUG */ > + > +#define PMD_DRV_LOG(level, ...) \ > + RTE_LOG(level, PMD, \ > + RTE_FMT(RTE_STR(HYPERV_DRIVER) ": " \ > + RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > + RTE_FMT_TAIL(__VA_ARGS__,))) > + > +#endif /* RTE_LIBRTE_HYPERV_DEBUG */ > + > +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__) > +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__) > +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__) > +#define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__) > + Please don't use DEBUG() etc macros. It makes it easier for tools that do global updates or scans if all drivers use the same model of PMD_DRV_LOG