From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 33EC4E5D for ; Mon, 18 Dec 2017 16:52:21 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 07:52:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,422,1508828400"; d="scan'208";a="159790505" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by orsmga004.jf.intel.com with SMTP; 18 Dec 2017 07:52:18 -0800 Received: by (sSMTP sendmail emulation); Mon, 18 Dec 2017 15:52:18 +0000 Date: Mon, 18 Dec 2017 15:52:17 +0000 From: Bruce Richardson To: Hemant Agrawal Cc: dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org Message-ID: <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com> References: <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com> <1513600744-13749-1-git-send-email-hemant.agrawal@nxp.com> <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 15:52:22 -0000 On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > GNUmakefile | 29 +---------------------------- > Makefile | 29 +---------------------------- > 2 files changed, 2 insertions(+), 56 deletions(-) > > diff --git a/GNUmakefile b/GNUmakefile > index 45b7fbb..2ff3e4b 100644 > --- a/GNUmakefile > +++ b/GNUmakefile > @@ -1,33 +1,6 @@ > -# BSD LICENSE > +# SPDX-License-Identifier: BSD-3-Clause > # > # Copyright(c) 2010-2015 Intel Corporation. All rights reserved. Actually, minor comment, can we remove the blank line between the SPDX identifier and the copyright? Given that in the majority of cases, we will only have one line each, having a space between them is a) probably unnecessary, and b) looks weird IMHO. I'm currently working on a patchset to update the meson.build files, and I think having: # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation looks better as a header than two one-line paragraphs. /Bruce