From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0083.outbound.protection.outlook.com [104.47.34.83]) by dpdk.org (Postfix) with ESMTP id 8C039E5D for ; Tue, 19 Dec 2017 09:48:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hsWN9WHo7HAmLwSPXTRzZ29pjfeRI5m0rylmzycDmGU=; b=J+q1yXlNJ6eG4rQ6PYTCeQiFOHispy+g9tgwGU2+22I7n5WYN1YzmA1CiWi5TLQTcisBpBvMYRqv0BrJepscjZIvxcthHuO2tP7sHQ8ke8rDkNGAyLPYGptYy8wfJhawWclGtwvB7dfTVq+vVyL17mxWPLbyBK4K/TicarGjUkA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Tue, 19 Dec 2017 08:48:02 +0000 Date: Tue, 19 Dec 2017 14:17:43 +0530 From: Jerin Jacob To: "Eads, Gage" Cc: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" , "hemant.agrawal@nxp.com" , "Doherty, Declan" , "nidadavolu.murthy@cavium.com" , "nithin.dabilpuram@cavium.com" , "narayanaprasad.athreya@cavium.com" Message-ID: <20171219084742.GB19364@jerin> References: <1510210453-61428-1-git-send-email-abhinandan.gujjar@intel.com> <20171129114153.GA16467@jerin> <9184057F7FC11744A2107296B6B8EB1E2BB1B296@FMSMSX108.amr.corp.intel.com> <20171214024910.GA10018@jerin> <9184057F7FC11744A2107296B6B8EB1E2BB1B9FF@FMSMSX108.amr.corp.intel.com> <20171218063012.GA12857@jerin> <9184057F7FC11744A2107296B6B8EB1E2BB29E9A@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E2BB29E9A@FMSMSX108.amr.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0038.INDPRD01.PROD.OUTLOOK.COM (10.174.214.24) To CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25e49323-caa3-46f9-3755-08d546bd38d8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 3:EnD9MytqAz/EkJE+J35IHrr5XPROaYd7+5kkMRexduZQ9oZYC4GhB1/NJhM/aefhSAFx9D+ugMEj7v8UAB0RzNHlA7GjPyEFUZfI30UDGVmso5tqaV/tMgPJle0UNNhNmKB6LsIiYhIoS8W3HUQzZLwa7Z8m1wbB2P7jFCM2tuy3WAoqp70CprfOpXsSDJbUHF9mEFBkMBLvvZ1YdPn6ZPAYx9hgLu3mElBDcQxJkNGyanYyzXQAc/W+eCrFbhRY; 25:JfsgA2y/8B+A0JEvwwImGcfQK1RmuHOS7b6ej5WKuQqcICk0SrONwt3qMTbx66nD2DxTpcb0kmvRVsPV9YDY1g2FMSGLbi4tH4vz0vaJoe0P9DkjkJQmuG0sk0MDWhfCNr6HnbcEdUrEZmDDrh69Nhb6rHVAYF6E3DUJa76h3YTqze/fpZT4INM+cHxFnpQEQ4CzmjMXLUhFG3vaL1xwVm7Lk8nlo3IRXaBA6yDQqNUnYLFGNosxDO5DmQeKvRfycAa4kJJ/FY1WmF8/TOUt96TBskwqHIQ0jTsmxG4bqVoGi0Ys4UyPkMRab6cnS/Wz1nu8Bo27pLTMwZ1lvLOSSw==; 31:P2LdGqaBlO+vLChXCaBQdTZK7HARvqRZKxsHccHsX/zYAmJSizjwNoUJmjouSbDeDEBMFMJhfYFQ0gFDW5c45FGs3+mUf/XklavnJLyWsf8HyP9qyvPYEak2MbqM4NlOmjw9h6ANtprDvpmlVLx17T4jbBpd52QA/xYxLl3C4zLXieVi2izIT/P7/vhqmt4RV63htOhTFSnBxAFop7qOFoH8/Iq/XVLgYFfp+6yGwEs= X-MS-TrafficTypeDiagnostic: CO2PR07MB2520: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 20:FQM0016W6xSKPEPsyaIAjgVFZnAMJFv8QnmLr9lMJEFBlAkQ0xZCM7NW29FbET4dMqOik4TT1Cyz4Dc+wykPQ02cknwoj57FdFvZCQVgV2p6LWSXX+NUV018O5rApBq9pbrNmpiV1oNRvTTfiLWot5Cej03PcEgpGf8NE1HXvSJnFGnDhIoEsTxmVyM4g5EMG7K+IDwKnViC//k/XYrez0VKN6P8kjXPp32YtXfxzz3XQaZ7iDZs8CAHT1j5tBWiCRvutdBFSm6P/ED67humFMjiAcEqcchVTIXxU1x1pyI1lbJfUBJAX1+3qMbmeCV3C+hBBbrUFpCLgX/fa70cI/+a39owXNvjxUyE+1tUaCiijHMKvw9LLK5r5ZpuabfPQIchpNsCL1wVAaTyA6O9j8Qqy0ta6H3547HxP5I2yPrnc+6ALyPqHRNscz5FoLbxPtzjQdN8WHR/0P6xdKRnXHTNeXQSOjQ6V3Zr5AwdrO5Hi/VAu9SAJiDyDFI7U6ghwaFG584kUhJi3NNJJGuXfP5yrDn7VI4mTZ1sG8jAFvXv5hCWIcPad0SRrg6WWU1TPmnVv2C1sb6yUnic5YDF3Lg+xk+S4IrhT+oZcLSkSq0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(3231023)(10201501046)(93006095)(6041248)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(201708071742011); SRVR:CO2PR07MB2520; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 4:vjUdVOWfu2+jjYbNdyqe1czz9gV2DYW7waPmijpyKGjkxbsh2+vcxg4ElheeVcu3RU9aF39oCjnNEb/LOOXKvVYuO2+u9xvOTxtslAjiz3zKCC06GNf+PWaX9UXZlAXrbqh2RtryA+tBbcn3mgNcPBB8cNPe6nueApi6pDoUa5fYe/8Dyvjdb3SNtewHO8HIqj8UXV+tb8NDKC31B4dZhBXw5g4QhoQaQ5yBJE3l/JEraZB+yGqPD1cUktE2gUbqwnBwHVBj/R0sB5eG2J6Zomg2fr6BtAVG28TauDP3Z4ptRcKVNrua4ewKLzIMniPby+wtQIoQUvO8qNksVbOuhzwNmD1Vm89zeodOuB7lKQM= X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(396003)(199004)(189003)(13464003)(93886005)(107886003)(6246003)(106356001)(478600001)(53936002)(81166006)(97736004)(76176011)(81156014)(53376002)(54906003)(66066001)(7736002)(83506002)(6916009)(6496006)(2906002)(8676002)(50466002)(33896004)(52116002)(105586002)(6116002)(72206003)(55016002)(6306002)(2950100002)(8656006)(16586007)(3846002)(5660300001)(305945005)(68736007)(58126008)(47776003)(316002)(5009440100003)(386003)(59450400001)(4326008)(16526018)(23726003)(1076002)(8936002)(9686003)(33656002)(53546011)(25786009)(42882006)(6666003)(229853002)(33716001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2520; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2520; 23:zFA0Ua4Tx3eqYg1beDxngT3xwvZQx1FHrGe2gk/Yu?= =?us-ascii?Q?/xMXV6HRuN5vUTx85rozq7T62EwqL1Di9Ju0TbDAMQcOrgSrLT6mPB4eexyp?= =?us-ascii?Q?eLzTIu2ZBmyTvCtqy37utxaxCPkotGkeRmBFf2CffBnOJYzQqNmUsYXLoBVl?= =?us-ascii?Q?dECd3ZrnfOhijFWrr1SNrB2q8Ok9z/a5VE/UvOmUbzxSmjTSocoC3d2q6M3x?= =?us-ascii?Q?1Odj3xxHjgX2KshSf+GLBVLljjViHNJHRkJjN6R6J+b9pHKesSUTApR0CSPQ?= =?us-ascii?Q?lSlwI+jEEJE/tOflqGeoErh2fxmSkjCDgSGcn4haO1T6c/C3KeEdGj2r2Pxx?= =?us-ascii?Q?elvT3wCmyH7VEMTQLD6nE4aeCxHeL17vLMZWf2xuJEfJ2+r+nFSrj1Exr6VE?= =?us-ascii?Q?hHtzBsOlkzlxQcTd317IXYxz8CzpcjXDSgBHAX7OlWELzxf8c8/kCvwDBy+p?= =?us-ascii?Q?LACxhgHhFK+8LoNBjMRYMbi8ov5EeWrWb8rYSgz9Ps4Rj7XuMy9gSXcwVeDs?= =?us-ascii?Q?yv+KGQSN1mx7qILGhjPPZYBQJxMedrypdnRGpc9+d6/aR9cAXv3sZuUyLrzU?= =?us-ascii?Q?9dNZRO3KOeHGf3BvYa5kFdyTShTV0fTo4mQ+63QfNgkx+OY3fGHBTfmXrfHN?= =?us-ascii?Q?j060d7KQj0kUxezxuvxZxeHqmVX8E/u6UoS04zdv+uWFZZLEPTlSl88nLBdt?= =?us-ascii?Q?W5pHSZI9lEmTSQQ0oFc8+6oOnyOLYFAoRmfr7HiD+Z8sZZ6lx7lp9qMwwGlu?= =?us-ascii?Q?aOvqD/iQpWuMNjImNmjcyb/IHKwc5QPTFuLwxLb9aL0b4ytJCqXPUxFRseNf?= =?us-ascii?Q?CeJJsox11UKD9kSrbIa3nrRURaXLEMeLhpBJl0jRXCYMmT8lFAVCdUKf0s1v?= =?us-ascii?Q?BD0VjJWmbURP023afmXsfdbJcqGuu1ZmYb1kKSFBSeNv6Fp6KdkeWX89f3rK?= =?us-ascii?Q?95enkkb6w0Fi1k2jk7Mh9PNkOaClELyNwCTicX5TlonHmUG58HngYqpF13JO?= =?us-ascii?Q?qqmDu9lS0hX5tfS6pZ7GWOHpiafa/7/qCFF4z32rCz/0yWtIPCy/bw7rQWzh?= =?us-ascii?Q?+7k5H+v3T3H36sk8Xl6e+yeWKMUaSghlOjAT6OyG4G3yUQCEVkN35NKLegBt?= =?us-ascii?Q?Fxyf5F0pUZCHvAEPWtgjxJgDOPZVTAxTleGwOOYexTm2YYrgLA/hOC9OQl4i?= =?us-ascii?Q?rxZudV+ZhUCsZ0iLgsRguqyL/FlvOUQPp5/QX6MksjrIR/1yFh875M4qVAtq?= =?us-ascii?Q?x0wn1LmVx4OLF+n/ifzs9HkMEcx5/WTwTfdJ8v5RJT4GGyXbotdmC+kTESli?= =?us-ascii?Q?WDRHJe+RnxO2Ot9ZlFMoIzzLSbUEmKXwiMp/tRpmf7n53uzEV3HnBz3QFDhh?= =?us-ascii?Q?4+/4IyU6uyPDV1ynkykRa8O1szimI/hkg8jiMgI4AiUH1D/E04nCmriq/CiB?= =?us-ascii?Q?DCzpxDYAw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 6:OYgd8D8dajwcGE3J42mpPTCSf63XAQbldHAF2mgR0ZrzfCv7BkZlmgZCnA4B466yjypkNtnvPNiML2eF/fmLEHXkc1UrYKUlIssqW5OeH6kOSu4ZhXx7Ec8Av7+eQTx3vZCyjpAr2WV57b4duWcKiFuSusRMluR7+pz5BQyHHMNwePH5H3ZWdVWGJsYduNmG8z5XGhiJ6m0I8bCqTgeCWXujFqXIywkzq//ROHDSxiGq30+sVE1hHvylBflC6+A4hs6kemZuhwU8sGFmsOy4j6gW7SUjyIKDs3xepYAmL+N/KO4f/EsqSk9C+Sorwbq8byL815rCtDEcI3Uy7IQ4wWOLWnmSptqL1XT4mWKHamg=; 5:vj1tx8VYIrkNCMROsf8CT6n/vaTrbkCWL4xQGOUlFUaeRlByVM4+VqxcelaAvUsWhvdK5MAwjPUu4hnJjlaUGu6MirGslxNMP3BuHP0mMKqK3B7PNtH8l1/yRHTESql68XXzRyyG9wqdAYOi333z+cHolTiRQIvoZ0v0+9wYHxY=; 24:dbNo3K4XX7JebQRpMLuqUwXasLd26AR9bHEFkY3nqZQKe5qafBtBKqrrA0iK+RSPXG6JNrtbiUNxIaRDOxNdpccZsqlZFd3jYYTATs5W57M=; 7:6ydxM8ZnbvWh3XmuJuUStW6OMNtyjegjvJF80OZk4X7uT2jdAG2TC9RrJa5eNiPi+vARDCOvAI/CSK+6ELmJoJFWKq1cPhJJEzTu1KEBp9pSiqMsrCcyl0H/QRLbwd+77TlCCCBq9K8VylzF+H3RKjjI6KPqabdtdlb5s9yhuVTPAbeV+NailUlSkgQNIxvWSbZZtL7hWuPTdaukTM7DstSaZ8tAtxNv+U3qTqY2WkbYZ5VrTzMN9CDSMWxPBhc0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 08:48:02.8459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25e49323-caa3-46f9-3755-08d546bd38d8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2520 Subject: Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 08:48:10 -0000 -----Original Message----- > Date: Mon, 18 Dec 2017 16:33:53 +0000 > From: "Eads, Gage" > To: Jerin Jacob > CC: "Gujjar, Abhinandan S" , "dev@dpdk.org" > , "Vangati, Narender" , "Rao, > Nikhil" , "hemant.agrawal@nxp.com" > , "Doherty, Declan" , > "nidadavolu.murthy@cavium.com" , > "nithin.dabilpuram@cavium.com" , > "narayanaprasad.athreya@cavium.com" > Subject: RE: [RFC] eventdev: add crypto adapter API header > > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Monday, December 18, 2017 12:30 AM > > To: Eads, Gage > > Cc: Gujjar, Abhinandan S ; dev@dpdk.org; > > Vangati, Narender ; Rao, Nikhil > > ; hemant.agrawal@nxp.com; Doherty, Declan > > ; nidadavolu.murthy@cavium.com; > > nithin.dabilpuram@cavium.com; narayanaprasad.athreya@cavium.com > > Subject: Re: [RFC] eventdev: add crypto adapter API header > > > > -----Original Message----- > > > Date: Thu, 14 Dec 2017 18:52:02 +0000 > > > From: "Eads, Gage" > > > To: Jerin Jacob > > > CC: "Gujjar, Abhinandan S" , "dev@dpdk.org" > > > , "Vangati, Narender" , > > > "Rao, Nikhil" , "hemant.agrawal@nxp.com" > > > , "Doherty, Declan" > > > , "nidadavolu.murthy@cavium.com" > > > , "nithin.dabilpuram@cavium.com" > > > , "narayanaprasad.athreya@cavium.com" > > > > > > Subject: RE: [RFC] eventdev: add crypto adapter API header > > > > > > > > > > > > > -----Original Message----- > > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > > > Sent: Wednesday, December 13, 2017 8:49 PM > > > > To: Eads, Gage > > > > Cc: Gujjar, Abhinandan S ; > > > > dev@dpdk.org; Vangati, Narender ; Rao, > > > > Nikhil ; hemant.agrawal@nxp.com; Doherty, > > > > Declan ; nidadavolu.murthy@cavium.com; > > > > nithin.dabilpuram@cavium.com; narayanaprasad.athreya@cavium.com > > > > Subject: Re: [RFC] eventdev: add crypto adapter API header > > > > > > > > -----Original Message----- > > > > > Date: Wed, 13 Dec 2017 23:35:48 +0000 > > > > > From: "Eads, Gage" > > > > > To: Jerin Jacob , "Gujjar, Abhinandan > > S" > > > > > > > > > > CC: "dev@dpdk.org" , "Vangati, Narender" > > > > > , "Rao, Nikhil" > > > > > , "hemant.agrawal@nxp.com" > > , "Doherty, Declan" > > > > > , "nidadavolu.murthy@cavium.com" > > > > > , "nithin.dabilpuram@cavium.com" > > > > > , > > "narayanaprasad.athreya@cavium.com" > > > > > > > > > > Subject: RE: [RFC] eventdev: add crypto adapter API header > > > > > > > > > > Hey Jerin, > > > > > > > > Hey Gage, > > > > > > > > > > > > > > > > > > > > > > > > > > + > > > > > > > + /** > > > > > > > + * @warning > > > > > > > + * @b EXPERIMENTAL: this enum may change without prior notice > > > > > > > + * > > > > > > > + * Crypto event adapter type > > > > > > > + */ > > > > > > > +enum rte_event_crypto_adapter_type { > > > > > > > + RTE_EVENT_CRYPTO_ADAPTER_RX_ONLY = 1, > > > > > > > + /**< Start only Rx part of crypto adapter. > > > > > > > + * Packets dequeued from cryptodev are new to eventdev and > > > > > > > + * events will be treated as RTE_EVENT_OP_NEW */ > > > > > > > + RTE_EVENT_CRYPTO_ADAPTER_RX_TX, > > > > > > > + /**< Start both Rx & Tx part of crypto adapter. > > > > > > > + * Packet's event context will be retained and > > > > > > > + * event will be treated as RTE_EVENT_OP_FORWARD */ }; > > > > > > > > > > > > How about leveraging ev.op based schematics as mentioned above? > > > > > > > > > > That could work, but perhaps the ev.op should be configured once > > > > > up front, as > > > > I see it being a function of the application architecture. A couple > > > > possible designs, for example: > > > > > - Worker enqueues into cryptodev, adapter polls for response: the > > > > > adapter > > > > port would always use OP_NEW here. > > > > > - Worker sends a crypto request event to the adapter, which gives > > > > > the request to the cryptodev and polls for response: the adapter > > > > > port would always use OP_FWD here. (This ties in with my implicit > > > > > release patch > > > > > (http://dpdk.org/ml/archives/dev/2017-December/083535.html)) > > > > > - Etc. > > > > > > > > Yes. Semantically both approaches will work. I was trying to avoid > > > > extra clutter(enum rte_event_crypto_adapter_type) in adapter API. > > > > I don't see any problem in moving ev.op to adapter configuration > > > > time if it helps the SW driver. > > > > > > > > IMO, We can change RTE_EVENT_CRYPTO_ADAPTER_RX_ONLY and > > > > RTE_EVENT_CRYPTO_ADAPTER_RX_TX to more appropriate name, > > something > > > > like, > > RTE_EVENT_CRYPTO_ADAPTER_TYPE_OP_NEW/RTE_EVENT_CRYPTO_ADAPTE > > > > R_TYPE_OP_FWD > > > > or something like that. > > > > > > > > > > I agree that the two naming schemes are equivalent, but since this option > > would control the adapter's behavior (Rx only vs. Rx + Tx), (IMO) I think > > Abhinandan's original names do a better job of conveying what effect these two > > options have on the adapter, compared to the op type names. > > > > The only concern with Rx/Tx terminology was, It is mostly used in the ethdev > > domain. > > In crypto domain, typically, we use enqueue/dequeue. > > The only difference between two modes is if adapter enqueue the events with > > RTE_EVENT_OP_NEW vs RTE_EVENT_OP_FORWARD then (IMO) we can change > > something related to that name to avoid adding a new terminology. > > > > Oh, sure -- enqueue/dequeue makes sense here. I'd still prefer DEQ_ONLY or DEQ_ENQ, but the event_op names work just as well. I prefer event_op name but enqueue/dequeue name work as well. > > Speaking of the crypto domain, the cryptodev enqueue and dequeue operations both take crypto op pointers. The original RFC had the request event pointing to an mbuf (which had a crypto_op pointer in its private metadata), but with the suggested opaque eventdev metadata changes it makes more sense for the request event to point to a crypto op. And the RFC didn't specify what the response event would point to (mbuf or crypto op), but to match the cryptodev dequeue operation then a crypto op makes sense. Will this work with your hardware? Yes. crypto op will work with Cavium HW. NXP guys can comment on their HW. We are treating rte_event.event_ptr as opaque event pointer so it can carry crypto_op or mbuf pointer.I think, For crypto operation, rte_crypto_op make sense as it has "status" etc. May be for inline ipsec, mbuf would make sense. So I think, we can support both options by reserving size of struct rte_event as eventdev metadata in crypto area. > > > BTW, Based on the earlier discussion, if we need to add opaque eventdev > > metadata to cryptodev then it may change ABI.If so, I think, we need to > > announce ABI change notice for cryptodev and plan cryptodev adapter for > > v18.05. > > Personally I'd prefer to get this right/agreed-upon the first time around -- even if that means breaking ABI and pushing this adapter out to 18.05. I agree and that makes sense too.