From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0045.outbound.protection.outlook.com [104.47.38.45]) by dpdk.org (Postfix) with ESMTP id AC705160 for ; Tue, 19 Dec 2017 19:45:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hNOSELyT+c+7RLMVDIVylR69kj1398lmLQ54OLrggDk=; b=KUGoMgF3pL5DxSXMm9D7ULO69Dixiwdw5bgOAwwgN3+xkLjaVoiiV5wxiFV7sajhG+pHHkOiKZfw31+eP8+aU2urXPKMLA0swQ3SnatrBLHQNMjuBFrWgAC/xWH0rvg6DJNyNxA91cNw975+PrwAO4LIgtSE+7kL650/RdLdioY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 18:45:11 +0000 Date: Wed, 20 Dec 2017 00:14:48 +0530 From: Pavan Nikhilesh To: "Van Haaren, Harry" , "jerin.jacob@caviumnetworks.com" Cc: dev@dpdk.org Message-ID: <20171219184447.3jsibeino6t5mjd7@Pavan-LT> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-11-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR0401CA0004.apcprd04.prod.outlook.com (10.170.128.142) To CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad217744-1840-4bde-6555-08d54710a338 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153053); SRVR:CY4PR07MB3462; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 3:grBniNqM7m7ISRuTYc9E3tgu5oJeeV/j/s0AT01mowmqj/euvxkx9kvniKC903DLKa2Oo7/3zx73Dy9ZCzBxyHz9tPzbNbNz9X9K3A9PkjJqZWppENRG4NiLZrKNzzavZwA/mwGAEEJyup549Gho1OFYw6YA3RwGSZvv164bjZZ9iUT8uLF43oQ3OI+LRKXAkVHs/DI8VzoGuNXf7IOdS6KVpbIFsPse83U0eDoMdTKXbjKdg/QrZ6ho0nDDIIua; 25:7yK755WQNeJHHUJWSGUSzsKxbNraJ35z83l84H30R9+2WLPziUkWE9psiZz3302wEpD8MCcmbaLTTLd73cg7lj7tFHK8/JNUliv/SCZ4+x90vUYX+YCQeMWaNqA5Evky251Nnz94xbRsM4TpOMOjQqu1UqDLXMOv6DmBLe6QqsguE1I2puD0v3ubAHgPIIPx7tb4Bu9+VBpnCa3cCImfqolImo4KMlQG3mnpGa5+myZdelkQmFz6k+C2kgcY4flGX0I5mCsYFpUjzrJ5kBSJr3gF5k5E9y7uUm2bv6l+qvQm3gMGSJJEGhi9AWSbyofrrgWJ83BxwvnqaYmwqIGflg==; 31:MWDBuv9weicj62fUzRLh270keMyGPnI6XSepQYGOaOzBFa/cUQ/bCyBeoF2yPZyDIaN5FXbXx5SaDJkJMh39nv81JhsgMX3XZv84Um80VCQpXmk19DRAaZaKaYwlQ6Ah75n6QrunXMvx3Jwa7MEIchoBnjWMp3zwUlTxxOC9TG0Q0gpZjSR25w1lr3fX5TVnFIkr4fAvzPoLAKsvKjWL9cRxqfz/lEqngZCxVOlpAI0= X-MS-TrafficTypeDiagnostic: CY4PR07MB3462: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 20:zXeFdtWvX9q6pNEb0XA7Zyj9dF515UMOPsZmhWOkYoc8kgOk2blQ1awbMHtxsFMjxII+Zpfzl6pN7RAbTE2ICPJiREcMIVoZccPWZwdh4+j6C81ii/KExz8lUZrGxYStS4Jh9vSi0a4Nh8D36x3TlGYj7ykUsWqneirNyA1ZjGQK7VKb7kWkskHN1SZ0cJMfhU67nz2gmPOVaQzqhGiW5n09M/oqwE9KFBm+q7CZ05yraOCOeHy2Uclmu9ZFl0ahB7Uk/wNc9fkUR2FNE0Uc4vyeGKEh2QStFg7vS0a33UAxEOSiUUQ9PlI+ah8w/hroXInXa0C0hgi6nRbNqls+9gYg7zby+kQzgP0FxivIg/9My67ID2g+HIIc9YXsycKzFazl93rLn2D56G6zKonorfdzmL8DO1pqJw5UFcN2jve00/RZjgseqfLQmUnNdPpAYslO3NMiRNVO2s2gEcvHqoLXzl+W+PlhBDhutryMip3y0f57ljBgCqs7CBju5DB6qjZaLCgMhjAt/emU1zY2qmgA3K8tK844e9DXAvjZuFaE2H5nbB6NSXoCMi+gc7C8rJ9SJRNL5kDjoYzQusOP42RfOltgqkGoJZkUqMRK3dE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(3231023)(10201501046)(93006095)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011); SRVR:CY4PR07MB3462; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR07MB3462; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 4:PS81+bu67juJDrkxmXcchssq5LPz1202N0SfStbFCsDa3ZS6FMVyV5kSZE2sq4Q/a0KZohP9d6cNSlHtLViyULKaAVuGJe1Xlf+S7TAAwOm7WV6T595/7Lz1pXhMnk+RTnC3naCJZupbv0ND4lO/h1vwBiiI8zRde0UOLD+pNal3D/er117iGaXyFQwP6FwDAapKnQxCNbIhFb0cQtkX3ys5qxhFPv4ORNxBaQRwIiKFFqk+0Uf7hAV49G8gEiTvuutyKH4Fp1ocCFsTK+pQtoMmKVIB1+40Z9xVhjPt3Dokfi9tttK6sCgc/OCU2QcKsd4GvK/6GlyuEj5FSPlmil+cBFoMSvdj8XqfBo31hH0= X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(39860400002)(366004)(189003)(199004)(51914003)(24454002)(97736004)(53936002)(4326008)(52116002)(81156014)(16526018)(229853002)(478600001)(305945005)(6636002)(72206003)(6666003)(2950100002)(1076002)(42882006)(25786009)(105586002)(5660300001)(55016002)(9686003)(23726003)(47776003)(33716001)(3846002)(6116002)(50466002)(106356001)(93886005)(33896004)(5009440100003)(53546011)(386003)(68736007)(58126008)(66066001)(6496006)(2501003)(110136005)(8676002)(16586007)(81166006)(316002)(6246003)(83506002)(7736002)(8936002)(2906002)(76176011)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3462; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3462; 23:C/Hg7Eb87sIqi7M8+TM1sH1P69nrfXBldi8ymgxD7?= =?us-ascii?Q?+yTXCnXLvvutdJrNXsgLPgZzoscCIu6YbxLTTYipuXChSd6snEL6SkFkFD0V?= =?us-ascii?Q?Mjwd7fW3+CmW6FeS69Ygpt4RJz1XQjvpwEqs2UBR5ueqQ6SpNgmbL2sKlNw+?= =?us-ascii?Q?aOipQheWf0HewE5YLWd11zcq6yaz6vITp/6jGppRQ1klozcX6Gl1lWnKQHhg?= =?us-ascii?Q?JCJ3oFM62o00MHHuchdQWsByYH8ubVU2H6MrYBwka+cHGST2epZpwHXNHLkH?= =?us-ascii?Q?kzORnT3tH4jgoOuOs1lEOTazEtiyyfiRpFwUU5ZwMBY4o1SXZ5j3ZZs+5iUE?= =?us-ascii?Q?OhdZXTgqQ8Z/g8QjIIKc94Gunpk00roe8dcApA8pwbYxILyRiFyeuN1gg+8h?= =?us-ascii?Q?tnER5Y3UcVJEE7ZzwbbP1V4UVNhF9GR59282WC0YUTtYrpxwW0ZicRl9WioI?= =?us-ascii?Q?P5yI0s8NJ2/GfXAvG1di6aW9sv9IXIhqdxyjYpZC9pf8qEnAhpvIXCiHM1BL?= =?us-ascii?Q?euUsoAzkPCCs60LjNgss1gZFZatDSXLJhrct6yoDsTfULGv0mIv77ObM/iiO?= =?us-ascii?Q?cf1g31xNB6N911YGnJrWVoe314OZO34K17HgqsXlDexs24TLRm5vYXHUHY4e?= =?us-ascii?Q?Ng1akB9wZ6/e/9L3BFBL7wQ8hjV0Q3FaKt7UUVXfZACdlIyib6Vz30uI14Rm?= =?us-ascii?Q?AOf+WnNnbfI3tvZ5hrdjYL3uOSaGeaT5DwHMOuuT8nXixKsVyECpNjsQoeiK?= =?us-ascii?Q?sNKrJ+aBMto1W765/7ZnzCGoJKvhqCi5M4CyO49NnIVKe/6Xf+3BtqQh6XhX?= =?us-ascii?Q?SgljIYPp8NJfSD1i7FCOrKUlkR1rJ4tauvVu11Q2K3navF46Wm9kAQEmrQg9?= =?us-ascii?Q?4vVtIN9Q2sLEIQK1bGZOu/Bc6Fd9KiMNOvdJ+gRRPuUAcSw0y+K0zT/hP0ul?= =?us-ascii?Q?8gaXapB6dkbPTxZo+JSMOatZSpYijyn3IZz5t/a/qYW3CMa3uAnhxKJ7ulfC?= =?us-ascii?Q?LDqEJxSZ21krhtXxpXlA6mC0PRtmaC3EPmg5J28puknSD0DZIMkoatPCgSav?= =?us-ascii?Q?OxiKr7uoIkDwvfojM+2uAWtlAZ4I0Kti1eL25aXsSpd3uGvhLL5W8IMIM0iA?= =?us-ascii?Q?bHaP724JgK9Tdvydhrti0/XKlHjxNPYaALkjMvpaviDJw7fCDnUD5k4qhcun?= =?us-ascii?Q?gxrGaislhbnBqg20p2xAiBLudAw6v0tOkK49o6IYLeh4mmunzVN4ff+RW7B4?= =?us-ascii?Q?h1rsRaqL68ZWgj/QeVKQaj2ssxPN7ANcC6jiOJEbzu5TKrb1Y3YtkrgFY+Ky?= =?us-ascii?Q?cByz+BdzfcUltaOMOFjehtxxO57mTbluWREwdZvLdyjL9TIJ9QbC+HaG+2uO?= =?us-ascii?Q?jpnUw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 6:9WrM7F/+JF5Jt0NQE7kmdcfwA4Uct8kmD2q4FX886gR4W5/JAw6Ko6ie7mp5UgubU7WWBGzMkSgB1Eool/bRRTA3OtuxlENqkvKWcf3TdY6/DJBqHzp+SZk61v92SyTgQfMCIGgrW01V0TuTUuBTR4+8831oE12+rrJJfVyvVYeefI5qpIcjsy8xZYDQL3rsZ7LfBWAsOmYKo7pdpLUOJpEBvjCHgMn0EeRsv+tIXBz4+pKXW9qSDAt2O7n+O/GNNXDztfg6oCHTPk0wNxAgi2cDQD+459uK8T+wRDeV/kySpBYSRsGUt4DCM/IYzPKPKFK8mRwtof/vp4mlZMtBK38U/DCse8clPr5uJvPUpQ0=; 5:+1E/bvUt18wf8MQiYuiFUMrirbtSHDlOl17ozr2ZhGxvIH9ttmkSwlsnTZ8Q5A4Rjwcw18ZtKWYoq6EH/Xsa6eEcREz7DnjquIO/HMlfigYte/6FB919xNBsOQldxIDrr1vMwmDONo5/LUfasiRR5OVq+v+RLzb7LMT1CmQMngs=; 24:kxfk7uRjH1DthQHYjWi/gQlhXPkzFL+kxmw6AUd2sC75IOULbLu5gVoifGj/wcuzyrB2PcmhA5VwYa1GDvRG2X8lrh2z4Iima0fwPJf9Yf4=; 7:NyIfHY9eFLqcSJlI1MjDdo9wF2qR2urrBe2ROtXBc6mmihT2n8MjcHgEW2yFdpsFaifvoBvTakoX+GYFj30G0jpxrOdZ5Bid2PREdTA3tpAJFErNb6PADPqzfmA42Rwuasu9reMVipR8d0Yft6Zui8nKCx6To+NBsC6TS57duI05iJ1Mkbk6ehMKHHB6kAxYFkUrW03l/U47JqVfDx9iWhBCU4Cd95F8E3e44bjuH5T+lObPnChy+akRzmJrNMUC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 18:45:11.2005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad217744-1840-4bde-6555-08d54710a338 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3462 Subject: Re: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 18:45:14 -0000 Hi Harry, Thanks for the review, comments below. On Tue, Dec 19, 2017 at 03:27:25PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Thursday, December 14, 2017 3:02 PM > > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; > > Richardson, Bruce ; Van Haaren, Harry > > ; Eads, Gage ; > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > > > [Side note: we shouldn't put everybody on CC all the time..] > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest > > > > Signed-off-by: Pavan Nikhilesh > > > > diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c > > index 1ed2a1ddd..b86efab01 100644 > > --- a/test/test/test_eventdev.c > > +++ b/test/test/test_eventdev.c > > @@ -1009,4 +1009,11 @@ test_eventdev_common(void) > > return unit_test_suite_runner(&eventdev_common_testsuite); > > } > > > > +static int > > +test_eventdev_selftest(void) > > +{ > > + return rte_event_dev_selftest(TEST_DEV_ID); > > +} > > + > > REGISTER_TEST_COMMAND(eventdev_common_autotest, test_eventdev_common); > > +REGISTER_TEST_COMMAND(eventdev_selftest, test_eventdev_selftest); > > > Currently when running the test app, we don't pass any arguments. Running the "eventdev_sw_autotest" command, it will create the required event_sw0 PMD vdev, and launch the tests then. > > Given the selftest is PMD agnostic, does it makes sense to have a single string "sw" or "octeontx" to run the tests against? Right now it requires that we pass ./app/test --vdev event_sw0 which I think is a burden, particularly when automating this with the meson test infrastructure down the line. > > Summary; Please add a string parameter that indicates the PMD to run the self-test on. > We can't pass extra parameter while running test (it will only accept test name). So, I will register pmd specific test test_eventdev_sw/octeontx which will create the eventdev and call the selftest API. Also, I have mistakenly changed the name from event_sw0 to event_sw do you want me to revert it? or retain the change. Cheers, Pavan.