From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0079.outbound.protection.outlook.com [104.47.32.79]) by dpdk.org (Postfix) with ESMTP id 142081B1C2 for ; Tue, 19 Dec 2017 20:05:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hq8bd9fIM7EcJHlOrqdeOm7RwmJqbFWDoUII9NgniXk=; b=ljYEhz+NrSh3WrISq4ih2IBg2oxbFQYEL9sk5heN3GaWXP40wiKUcYKVI7g5zQjZZvm700JnQWkIh35suZDdKsoi1wvGGLZjJQB1omR68iZi9CUHIiNvuIwcjE6Za6EDKIbD+2EG8cnmzr6oHkjTzwaFq4Tc4F7w7zhVKlCC9Jc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 19:05:44 +0000 Date: Wed, 20 Dec 2017 00:35:22 +0530 From: Pavan Nikhilesh To: "Van Haaren, Harry" , "Eads, Gage" , "jerin.jacobkollanukkaran@cavium.com" Cc: dev@dpdk.org Message-ID: <20171219190521.rterdmrm2nhy5mpk@Pavan-LT> References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-10-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR06CA0119.apcprd06.prod.outlook.com (10.175.207.149) To DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de62a94b-f228-4e1d-6ab9-08d54713825d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307)(7153057); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:JQJnVgCG6fZ55u2bTo2W2UfgyiE2z/dQdfe1733IYJpmZxP0r4qaLZl75SaY5gtjayD1h9L4ScYo5/p5XF3GzhjCgCNJZ6sSjgocL5gf4HDLWhHsrF1bLijyQPhC1HjjBkfOMAzlOm6WQcwygM6E6o7wXNWF9Z6RLT4BHYjQZtMS/LAllHL9mjk4AIighAZpsTfZF2ePpa/2stF2YAwdG14xzxBpYDLfIpj3F1Eq8Htz7yiI0VhXmcBgWqephiSm; 25:i3ekxvImsTOJMzv7/+rk5wBtfwERxCWxjGVoM9jEFl2e52ErXcBXNhAib/mz+D2ljUttCUvX4p9J4RLTTGzK+5dY7ExYFBVt62BIG2gbfoFti3jOiK2xRwmYEyhhXj9HdWoqDgXJBevj3yZvwNKw13KMkYxdCmYWDEGg0KRb9Y6WImAsfuo8ewfrbNzDseT2VZkebvtBYL+O/LF8gMoYKPhHha9kZanxvaecG/S6/lwAu5nsJyPe+RC2T8aUV2AgsvOzdrSl6ZiYhWXbxfzDHrEH1Tar9p8rK7zcsPepKeKphGaC49OBDaxBqaA/PJHT/rZRLs6mwEz99ry6q2lPtg==; 31:XVqRDw0PYDmmb+XDN1ZBQxxcGQjx9soR6GXNeSc7JTLuFcxs+2Ue2qQnrqW16OtDUO8rWyAdCCJ7N7C7TCzwULCy7p2yWPJumRhQgYKGc3bFwuCrsXz3TsV1mwTLuev0j86SWG4S8wQZqJvqp/f3VAeBCwGDgK289KVQoqICjvhEDhRqNPYZrogRoNwRX5kB61m8XGn8UnRJpWvtME1i4GjvyWDW0M/8zzKB40t4mmA= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:Z7aUsNBghtx/Sj7f6BL/0hR2QoY36kb3I2io9TpnEsOx9LlPhyriTja8F64MjSeWj91ZPWlYO3qKgrtytHtw6KFKz5F84qj2kI4ZyE3wrIR7nGMPeudJsqOnG96tKoTQ+0LGmRS9sFD2cMHOapRaZzhI9JiwLTgVkxhX2gTM34WXIKoQlsd9Dyw9iuNGwCLBZNnlte+zLvrswMoMYUVHnlgqizXawAsN2RLFMeJIuiyH8Yx831Ox5YL8AFTPSXBdICDjZUNGhmiKR22HfowQufOQTdoMnZhp0+fk5RUK2gGouzVTUmVXAaXjSAfO91n1+DctJGezPUt92ygvItxjHOuDrDCqPMfOt9+I3/9pjyyFYFrHh6DLFPM+F7H3T55IMIgh8pVGH5l7QluKdRm2AX1RqNPBNTqx2oVDpLS29zSWF+z4DxqKbQCOMMtBCRzHDHns2yJX49mAf9tJiHm47OsFX4IYUZqScj71BhDenuyU9Mdbw5jOZouUHbHQbuKPxIyfjKLZSJGBTVUUH5aEBLc2tgr+WNgDKhhf6R2wIf4Ry5dkRji5Wh/+IR0x33t2cl/XzxQhDiQ33hxrAPAFyN1++rEaAqJH6guPpzhx7y4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3231023)(3002001)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 4:HyLujqnNHbpVx82I1bg4PM62ldHgPF1pm2U0KShD10ccO8ywhr0FN32xFIYnEX4bH4VSRnW852APWTYq2MrIz3enNCM1WX4gfm1SlGsH5Qvg+Gs5b4Q4osjF2zhQfmIxZSaH8Xg7uO7ZS23jFVMdwJ++8j9tcfT2q39/czhDxHtd1uoeJrdcJzQ7c+NIQPSQqgcBRqi6Z+/lmDu7IoeCGSpml6K9sQqBGFJgbZdBL5rhXk61CGJ2ErdHBpCQ2vpY0SGEweVLXPu9clRszKkYuggDhTQQOEWL3cHLJRqwek/nCZx3ADDxHBMxwofc4h+KU2biITr6bzBcfV0eLT5rcA== X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(396003)(346002)(24454002)(199004)(189003)(386003)(229853002)(478600001)(53546011)(47776003)(72206003)(66066001)(2906002)(16526018)(9686003)(55016002)(110136005)(8936002)(6666003)(16586007)(81166006)(81156014)(8676002)(58126008)(97736004)(316002)(106356001)(305945005)(23726003)(7736002)(105586002)(25786009)(2950100002)(6246003)(50466002)(42882006)(83506002)(3846002)(76176011)(6496006)(1076002)(6116002)(2501003)(52116002)(33896004)(33716001)(53936002)(68736007)(5009440100003)(5660300001)(4326008)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3465; 23:w+uBAwaWhMWgJKsH/rxypwcujAetPZN8kFBKPYsZj?= =?us-ascii?Q?/o4d+ce7znlZO+9IBN8x5m5LnDaQ7NoZzswmeOyHImC0mB5vYgbS7JRjUdXl?= =?us-ascii?Q?961G5YjfI4TLeR4i6nUBHbJb4hOUJE3NEEXmWrynVXYjyXSdaNGSajxaoFtT?= =?us-ascii?Q?af+nkfmA7Yu8GpcQktxvwV0W0u4PNWHk2kqPr1zph9ATs9rzopnj7UWZWpOc?= =?us-ascii?Q?4oDmbYN2udqgXQrLwZR/Y5aDRZAO7fS1OUByTWMwtmnlzXwkfFcHQT2RrwSz?= =?us-ascii?Q?70oFfTaIsEbHR3F56Gq5zbGOpODfbkxkCJTO2molmrlZnHBAA97crRQYvqqd?= =?us-ascii?Q?+WAbmi9mnb5U4HdlD7K1Ohnsv+YbXaDmN4vaaDxt+PG3iYCjO7W4GF68vtwx?= =?us-ascii?Q?LogwiAJujHyRHKrmeP1Q3heKbFWrarMjtRIoGku3Z+/NaBVLgzWok6XneZNn?= =?us-ascii?Q?E/I/Xwm2T6B6jyfbcWTTKBr+yD7sEmMtaeGijpNU9Ugk9XZVvmdBuT1IvEtR?= =?us-ascii?Q?ZIlTd1/A6GQEOeR87ju25DjTIoTCw55L4HXb4GDLa5R6uKxZRzDr48IjOh8J?= =?us-ascii?Q?bn8IsUyMdfDgYVQnxA6fo0V8pMYlo9EmFIkrchAIulUB/5i6+WYNDGYZPVab?= =?us-ascii?Q?81EA3zp76gSgWry0WXcTgH8uZDACMY7C98hf6ESdfd4/burDSG8Y1soaa5k4?= =?us-ascii?Q?23iBEtWRgt7+bhVZOJID/uTL5LgPBHgwpoqkWMBawfnl+tEqvXPWswmYkcCI?= =?us-ascii?Q?fjl7c310TZfWJKaEjSppuub18TMgdb/xfprRi1wbI0HQ2IcN6flLH/eIUXfY?= =?us-ascii?Q?PaYp166RcgoVMKA7kcuUwSclRD7OV0FtOGB19Uvll5WwC6lRXY0k/IKH3/IX?= =?us-ascii?Q?nXxEcFRBGqtraZenYE1CTuKmjBBmAnlP6I7El8KhESmWWde8JlN1ItlN/OCq?= =?us-ascii?Q?RtN6BdpWYbIKHFJRG6b0z/62dKeJQTpKjTMT5NzcQXYnv6YH5iwOed2g9jDH?= =?us-ascii?Q?kjV/UW81IXIodux0M6dbue0hpHq1zbhj16pTtYFZsoBg7EA+rXt4kwoMfmQc?= =?us-ascii?Q?b60zVwD4y3Thj2clWFN2P9ZdROT2HUduOfcIcoI4MEctUbRXjNq3LlZ0bV9K?= =?us-ascii?Q?KCG28q0q1MIVPeXYKqEzXh5gVPov+b7v5rxzxyysuGXprAOqC9iyYgJU6RVP?= =?us-ascii?Q?PFKQiptICBX9XNAd/SmIA2y+qJNJEG54JZGH6U4nmXbDjpqKzxnE2JmMQ6Sf?= =?us-ascii?Q?dbgtqEpNpo8FqcbCqIPMVxWLi8MJu3e8m7E5wX9KSqIlGYeMBzldB3ELWfyb?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:i/QKP1RIGl+7ulwUiyTgA7BYkPQZJ13VhUHRjG28I7M4XB3hVLwOLv+jT+ybuVo4pxfY29VwneN1x6E/HSWbksQ83Oxz9zBhJy2Cp/pCNtvlwour5+LWX0CdWGh3FXcgYMI6ilSSVpfoXlX9Vc6RPeQQDizntmOvCuuairryAHwM+QZYvidmKbOoaUZAsgWbkmyhtN++d7n35jKdwjDyejQMnKhSzfLx7ex4fh5nv4pKbPoJnS8ZI2D8gkc/DzyqH6dJF1GbVPfM/nPxD95XbeXOdkO3guAxU8Hk5OSTOB328REuZ+uEgFEWguRbF2BumFYa6LyFSsXHrQu6rb7UYrCXiqWP9WZE+i22jdZ960Q=; 5:LIF7djrFpl7W+svOVHNIWAKd2hlWAgWL9EKwtJryTc4NrBc4SCEcj/nXHVq4CTr1typvT3tIsP2mCYdovgTYCMMqsdyGWLG09Bqt8UVwMyrePDe7oiGcgkHCivluId4DxVBBcnNelQTDRl4Sr5Gw4C4c5dJfhfcHe6/xDUnthYM=; 24:XTjMQRoYd4ZLQ8nf8ksCvXUlvogEeHdXDmbrivur+zEIoMsl40O6mb/aKlC0+N8y6FIAnKvwyDM1vcVHgBmf1mPvUmk+o26uSs9IFMrDj0g=; 7:ckZvFJbRns8nFwnsK1WT7iHYrg4+CQurcp9c8BxYL8gNqLAi5qdloV9HhE7PwJT/T30z2t9I2kmLlRNZuiKQLDXCIa/uPCoz3rw3/3eyU96rjzaSCxpCqe3AGUKbZNPCECNJpe1Vr3SuAsDItLdOdRzlK2ko2lfLQNOlx7NnmQWWpBD1uyoIbkYDoN6l3FAIJk7LXCVcBF2O1/GS20XQ0zCtSFd3dZHRHl2IgNDSHiYpT9+06shmMRr3jOcYvES1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 19:05:44.2091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de62a94b-f228-4e1d-6ab9-08d54713825d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: Re: [dpdk-dev] [PATCH 09/13] examples/eventdev: add all type queue option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 19:05:48 -0000 On Tue, Dec 19, 2017 at 01:18:45PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Thursday, December 7, 2017 8:37 PM > > To: Eads, Gage ; jerin.jacobkollanukkaran@cavium.com; > > Van Haaren, Harry ; Rao, Nikhil > > ; hemant.agrawal@nxp.com; Ma, Liang J > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH 09/13] examples/eventdev: add all type queue option > > > > Added configurable option to make queue type as all type queues i.e. > > RTE_EVENT_QUEUE_CFG_ALL_TYPES based on event dev capability > > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES. > > > > This can be enabled by supplying '-a' as a cmdline argument. > > > > Signed-off-by: Pavan Nikhilesh > > > > > @@ -494,9 +608,15 @@ opt_check(void) > > void > > set_worker_tx_setup_data(struct setup_data *caps, bool burst) > > { > > - if (burst) > > + uint8_t atq = cdata.all_type_queues ? 1 : 0; > > + > > + if (burst && atq) > > + caps->worker_loop = worker_do_tx_burst_atq; > > + if (burst && !atq) > > caps->worker_loop = worker_do_tx_burst; > > - if (!burst) > > + if (!burst && atq) > > + caps->worker_loop = worker_do_tx_atq; > > + if (!burst && !atq) > > caps->worker_loop = worker_do_tx; > > This doesn't scale - we can't keep &&-ing in new options. Refactoring and calling a function per burst / non-burst suggested, perhaps something like: > > if(burst) > caps->worker_loop = get_worker_loop_burst(atq); > else > caps->worker_loop = get_worker_loop_single(atq); > Agreed, will refactor worker selection logic. Cheers, Pavan.