From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 380C11B00F for ; Wed, 20 Dec 2017 11:23:57 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2017 02:23:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,431,1508828400"; d="scan'208";a="17563087" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by orsmga001.jf.intel.com with SMTP; 20 Dec 2017 02:23:54 -0800 Received: by (sSMTP sendmail emulation); Wed, 20 Dec 2017 10:23:54 +0000 Date: Wed, 20 Dec 2017 10:23:53 +0000 From: Bruce Richardson To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20171220102353.GA14728@bricha3-MOBL3.ger.corp.intel.com> References: <1513598038-148115-1-git-send-email-harry.van.haaren@intel.com> <1513598038-148115-3-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513598038-148115-3-git-send-email-harry.van.haaren@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 2/2] meson: add tests app to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 10:23:58 -0000 On Mon, Dec 18, 2017 at 11:53:58AM +0000, Harry van Haaren wrote: > This patch enables the test/test app to be built. It also adds > the test binary to be a meson-test, which allows the meson test > infrastructure to be used to run tests. > > Tests are listed using the same test binary, however each test > sets a different DPDK_TEST environment variable. The string contents > of this DPDK_TEST env var is entered in the command line interface. > As such, the familiar test names such as "ring_perf_autotest" etc > are valid tests to run using this meson test infrastructure. > > Note that the tests are run serially, given that we cannot run > multiple primary processes at a time. As each test must initialize > EAL this takes some time depending on the number of hugepages. > In future, we could improve this to run multiple tests from one > EAL init, but it is out of scope for this patchset. > > Finally, an option to build the tests is added to the meson build > options. When disabled, the unit test code in test/test is not > compiled. The default is set to 'true'. To disable, run: > > $ meson configure -Dtests=false > > Signed-off-by: Harry van Haaren > --- > meson.build | 1 + > meson_options.txt | 2 + > test/meson.build | 32 +++++++ > test/test/meson.build | 248 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 283 insertions(+) > create mode 100644 test/meson.build > create mode 100644 test/test/meson.build > > diff --git a/meson.build b/meson.build > index 04eea72..9132594 100644 > --- a/meson.build > +++ b/meson.build > @@ -60,6 +60,7 @@ subdir('drivers') > # build binaries and installable tools > subdir('usertools') > subdir('app') > +subdir('test') > > # build any examples explicitly requested - useful for developers > if get_option('examples') != '' > diff --git a/meson_options.txt b/meson_options.txt > index f2558fe..1a674aa 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -18,3 +18,5 @@ option('per_library_versions', type: 'boolean', value: true, > description: 'true: each lib gets its own version number, false: DPDK version used for each lib') > option('use_hpet', type: 'boolean', value: false, > description: 'use HPET timer in EAL') > +option('tests', type: 'boolean', value: true, > + description: 'build unit tests') > diff --git a/test/meson.build b/test/meson.build > new file mode 100644 > index 0000000..4250eb7 > --- /dev/null > +++ b/test/meson.build > @@ -0,0 +1,32 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2017 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > +subdir('test') Can you do a V2 of this set with the SPDX tag in place of the license text. Otherwise, the set looks good enough to me. /Bruce