DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	dev@dpdk.org, Didier Pallard <didier.pallard@6wind.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix incorrect cast of void *
Date: Wed, 27 Dec 2017 22:38:42 +0800	[thread overview]
Message-ID: <20171227143842.GI8818@yliu-mob> (raw)
In-Reply-To: <c341541e-1609-5ea4-642f-f0e576104b94@redhat.com>

On Thu, Dec 14, 2017 at 03:49:32PM +0100, Maxime Coquelin wrote:
> 
> 
> On 12/14/2017 03:33 PM, Olivier Matz wrote:
> >From: Didier Pallard <didier.pallard@6wind.com>
> >
> >The rx_queues and tx_queues fields of the data structure points to a struct
> >virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error.
> >
> >It does not trigger any bug because pointer is not dereferenced inside the
> >function, but it can become a bug if this code is copy/pasted and vq is
> >dereferenced.
> >
> >Fixes: 01ad44fd374f ("net/virtio: split Rx/Tx queue")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> >Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >---
> >  drivers/net/virtio/virtio_ethdev.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> >index c0ba83b06..b398f9960 100644
> >--- a/drivers/net/virtio/virtio_ethdev.c
> >+++ b/drivers/net/virtio/virtio_ethdev.c
> >@@ -893,7 +893,7 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
> >  		/* Note: limit checked in rte_eth_xstats_names() */
> >  		for (i = 0; i < dev->data->nb_rx_queues; i++) {
> >-			struct virtqueue *rxvq = dev->data->rx_queues[i];
> >+			struct virtnet_rx *rxvq = dev->data->rx_queues[i];
> >  			if (rxvq == NULL)
> >  				continue;
> >  			for (t = 0; t < VIRTIO_NB_RXQ_XSTATS; t++) {
> >@@ -906,7 +906,7 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
> >  		}
> >  		for (i = 0; i < dev->data->nb_tx_queues; i++) {
> >-			struct virtqueue *txvq = dev->data->tx_queues[i];
> >+			struct virtnet_tx *txvq = dev->data->tx_queues[i];
> >  			if (txvq == NULL)
> >  				continue;
> >  			for (t = 0; t < VIRTIO_NB_TXQ_XSTATS; t++) {
> >
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu

      reply	other threads:[~2017-12-27 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 14:33 Olivier Matz
2017-12-14 14:49 ` Maxime Coquelin
2017-12-27 14:38   ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171227143842.GI8818@yliu-mob \
    --to=yliu@fridaylinux.org \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).