From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 82DE11B014 for ; Wed, 3 Jan 2018 02:27:51 +0100 (CET) Received: by mail-pl0-f66.google.com with SMTP id 1so221222plv.0 for ; Tue, 02 Jan 2018 17:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qWBhT/vQ187CK/tYbLBff54AJ3xgtlIS7LmCXoBHfLM=; b=u4ptUrRhxZGg8YwmNKN+Nq6yTeyaY38hG7Q8+lhuhGJuHPevPxLt/9nJEOVHvDd7z4 aBEZ24WJkf1gdw5rG+RFT2SDI+hM/9ejxZMsbxcsFlvPgveVr17GCsaKL2xSWb8LnHTV ou0b7o0ZASYILxEaOrAaS29sUOXFVBVfXc7OznQ3xZCoHviYZ/58+eI0AkT21kkKrG5o 1LsaTmpCT2Khi636qyY0Qg5Zptfyw2TVibqBYd0+vJX+Wd6iLvbQi2XAhgA5YoMwLseD PBTmdGhCoYBTVW+dKljN3BTMYSlKUMbHthtR9yFKS+sXg+yj0Om7WB5XhUzb0DZpB7XO 8mlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qWBhT/vQ187CK/tYbLBff54AJ3xgtlIS7LmCXoBHfLM=; b=jQ5h9cslmtAPzUitEu47CZhyqNZsJJC9hmDyrtN313/wJhCI+Ia5aAwaoh7cBqY63k Szx7+fW8mSNM5UHgox0TmhsN7G3Nb5gkBNOkjCNTUnWz5ZG+SPgpUfJY5Tq/oeTJtGF+ dl1UqRArLT7AlhaGi3VuKL5vSCNrueo3hfi2apOqrPNvNiqzlOL8MOGJjZpBe2WdIvk2 +mn1dX7acTg5wdCsrFd84NC9KcL9UTBbQ5FGERucqut1IaErpdb2EtRGoB2AU6O8uRXU BxbRLl7U9qGwLTty3EOPvoE7AGr8Kh5s7ES0zT1Ck5Oc7dKW3+BKlGTM8tDVLZDhWsWD HQ/Q== X-Gm-Message-State: AKGB3mJ33sbcCrSCLZF18uXP/OWTxIIcw8FQm/gtL0zzQPYuAJDMMtmv n1E5S8w0cMzjhN4j7NwXnnitLw== X-Google-Smtp-Source: ACJfBos5WgLOX+/ZzB4olSIiKHCqUdat5k/aXkxiEyuDQYOamt+w2ztz0KXowdw8fEnBIBjM5PKGyw== X-Received: by 10.159.235.135 with SMTP id f7mr242363plr.228.1514942870631; Tue, 02 Jan 2018 17:27:50 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id k130sm94816976pfc.100.2018.01.02.17.27.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 17:27:50 -0800 (PST) Date: Tue, 2 Jan 2018 17:27:48 -0800 From: Stephen Hemminger To: "Tan, Jianfeng" Cc: "Richardson, Bruce" , "Hu, Jiayu" , "dev@dpdk.org" , "Chen, Junjie J" , "Ananyev, Konstantin" , "Yigit, Ferruh" , "Yao, Lei A" Message-ID: <20180102172748.311bed66@xeon-e3> In-Reply-To: References: <1513219779-100115-1-git-send-email-jiayu.hu@intel.com> <1513927544-97241-1-git-send-email-jiayu.hu@intel.com> <1513927544-97241-2-git-send-email-jiayu.hu@intel.com> <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 01:27:51 -0000 On Wed, 3 Jan 2018 01:07:37 +0000 "Tan, Jianfeng" wrote: > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Tuesday, January 2, 2018 7:26 PM > > To: Hu, Jiayu > > Cc: dev@dpdk.org; Tan, Jianfeng; Chen, Junjie J; Ananyev, Konstantin; > > stephen@networkplumber.org; Yigit, Ferruh; Yao, Lei A > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup > > > > On Fri, Dec 22, 2017 at 03:25:43PM +0800, Jiayu Hu wrote: > > > - Remove needless check and variants > > > - For better understanding, update the programmer guide and rename > > > internal functions and variants > > > - For supporting tunneled gro, move common internal functions from > > > gro_tcp4.c to gro_tcp4.h > > > - Comply RFC 6864 to process the IPv4 ID field > > > > > > Signed-off-by: Jiayu Hu > > > --- > > > .../prog_guide/generic_receive_offload_lib.rst | 246 ++++++++------- > > > doc/guides/prog_guide/img/gro-key-algorithm.png | Bin 0 -> 28231 > > bytes > > > > Rather than binary PNG images, please use SVG files (note, real SVG, not > > an SVG file with a binary blob pasted into it). > > Based on my limited experience, there is no shortcut for this, but re-draw the picture with tools like visio. Inkscape is open source and produces svg files.