* [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address
@ 2018-01-03 13:32 Olivier Matz
2018-01-12 18:46 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2018-01-03 13:32 UTC (permalink / raw)
To: dev, Ajit Khaparde, Somnath Kotur
This operation is already done by the ethdev layer, it should not
be done by the driver.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 6f8a6335b..9d1ddae38 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1397,7 +1397,6 @@ bnxt_set_default_mac_addr_op(struct rte_eth_dev *dev, struct ether_addr *addr)
return;
memcpy(bp->mac_addr, addr, sizeof(bp->mac_addr));
- memcpy(&dev->data->mac_addrs[0], bp->mac_addr, ETHER_ADDR_LEN);
STAILQ_FOREACH(filter, &vnic->filter, next) {
/* Default Filter is at Index 0 */
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address
2018-01-03 13:32 [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address Olivier Matz
@ 2018-01-12 18:46 ` Ferruh Yigit
2018-01-12 18:48 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-12 18:46 UTC (permalink / raw)
To: Olivier Matz, dev, Ajit Khaparde, Somnath Kotur
On 1/3/2018 1:32 PM, Olivier Matz wrote:
> This operation is already done by the ethdev layer, it should not
> be done by the driver.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address
2018-01-12 18:46 ` Ferruh Yigit
@ 2018-01-12 18:48 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-12 18:48 UTC (permalink / raw)
To: Olivier Matz, dev, Ajit Khaparde, Somnath Kotur
On 1/12/2018 6:46 PM, Ferruh Yigit wrote:
> On 1/3/2018 1:32 PM, Olivier Matz wrote:
>> This operation is already done by the ethdev layer, it should not
>> be done by the driver.
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-12 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-03 13:32 [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address Olivier Matz
2018-01-12 18:46 ` Ferruh Yigit
2018-01-12 18:48 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).