Re: [dpdk-dev] [PATCH v2 16/16] net/axgbe: add support for build 32-bit mode

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri,  5 Jan 2018 04:52:18 -0500
Ravi Kumar <Ravi1.kumar@amd.com> wrote:

> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---
>  doc/guides/nics/features/axgbe.ini |  1 +
>  drivers/net/axgbe/axgbe_common.h   | 49 ++++++++++++++++++++++----------------
>  drivers/net/axgbe/axgbe_ethdev.c   | 10 ++++----
>  drivers/net/axgbe/axgbe_ethdev.h   |  8 +++----
>  drivers/net/axgbe/axgbe_rxtx.c     | 12 +++++-----
>  drivers/net/axgbe/axgbe_rxtx.h     |  4 ++--
>  6 files changed, 48 insertions(+), 36 deletions(-)
> 
> diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
> index 042ff1e..ab4da55 100644
> --- a/doc/guides/nics/features/axgbe.ini
> +++ b/doc/guides/nics/features/axgbe.ini
> @@ -15,4 +15,5 @@ L3 checksum offload  = Y
>  L4 checksum offload  = Y
>  Basic stats          = Y
>  Linux UIO            = Y
> +x86-32               = Y
>  x86-64               = Y
> diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h
> index 294f2e4..78a055d 100644
> --- a/drivers/net/axgbe/axgbe_common.h
> +++ b/drivers/net/axgbe/axgbe_common.h
> @@ -1507,7 +1507,7 @@ do {									\
>   *  register definitions formed using the input names
>   */
>  #define AXGMAC_IOREAD(_pdata, _reg)					\
> -	rte_read32((void *)((_pdata)->xgmac_regs + (_reg)))
> +	rte_read32((void *)((uint8_t *)((_pdata)->xgmac_regs) + (_reg)))
>  

Since rte_read32 is defined to take void * the cast should not be necessary..
Also in theory _pdata could be const here.