DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, remy.horton@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: ignore checkpatch warning for maintainers file
Date: Fri, 5 Jan 2018 14:33:44 -0800	[thread overview]
Message-ID: <20180105143344.1ad48354@xeon-e3> (raw)
In-Reply-To: <20180105114302.21635-1-thomas@monjalon.net>

On Fri,  5 Jan 2018 12:43:02 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> The script checkpatch.pl from Linux is enforcing a tab
> in the MAINTAINERS file (Linux commit 628f91a28649).
> It can be ignored in our wrapper checkpatches.sh.
> 
> Suggested-by: Remy Horton <remy.horton@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/checkpatches.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index a56c41a30..7676a6b50 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -41,7 +41,8 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
>  options="--no-tree"
>  options="$options --max-line-length=$length"
>  options="$options --show-types"
> -options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
> +options="$options --ignore=LINUX_VERSION_CODE,\
> +FILE_PATH_CHANGES,MAINTAINERS_STYLE,\
>  VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>  PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
>  SPLIT_STRING,LONG_LINE_STRING,\


Sure that is fine, just make it go away...

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

  parent reply	other threads:[~2018-01-05 22:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 23:48 [dpdk-dev] [PATCH] MAINTAINERS fix style Stephen Hemminger
2018-01-05 10:46 ` Remy Horton
2018-01-05 11:41   ` Thomas Monjalon
2018-01-05 11:43     ` [dpdk-dev] [PATCH] devtools: ignore checkpatch warning for maintainers file Thomas Monjalon
2018-01-05 15:30       ` Remy Horton
2018-01-05 22:33       ` Stephen Hemminger [this message]
2018-01-09  0:44         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105143344.1ad48354@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=remy.horton@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).