From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v2 00/15] common ethdev linkstatus functions
Date: Fri, 5 Jan 2018 17:06:41 -0800 [thread overview]
Message-ID: <20180106010656.9167-1-stephen@networkplumber.org> (raw)
While writing the hyperv driver, noticed a lot of unnecessary
duplication of code in drivers for handling the eth_dev link status
information. While consolidating this, it also became obvious that
some drivers behave differently for no good reason.
It also was a good chance to introduce atomic exchange primitives
in EAL because there are other places using cmpset where not
necessary (such as bonding).
Mostly only compile tested only, don't have all of the hardware
available (except ixgbe and virtio) to test.
The difference from v1 is that function name changed, rebasing
to current source and the introduction of atomic exchange.
Stephen Hemminger (15):
eal: introduce atomic exchange operation
ethdev: add linkstatus get/set helper functions
virtio: use eth_linkstatus_set
vmxnet3: use rte_eth_linkstatus_set
dpaa2: use rte_eth_linkstatus_set
nfp: use rte_eth_linkstatus functions
e1000: use rte_eth_linkstatus helpers
ixgbe: use rte_eth_linkstatus functions
sfc: use new rte_eth_linkstatus functions
i40e: use rte_eth_linkstatus functions
liquidio: use _rte_eth_linkstatus_set
thunderx: use _rte_eth_linkstatus_set
szedata: use _rte_eth_linkstatus_set
octeontx: use rte_eth_linkstatus_set
enic: use _rte_eth_linkstatus_set
drivers/net/dpaa2/dpaa2_ethdev.c | 65 ++------------
drivers/net/e1000/em_ethdev.c | 70 ++-------------
drivers/net/e1000/igb_ethdev.c | 71 ++--------------
drivers/net/enic/enic_ethdev.c | 5 +-
drivers/net/enic/enic_main.c | 16 ++--
drivers/net/i40e/i40e_ethdev.c | 44 ++--------
drivers/net/i40e/i40e_ethdev_vf.c | 19 +----
drivers/net/ixgbe/ixgbe_ethdev.c | 99 ++++------------------
drivers/net/liquidio/lio_ethdev.c | 54 ++----------
drivers/net/nfp/nfp_net.c | 75 ++--------------
drivers/net/octeontx/octeontx_ethdev.c | 16 +---
drivers/net/sfc/sfc_ethdev.c | 27 ++----
drivers/net/sfc/sfc_ev.c | 23 +----
drivers/net/szedata2/rte_eth_szedata2.c | 20 ++---
drivers/net/thunderx/nicvf_ethdev.c | 17 +---
drivers/net/virtio/virtio_ethdev.c | 67 +++------------
drivers/net/vmxnet3/vmxnet3_ethdev.c | 85 ++++---------------
.../common/include/arch/x86/rte_atomic.h | 24 ++++++
.../common/include/arch/x86/rte_atomic_32.h | 12 +++
.../common/include/arch/x86/rte_atomic_64.h | 12 +++
lib/librte_eal/common/include/generic/rte_atomic.h | 78 +++++++++++++++++
lib/librte_ether/rte_ethdev.c | 35 ++++++++
lib/librte_ether/rte_ethdev.h | 28 ++++++
23 files changed, 305 insertions(+), 657 deletions(-)
--
2.15.1
next reply other threads:[~2018-01-06 1:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 1:06 Stephen Hemminger [this message]
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-06 10:49 ` Andrew Rybchenko
2018-01-06 14:24 ` Stephen Hemminger
2018-01-06 14:35 ` Andrew Rybchenko
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-06 3:10 ` Tiwei Bie
2018-01-08 17:03 ` Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 04/15] vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 05/15] dpaa2: " Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 06/15] nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 07/15] e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 08/15] ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 09/15] sfc: use new " Stephen Hemminger
2018-01-06 11:10 ` Andrew Rybchenko
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 10/15] i40e: use " Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 11/15] liquidio: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 12/15] thunderx: " Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 13/15] szedata: " Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 14/15] octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-06 1:06 ` [dpdk-dev] [PATCH v2 15/15] enic: use _rte_eth_linkstatus_set Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106010656.9167-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).