From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30047.outbound.protection.outlook.com [40.107.3.47]) by dpdk.org (Postfix) with ESMTP id 78B621B1A2 for ; Mon, 8 Jan 2018 02:57:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KQRrSYHWxjClKaKKQCpBs9ARBCSh7TloYT8cbnq2WBg=; b=B4nCOea40m3ozltH7Xj55K4ZVgNY9z3VJS12yOmxpxbMfy/J5dMhFZLL3k2TO12fkr5xh24sBvcpgbg4BEApTiM9idB2xq081sUE2J7Sb+TKkwSY70WKhB2E057v8QyCwXcbVPFnUM/sjdznIN/onPNPHvElqQGxHj5ks5Vij0o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jianbo.Liu@arm.com; Received: from arm.com (113.29.88.7) by VI1PR0801MB1359.eurprd08.prod.outlook.com (2603:10a6:800:3b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Mon, 8 Jan 2018 01:57:21 +0000 Date: Mon, 8 Jan 2018 09:55:58 +0800 From: Jianbo Liu To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, jerin.jacob@caviumnetworks.com, dev@dpdk.org, Thomas Speier Message-ID: <20180108015557.GA25103@arm.com> References: <20171227042824.33373-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171227042824.33373-1-yskoh@mellanox.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [113.29.88.7] X-ClientProxiedBy: HK2PR02CA0185.apcprd02.prod.outlook.com (2603:1096:201:21::21) To VI1PR0801MB1359.eurprd08.prod.outlook.com (2603:10a6:800:3b::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 108c9d71-55a8-4608-ea95-08d5563b2907 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0801MB1359; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1359; 3:jrQcQ4luLydw11KZdp7IxgMrEeUPQWIEkznsMaRwlhnd46hadyZ54aq9wJzhMAUVoSzwFEodwTv5uYq3VitGkByTlJLgUx/5OpOFTTbFTVBMxMmX0fCumOnJTyV/NHjoKK3NOaKb13h630XwQgn8h1/vI3VE1LuL6R5nVuNKvaugGYcAYOoMDrquf2c+hSBjcN+03F205O1Y7Wr+i047uMtUUsFkNAnVN3ZcusSz9k2wgQFHWlBjAIFDXseguF1j; 25:O/Qmf0+4ddPTvN+YpIVsShwz3jmECHdhdfgEmtToRukfHxCNNHNMNltGbOhbHgl1ODLI02/OEUKtlctlPaS1euURla8bJs/EMQmiGh7sUQD4TippP5O07jrdwbdDHK7eLKNYorFoFWSLo/ppA7BlgzD+5yc50mGZi2BmjKcdTGt15fcaakRDAqutHUoz6rMRExW4l1BB52iqWP6tV2wrvKoha8YRgfeB/8DE5LNdCMyUfdxZxeuRiVi8n/xGLdya106xqM5FPiMyf0D2TTwQc3iZoO3y1p3IZN3hy2WXPdTJetcF71VAZnQ2fUAtn363x+SndvLHWlOFJ+Dvyc5E+Q==; 31:E4LYEF+DP0d+sAKgd1zLdti3l8kUqkrf1b1WM+yB++n4r6ZL5ZOKJh823KS0QFWJAwMn19lGsSlXTEwReUbppPtg5x0jBMMM19tM3Co09u3vUI/SB1dyEIR5RWGE1UiAJqKl07FjHOwHACzn4aYgNmsrpev71MvFfMaWv3EMU8/6K/XqedRirYt0rIfVJlS450EPFkFHqRj8seaUrXLXcB+Rwhz3DeScYJqS/GA8KjU= X-MS-TrafficTypeDiagnostic: VI1PR0801MB1359: X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr Content-Transfer-Encoding: quoted-printable X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1359; 20:mVFFNWa1sT2vuAJukmet+kqpCtgHKCX/P6G+FyYjhY7342v08vMj78dzUj+ToXmLqYnbncg6sFQGBzE8+0qjvIlmMFsffOVwEKtz/rNRpqAjG0b7z8K3/PDmUy+peTdMMG3yWSRSpplJ8xz/XjRro8aZxZ5Cj4449h9xF5dkRNcCBekPy85n0v2pU13db3lQlQ4TzNd1Ja9Quxw8DueWoGdxvwZhhixrmn/zyw5hzigQU3xngjPlfivtJLofg7RvXD85ssxPEvyuYZ+L0GRjQTaiPzGo8dmXJenW2/FfJyzPaOpMTVvd9kXy+SDfBT5A2k7LmnaQzRniGA+Cxc33Vn3LzTGZMg4TCOeWhNzsDff0lGc03Z3ZM6qQn3gZ4+OkgCk2keolXtOsEWNNfJ6hdnSKUuC7EPcyyLz8pCRpUdNwExsmNonF3T+c6v3VwbikxBLeVi/+lzbFhaLDyCD1luErTrJquGY27wEKwW/YEVgZvaEzNQvo+PALSNPofGX0; 4:AWgg9NUDSnW4Ci962UoVI5BMTtGrvdnaD1J22Z0k57TiL+npCPbTVoNuqGYolSx6jozG1yCI0UI/svOpzX6Du9zs/K8Mr/ul54dD5+/6ZT+3AiIBdZ7vSi3mtZU4iYvC9YZgRVKmxgeDj+6IE1L8V83xtf4kgRIPwsTkz4YE3IMSPN6ZSD/P8qIsFv/G8aJy4LtuPUJDv3Sp/F2J2UNdW5u8Rksx2O2vi7ms6CUmOCA+6tFwXTTaghTI12Z/y4VP1M0DNy6qaiPlIvDS76v4ZRdpSFvUUQsHEaGs0AGG0yDs/bpGzbyPj2sDjzlosF4k X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR0801MB1359; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0801MB1359; X-Forefront-PRVS: 054642504A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(366004)(39380400002)(396003)(376002)(346002)(189003)(40434004)(24454002)(199004)(5660300001)(52146003)(2906002)(23676004)(5890100001)(229853002)(81166006)(8676002)(76176011)(8936002)(52116002)(59450400001)(2486003)(7696005)(81156014)(8746002)(55236004)(386003)(50466002)(86362001)(21086003)(1076002)(316002)(6666003)(2950100002)(6916009)(305945005)(106356001)(97736004)(58126008)(72206003)(53936002)(966005)(25786009)(83506002)(16526018)(3846002)(7736002)(47776003)(6246003)(6116002)(36756003)(4326008)(68736007)(478600001)(6306002)(55016002)(66066001)(33656002)(105586002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1359; H:arm.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4MDFNQjEzNTk7MjM6SFhIenNVd2xMMEhiLzRNM3BvaDA3Z2xt?= =?utf-8?B?eWhkem5rT1FSM2U1SmVHRTR3Y3liMWFwTDJ6bC9kZk5ESnNLSm5DN2p3TEtR?= =?utf-8?B?czVnRGxBbG40RmFWWUZGd25SK3VrdGJGa1lySUpDaGRnTjdMTldEL2xWUGpS?= =?utf-8?B?NUlVS3RxYjcraUppTzRFYXRKMFo1c2JPajREczdhTHVVNVdNQnVxZnB6T3Zz?= =?utf-8?B?TWdvOU14WUU5ZXBhSjFRRkVMRGZhUDBabVBPMlNQMmxkdkJGWnQ2MncrYXJV?= =?utf-8?B?VTg0TnJMTExsQTF1UVppUldad08xazRWM2xMdWgxVHlENGtMYStneDZwaTJG?= =?utf-8?B?ZHl3MVQrTmczbnhpSmlra1ErSE0rODFBSSs5ZFpRYWhDK1hORTR3R3BJREpC?= =?utf-8?B?bExFZmVaaVFvaTdBbEZ4ZWhGM1Myb1pJUGxhYXNOWkRncU9vSnhvcjVPVkRp?= =?utf-8?B?Y0owRXlmS2V1My9rMjZGZk9hV0k5VHJSNzBJZE1neEVXUHdVa2VoanM4Mzdv?= =?utf-8?B?SzJDQzN1MkJ4bSt2eE4zaWdGSVkzbEQ3WEM3dFRHSFpvdVRsWWpKSXdDS1Rs?= =?utf-8?B?T2cwellobzZqVE93Y1RvZGVqMXNpeHh4Nll5aWRlVUpuK0p1OWRBZHhCR3c0?= =?utf-8?B?Ky93alVYRG1SL3FCdHBYRmZ1SDN2VWFTT0xNRHZzZFZOV1IzQ1lUMUJOVk9V?= =?utf-8?B?eDV1S0pwWUhyaVp5ckUzdnQ2ZmxHQXdWK2x6bUlkS0lCMlJPd1krb1d2MHN2?= =?utf-8?B?bFVNM2pVc0YxMU1kdW5mckZMdFFqd3RGZlljVEJPci9SKzBoSldFOFVwUVhx?= =?utf-8?B?eHIrbWZtY1NjZUhtdVQ1NW5XMEVQdlZyd1ZtLzlGQkRUYjdhbG9iMmdWRDcr?= =?utf-8?B?Ly8vL3JXQTRiQXhERmtFNVNKYUhWNE5UTURyMkcrUFRjNWc0V2VzWVEzcVFH?= =?utf-8?B?Kzk1QjBzNi9aQ0NWMVlIODRmdnJRa01BVi8xT1cxTTlzb2IyMGZwQTFWNk9X?= =?utf-8?B?b1lIZlhDa2Z3SlZ5MG93ZUViakJnbHhoL3owVzI2LzU3UHgrOS9VcmdjVER6?= =?utf-8?B?bGV2U2hWOWNTVXNDYmZNK0t0a0QrL2JSeG9KYitVNjVzKzBxYVZtampQTGRD?= =?utf-8?B?cGtSWXFiS3JPT0krNmorT29pU1RJK1RBNHkvbzl0ZFByYndWSkZiWDdKOTJ0?= =?utf-8?B?Zm5ySnhvVlNnb0w1N0N3NW1kR1FEVk9TcDVBTEtjZFRMTktHM1V1OHNkZndk?= =?utf-8?B?ejY1eG1pamU5VnRIT2djK1NHTlRSOCt1RWc1VWVoSWhXTWxPV0xsMGVHYUk2?= =?utf-8?B?OWRrNmNQdDhjWlVQZlpmZ1pxQk93MU42MnNUalhFWkRiMDA1WlFOYU1Nc1pl?= =?utf-8?B?cC9wUHhZNUxMRldudFlzVkFGamhQanhnVERuSlkwcnl1U2YvTzNBSEpSOEVt?= =?utf-8?B?ai92L3k5bkhLV203c0p1UkNHdkIvcFd3YUs2YU1OcFlsVHVwNlVsZmhXNytm?= =?utf-8?B?WndKcS8rVzhySHkrOXJTV25uRVNheDliSTdTcUZFS3F0MFlrVFB2YXlQdXov?= =?utf-8?B?ejVwNlpvSG5SRmlGeFpjVDBMeG5PanZJR2Z0V1puejdMOEdSVFVZM1p5aUdm?= =?utf-8?B?eCswc0ZPTEs2WHNXNVA3d25yV1IwS1BkR2ZvT0JpZ2s1dXNkRzNuZ2NJSEtV?= =?utf-8?B?Znl4eHZrK3NZMXZGUDlBVXpKK0dOYy9DTngyWkZLeTRVWEZXNlpFREFxc2kx?= =?utf-8?B?bDlwQzFaVHc2OElVeS9GZkRKZ080cFhxblduTWlJWHJ5RkYyMVdycmVvTDBM?= =?utf-8?B?YkdRcVhYOGRsZUtzeDBlemlCa1JndEgwY1RCOHFoaXlaN0R4QzVMeWE4d1Vt?= =?utf-8?Q?frjx8SH3zQg0IxjCUNqqxi/GlC06uRSFaM?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1359; 6:tjMRZQyDgVsol8zvTyJtYai0mCKfyh21CPWoWswMv1WnAirh3fbniWxBWLZ92PVBXpW0WFyL99vuou/Ce/Ir+X1Jewhz7Z0gv4urBT0nTwl/rD127CHL5aMlMhkrCq6JXUawjiHBAD2x9qK5zH68f7aDOxTWWXL0tB8eNxohuZllA1Bzk3t9JpX12m1IUMYlTK6irswM27a/aMQ48GzOAFUyi0e+rmkXpm6az+BS2CS9CjRw1EhA58Yp4J/iGP53Ti95f7mMyTRzScagPOBiPXJ79DB0D5CSHYiF5AV1/cvqelyYaokxJYSntfltmlBEaIaKD76anROKk0ioiOCYzA==; 5:6GUHMWepI5AnHEpsLXX9OCNEj6elwBzuOdAYJGO4OQJIa2pg5KNeA5M5Jwg8Ri3032pYhQo1/Eg96RTnqwLGdVJcbque+jv4e8wrRDhQVmmKNt4QmMzSNHAdVclzfGYiEBlcj3wbl4Yx1FhEtROg5H+cFB1iKvaP4YKMM3L5EME=; 24:NeHK8ebtVZlCzzKJAZOSpXD1MynaLZ0x+wiLltNHeayNlNeXqSDmVVeftiDT4WY+Tr5jm795v6RcPb6ETM1CAs9I5Mx1S1pMC/czrSDUaVI=; 7:fFlXYxmxW2JETReDpZ5+BX2n0kCIzhbk3UPX4c1uJedywbScLX76RJaJQbk921ob84xDb1NSWyq7U+Eos6W1XWl799oR6Y6U4/plIpDRYyY0Eq0NoEvJGABKChL18W8T5QZn+xPJ9jI9rt5YTKwEZgWSFNQ2pcBaXTeWSdjm6jRF/Z8/dWk7pc7F3YEI8DTQ9wJMDiTpo8lvQkKsDk/wacQrs+BcyHIif6JdU2fC6I9vHKB9Le6qcDdkqbR+9Djh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2018 01:57:21.2361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 108c9d71-55a8-4608-ea95-08d5563b2907 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1359 Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm64: modify I/O device memory barriers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 01:57:25 -0000 The 12/26/2017 20:28, Yongseok Koh wrote: > Instead of using system-wide 'dsb' instruction for IO barriers, 'dmb' is > sufficient and could bring better performance. Using 'dmb' with Outer > Shareable Domain option is also consistent with linux kernel. But in kernel dsb is used for io barriers. https://github.com/torvalds/linux/blob/master/arch/arm64/include/asm/io.h#L= 109 Do you consider adding dma_*mb? https://github.com/torvalds/linux/blob/master/arch/arm64/include/asm/barrie= r.h#L40 > > Cc: Thomas Speier > > Signed-off-by: Yongseok Koh > Acked-by: Thomas Speier > Acked-by: Shahaf Shuler > --- > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib= /librte_eal/common/include/arch/arm/rte_atomic_64.h > index 0b70d6209..8dcce6054 100644 > --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > @@ -58,11 +58,11 @@ extern "C" { > > #define rte_smp_rmb() dmb(ishld) > > -#define rte_io_mb() rte_mb() > +#define rte_io_mb() dmb(osh) > > -#define rte_io_wmb() rte_wmb() > +#define rte_io_wmb() dmb(oshst) > > -#define rte_io_rmb() rte_rmb() > +#define rte_io_rmb() dmb(oshld) > > #ifdef __cplusplus > } > -- > 2.11.0 > -- IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.