From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 82ACA1B171 for ; Tue, 9 Jan 2018 14:15:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 01EE22073F; Tue, 9 Jan 2018 08:15:07 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 09 Jan 2018 08:15:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=gGXPLuxPuwa+kns7P5leg7pmUTtQKR0BD8aBI/FsoXI=; b=qAnVV0Pr 1NFCC8XgHy9G5xQqDdKqaYIY7qH3eifubvuP5Graam7EUUhjeqcLQkdNmTw92+d5 xj24vcMzxunCt0EqZeUKN/qfzPcCXsg2lkkID7jTzmHY7baNGKs/ydylDoflYtot P8rbfOeP5D1cYm1PBemz4dUN8hpM/OwlUi8tySBavSfrdVhZyBDQi7ujp7y+PCgk OEj8kBMge1YVvwymarotxXRmHuaJ5h9NlhpiBaGD5Ln/6kXAHLhmYv54m2Wb7jHy 8OU3lo8ptjy73WBx6EzVQ2+5jnQSf1Ox4H+ci6shlA3UhGZqv7eqs7HxLgx0r0WI wG7XqrL0HtHwbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=gGXPLuxPuwa+kns7P5leg7pmUTtQK R0BD8aBI/FsoXI=; b=iarQtLG5zlPpNNyOXrBENM9FmXZ/z9mYqMzOuO7SEG2dn JNLZD3seRSYiZ53aiNlyxvrkGWbdDxaiOYhM17JKrtwZP4b4K9MOoZboNzEKjPu8 eyEPnkq7LOAElJwPmXa3ztb1+LbuZoCg1xeATS0PEbHetB8NSWD56/xO5LFvIAXM CtRlrADj/wUKH2K5HEIvX5aQYQJ/zDNR/IcMonHzlN+cLM44OYhZN368dntzK+lR FCusJnENr5J3Mtx0TgatmNTfzLhl9/T9+dhgK8i6cnwE25shNaRI4fDOjhRADw8/ DlyLllhpGlmaXU0w9DGyT0JjSaGocGknk7HM+/INg== X-ME-Sender: Received: from yliu-mob (unknown [115.150.10.63]) by mail.messagingengine.com (Postfix) with ESMTPA id B2F477E354; Tue, 9 Jan 2018 08:15:05 -0500 (EST) Date: Tue, 9 Jan 2018 21:15:02 +0800 From: Yuanhan Liu To: Zhike Wang Cc: dev@dpdk.org Message-ID: <20180109131502.GK29540@yliu-mob> References: <1515148086-38104-1-git-send-email-wangzhike@jd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515148086-38104-1-git-send-email-wangzhike@jd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 13:15:07 -0000 On Fri, Jan 05, 2018 at 02:28:06AM -0800, Zhike Wang wrote: > From: zhike wang > > The max_mtu is kept as zero in case no CRTL channel, which leads > to failure when calling virtio_mtu_set(). > > Signed-off-by: Zhike Wang Applied to dpdk-next-virtio. Thanks. --yliu > --- > drivers/net/virtio/virtio_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 21f2131..b7b3364 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1479,6 +1479,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev, > } else { > PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1"); > hw->max_queue_pairs = 1; > + hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN - > + VLAN_TAG_LEN - hw->vtnet_hdr_size; > } > > ret = virtio_alloc_queues(eth_dev); > -- > 1.8.3.1