From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 999CE1B168; Wed, 10 Jan 2018 07:01:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 22:01:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,338,1511856000"; d="scan'208";a="19759682" Received: from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.198]) by fmsmga004.fm.intel.com with ESMTP; 09 Jan 2018 22:01:03 -0800 From: Zhiyong Yang To: dev@dpdk.org Cc: yliu@fridaylinux.org, stable@dpdk.org, Zhiyong Yang Date: Wed, 10 Jan 2018 14:01:01 +0800 Message-Id: <20180110060101.26038-1-zhiyong.yang@intel.com> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20180104063332.5248-1-zhiyong.yang@intel.com> References: <20180104063332.5248-1-zhiyong.yang@intel.com> Subject: [dpdk-dev] [PATCH v2] examples/vhost: fix remove dev_info.max_rx_queues checking to solve startup failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 06:01:06 -0000 For vhost sample, the operation if (dev_info.max_rx_queues > MAX_QUEUES) in the function port_init causes startup failure when using X710(i40e driver). X710 requires that MAX_QUEUES should be defined no less than 320, however it is defined as 128 currently. Such checking is overkill and Removal don't affect any functionality (have already validated ixgbe and i40e). The removal can avoid similar issue when introduing new physical NIC. Fixes: 8bd6c395a568("examples/vhost: increase maximum queue number") Cc: stable@dpdk.org Signed-off-by: Zhiyong Yang --- Changes in V2: 1. Remove the checking instead of redefine macro "MAX_QUEUES" examples/vhost/main.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 10a7f5d32..1f532fe3b 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -279,12 +279,6 @@ port_init(uint16_t port) /* The max pool number from dev_info will be used to validate the pool number specified in cmd line */ rte_eth_dev_info_get (port, &dev_info); - if (dev_info.max_rx_queues > MAX_QUEUES) { - rte_exit(EXIT_FAILURE, - "please define MAX_QUEUES no less than %u in %s\n", - dev_info.max_rx_queues, __FILE__); - } - rxconf = &dev_info.default_rxconf; txconf = &dev_info.default_txconf; rxconf->rx_drop_en = 1; -- 2.13.3