From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) by dpdk.org (Postfix) with ESMTP id 089D71B234 for ; Wed, 10 Jan 2018 10:18:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4245; q=dns/txt; s=iport; t=1515575886; x=1516785486; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=VjSwMV0X+VADE9XoAnmROePHF7Fhf/XA8VwuhSiP664=; b=T02kN12gxLNVfO5Fy60c8SosKx0C/Vgo3JqfIcNKrv3AGYUfMg966Egu uYZrKqF6u/oltGMX8CdkShaUkp2cqfQP0rI8UKY2X85eKvHqTs4NMoDxe jnHT8+0mApfARxbHwuVDfDP1wfZhwzVopLLOdQglwrXPwiV336QV3rI3y 8=; X-IronPort-AV: E=Sophos;i="5.46,339,1511827200"; d="scan'208";a="339609059" Received: from alln-core-3.cisco.com ([173.36.13.136]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 09:18:05 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id w0A9I5MI021084; Wed, 10 Jan 2018 09:18:05 GMT Received: by cisco.com (Postfix, from userid 392789) id 48FC020F2001; Wed, 10 Jan 2018 01:18:05 -0800 (PST) From: John Daley To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Hyong Youb Kim Date: Wed, 10 Jan 2018 01:17:09 -0800 Message-Id: <20180110091712.32198-9-johndale@cisco.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180110091712.32198-1-johndale@cisco.com> References: <20180110091712.32198-1-johndale@cisco.com> Subject: [dpdk-dev] [PATCH] net/enic: use dynamic log types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 09:18:06 -0000 From: Hyong Youb Kim "pmd.enic.init" replaces CONFIG_RTE_LIBRTE_ENIC_DEBUG "pmd.enic.flow" replaces CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- config/common_base | 2 -- doc/guides/nics/enic.rst | 6 ------ drivers/net/enic/enic_compat.h | 2 ++ drivers/net/enic/enic_ethdev.c | 26 ++++++++++++++++++++------ drivers/net/enic/enic_flow.c | 11 ++++------- 5 files changed, 26 insertions(+), 21 deletions(-) diff --git a/config/common_base b/config/common_base index 5ee18420c..918bf65d0 100644 --- a/config/common_base +++ b/config/common_base @@ -256,8 +256,6 @@ CONFIG_RTE_LIBRTE_CXGBE_TPUT=y # Compile burst-oriented Cisco ENIC PMD driver # CONFIG_RTE_LIBRTE_ENIC_PMD=y -CONFIG_RTE_LIBRTE_ENIC_DEBUG=n -CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW=n # # Compile burst-oriented Netronome NFP PMD driver diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst index 22df466b4..4dffce1a6 100644 --- a/doc/guides/nics/enic.rst +++ b/doc/guides/nics/enic.rst @@ -52,12 +52,6 @@ Configuration information - **CONFIG_RTE_LIBRTE_ENIC_PMD** (default y): Enables or disables inclusion of the ENIC PMD driver in the DPDK compilation. - - **CONFIG_RTE_LIBRTE_ENIC_DEBUG** (default n): Enables or disables debug - logging within the ENIC PMD driver. - - - **CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW** (default n): Enables or disables flow - API related debug logging within the ENIC PMD driver. - - **vNIC Configuration Parameters** - **Number of Queues** diff --git a/drivers/net/enic/enic_compat.h b/drivers/net/enic/enic_compat.h index 1cb5686f8..4fb92dd9c 100644 --- a/drivers/net/enic/enic_compat.h +++ b/drivers/net/enic/enic_compat.h @@ -84,6 +84,8 @@ #define dev_warning(x, args...) dev_printk(WARNING, args) #define dev_debug(x, args...) dev_printk(DEBUG, args) +extern int enicpmd_logtype_flow; + #define __le16 u16 #define __le32 u32 #define __le64 u64 diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index 24916312f..5132966d0 100644 --- a/drivers/net/enic/enic_ethdev.c +++ b/drivers/net/enic/enic_ethdev.c @@ -49,12 +49,14 @@ #include "vnic_enet.h" #include "enic.h" -#ifdef RTE_LIBRTE_ENIC_DEBUG -#define ENICPMD_FUNC_TRACE() \ - RTE_LOG(DEBUG, PMD, "ENICPMD trace: %s\n", __func__) -#else -#define ENICPMD_FUNC_TRACE() (void)0 -#endif +int enicpmd_logtype_init; +int enicpmd_logtype_flow; + +#define PMD_INIT_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, enicpmd_logtype_init, \ + "%s" fmt "\n", __func__, ##args) + +#define ENICPMD_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") /* * The set of PCI devices this driver supports @@ -66,6 +68,18 @@ static const struct rte_pci_id pci_id_enic_map[] = { {.vendor_id = 0, /* sentinel */}, }; +RTE_INIT(enicpmd_init_log); +static void +enicpmd_init_log(void) +{ + enicpmd_logtype_init = rte_log_register("pmd.enic.init"); + if (enicpmd_logtype_init >= 0) + rte_log_set_level(enicpmd_logtype_init, RTE_LOG_NOTICE); + enicpmd_logtype_flow = rte_log_register("pmd.enic.flow"); + if (enicpmd_logtype_flow >= 0) + rte_log_set_level(enicpmd_logtype_flow, RTE_LOG_NOTICE); +} + static int enicpmd_fdir_ctrl_func(struct rte_eth_dev *eth_dev, enum rte_filter_op filter_op, void *arg) diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c index a728d0777..190762eb6 100644 --- a/drivers/net/enic/enic_flow.c +++ b/drivers/net/enic/enic_flow.c @@ -42,15 +42,12 @@ #include "vnic_dev.h" #include "vnic_nic.h" -#ifdef RTE_LIBRTE_ENIC_DEBUG_FLOW #define FLOW_TRACE() \ - RTE_LOG(DEBUG, PMD, "%s()\n", __func__) + rte_log(RTE_LOG_DEBUG, enicpmd_logtype_flow, \ + "%s()\n", __func__) #define FLOW_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, fmt, ## args) -#else -#define FLOW_TRACE() do { } while (0) -#define FLOW_LOG(level, fmt, args...) do { } while (0) -#endif + rte_log(RTE_LOG_ ## level, enicpmd_logtype_flow, \ + fmt "\n", ##args) /** Info about how to copy items into enic filters. */ struct enic_items { -- 2.12.0